Previously, our query would select all of Internals>Network>* and then
subtract bugs with one of the out-of-scope components. The problem is
this filters out bugs that contain both an in-scope and an out-of-scope
bug component.
The new queries use an additive approach that names each of the
in-scope components directly.
NOTRY=true
Change-Id: I8526c49a38d45d41caa4d53b3c6103d281e7f4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367983
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800644}
Documents the implementation and use of host resolution.
Remove net/docs/host-resolver.md as it is old, dated, and largely
replaced by this newer documentation.
Change-Id: Ia440e7593446a1b7af5646c1fd5fd630eee4073d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597224
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791411}
* Delete the "*suggested-workflow.md" document in favor of a
single triage document
* Remove responsibility of discovering unlabeled network bugs
* Add responsibility of triaging subcomponents
* Add responsibility of sending summary email
* Add extra details on how to triage
Change-Id: I8eb02fe9b107a1c90cc8a2de35d969402eacdc32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239580
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777895}
In particular, mention SameSite cookies, assembling the cache key
(using the NIK), provide a bit more detail on other schemes,
particularly websockets and data URLs, and remove information about
FTP.
Bug: None
Change-Id: I3fe69c2f7ea7b4d1e299d9c68973142b87dafcdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144685
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758266}
There have been a number of changes since the document was last updated.
Also clarify a few things.
This CL covers through checking the cache. I'll continue updating other
sections once this lands.
Bug: None
Change-Id: I5b205f81fb42c4d2727515fbc5d10f49d0b7736b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141138
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757874}
Remove bugs with a comment by
"425761728072-pa1bs18esuhp2cp2qfa1u9vb6p1v6kfu@developer.gserviceaccount.com"
from the filter for finding unlabelled network bugs. These are bugs
reported by FindIt and other related tools. They generally already have
a label attached, and there tend to be rather a lot of them.
Going through 200 bugs titled "x% regression in whatever" isn't terribly
productive, and skipping over them makes it easier to miss user-reported
bugs.
Bug: None
Change-Id: I680691ca987746e219a4edb307d418d7fa0bfede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728176
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682832}
The NetLog is now an internal detail of the Network Service.
In particular this CL:
* Removes ChromeNetLog class
* Removes ContentBrowserClient::GetNetLog()
* Removes BrowserProcess::net_log()
* Removes support for writing to a NetLog when Network Service is disabled.
And exception is made for Android WebView, which preserves support for NetLog when Network Service is not enabled.
Bug: 934009,767450
Change-Id: I95e2a6aae85ec9c7b90bce08c57e23cb688e5d02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663846
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671472}
* Add a table of contents
* Use "proxy server identifier" throughout
* Rework the proxy server identifier section
* Use URI formatted proxy server identifiers throughout document
* Add some links between sections
Change-Id: Ie61212697cf70a2532d971113dbd550639ae9f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636259
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665608}
Reason: with the advent of other scheduling primitives in //base
(i.e. SequenceManager), TaskScheduler was no longer the only component
responsible for scheduling tasks. We will from now on refer to the
whole of //base/task as the "task scheduling infrastructure".
There are other types named "TaskScheduler" outside of base:: so
s/TaskScheduler/ThreadPool/ across the codebase wasn't possible.
Instead, this CL did:
1) base/task/task_scheduler => base/task/thread_pool
(catches all files with includes)
1.1) Careful manual search to add files without includes
(e.g. missing IWYU, docs, etc.)
2) TaskScheduler => ThreadPool in all files affected by (1)
3) task_scheduler => thread_pool in all files affected by (1)
4) "task scheduler" => "thread pool" in all files affected by (1)
4) Move task_scheduler_util like headers in
//content //components and //ios
Also:
* Renamed UMA metrics from TaskScheduler.* to ThreadPool.*
and dropped "Pool" from worker pool name suffixes.
* Renamed TaskScheduler*Worker thread names to ThreadPool*Worker
* In base/android: NativeTaskScheduler => NativeScheduler as it
was referring to the whole of base/task.
TaskSchedulerTest.java => NativePostTaskTest.java (former DNE)
* Intentionally ignoring IWYU violations in this already too large
CL.
In follow-up:
* Rename other types as well:
SchedulerWorker => WorkerThread
SchedulerWorkerPool* => WorkerThreadGroup*
Bug: 951388
Change-Id: I5bc2688b593c7682ef7e56d6b228539970ba107e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561552
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650997}
Updates the network documentation to reflect that the network service
may not be running in the browser process. Also, fixes some minor typos.
Change-Id: Ie89fe73c55640a404daca618de0f32ef5fa472dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540364
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644612}
