This change deletes WebSQL data from Non-Android Platforms.
WebSQL has been removed by default from M119, and
deprecation trial has ended on May 28,2024 (M126) for
all platforms except Android WebView.
AppCache data cleanup has been removed because it was added
in 2020, and has lived for about 4 years.
Removal on Android WebView is tracked in
https://crbug.com/333756088.
Bug: 40910849
Change-Id: If7bd67a4f3871b7eedeb83a4e50984a1184d2972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5507087
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1314679}
What: consolidate Prefetch & Topics URLLoaderService into a
single SubresourceProxyingURLLoaderService.
Why:
- It reduces the number of renderer->browser Mojo channels.
Offline testing shows that this improves ~30 KB
Memory.Browser.PrivateMemoryFootprint for each frame.
- This makes it easier to extend functions: future features (and
the pre-existing KeepAlive factory) can all be consolidated into
this service -- no need to plumb a new factory through layers
each time.
- This also makes it possible to stack different types of
requests (e.g. keep-alive & topics, when the keep-alive service
gets consolidated as well).
Bug: 1444215
Change-Id: Iccee1ff169b6611ec47a9312642e805fd6d9edb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520622
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144877}
This reverts commit 36ea585db1.
http://crrev.com/c/3691982 introduced DisposeStoragePartition
to ditch the one-time storage partition used in ChromeOS sign-in.
It turns out it is unsafe to dispose SPs because they could
referenced later, even after <webview> referencing them are
destroyed. We hit UAF like in http://crbug/1382971. This CL
removes the unsafe API.
The memory issue will be fixed in a different way.
Bug: 1308831, b:260522812
Change-Id: Ic6d1b219037f8424bc8031415b7cd2e2238336fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184936
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1095918}
Each gaia sign-in attempt creates an in-memory storage partition.
After the sign-in attempt, the storage partition needs to be disposed.
Otherwise, they are kept around indefinite, which wastes memory.
Bug: 1308831
Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
Change-Id: I4631a2b1630ce6d37b863e3ec0aebc635c6179c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3691982
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016742}
This CL refactors the origin version of ClearData() to take a
StorageKey in place of the origin.
This change allows callers of the function to clear the data contained
in a partition addressed by any arbitrary StorageKey. However, no
behavior is changed as part of this CL, callers' origins are just
converted to StorageKeys.
Bug: 1319427
Change-Id: I92192c9845d6c30ca02045b7b1f3e46b45e089f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702946
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016712}
Instead of returning a generic callback and let the caller bind the path
as a parameter. This CL changes this function to take the `path` as a
parameter, so the caller doesn't need to call BindOnce() to bind the
path.
Same change for base::GetDeletePathRecursivelyCallback().
Bug: 1321695
Test: No functionality change
Change-Id: I45eb5217635e5fe1de6c1120ebaa99f0e068ad3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3632179
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000422}
Absolutely no call site ever does anything except call this on a newly
constructed vector, so this is much more natural. Some trivial
simplification is possible at call sites.
Change-Id: I989dd2ce569fe46afd2abc6b6cc325aa85e7225f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456906
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970764}
This is a part of the service worker onion soup project. This CL moves
ServiceWorkerUtils::ContainsDisallowedCharacter() in
content/common/service_worker/ to service_worker_scope_match in
blink/public/common/service_worker/.
In addition to that, this CL removes content/common/service_worker/ as
ServiceWorkerUtils::ContainsDisallowedCharacter() was the last function
in the directory.
Bug: 789857
Change-Id: Ifb57a08c8e1641182befd8b98d19c63e869037b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312389
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#948934}
This CL was generated by using tools/git/move_source_file.py to change
the includes for those files:
base/bind_post_task.h
base/deferred_sequenced_task_runner.h
base/post_task_and_reply_with_result_internal.h
base/sequenced_task_runner.h
base/sequenced_task_runner_helpers.h
base/single_thread_task_runner.h
base/task_runner.h
base/task_runner_util.h
base/updateable_sequenced_task_runner.h
Then formatted using "git cl format". DEPS files were fixed with a
simple search and replace script.
Bug: 1255932
Change-Id: I0d9b5ddd9260fde5e4581e6c6e0080bdb0ed2c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209175
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929867}
We added an optional callback to ExtensionService::UninstallExtension()
in order to be informed about when the extension data is safely deleted
(ExtensionService::UninstallExtensionOnFileThread() and
DataDeleter::StartDeleting()).
This is part of a bigger effort to create a data clean-up mechanism for
Chrome apps/extensions. Since Chrome apps/extensions don’t have a
built-in “reset” operation, we uninstall them to fully clear their state
(thus we need to wait for the data to be completely deleted) and
reinstall them back.
More details can be found here: go/imprivata-extension-data-cleanup
Bug: b:186737187
Change-Id: I49ef81af3b5573169ac681c137b3a00798817899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3109967
Commit-Queue: Maria Petrisor <mpetrisor@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917859}
This is no longer needed as the linked bug is fixed. This CL also
removes up old comments/code that no longer appear relevant to this
function.
Bug: 960012
Change-Id: I346db797afa4899367ecd5527c10233cf3901f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3055813
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909110}
The CookieStoreContext class was responsible for straddling between the
UI thread and the service worker core thread. However, the service
workers implementation now always runs on the UI thread, so no thread
hopping is required.
Since the CookieStoreContext class has lost its responsibility, this
CL removes it.
Bug: 1138155
Change-Id: I8efbf0acdc6ac6a75805b7163a71fccabcb1c3d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064416
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908445}
This CL adds a GetConfig() method to StoragePartition, which returns the
config used to create the StoragePartition. It also defines a new
StoragePartitionConfig::CreateForTesting helper to create
StoragePartitionConfig's without a BrowserContext.
Bug: 1212266, 1229912
Change-Id: I05cb1990121828a24c01d1956915b16559496e88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3027490
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#903702}
List of files to delete from generated using the following command:
git grep -l base/strings/stringprintf.h | \
xargs grep -L 'StringPrint[fV]' | xargs grep -L StringAppend | \
grep -E '(cc|mm|h)$'
Change-Id: Ibc72245f08730b4d25283e2d966235b61513c7ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2849392
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#876365}
This CL is a no-op.
Expose BrowserThread::GetTaskRunnerForThread helper and use it to
migrate remaining callers of the old BrowserThread APIs going through
base::.
All other callers using static BrowserTaskTraits (i.e. pre-determined
at compile time, no variables) have already been migrated, these
are the only ones remaining.
Bug: 1026641
Change-Id: I7d068872bda21810e430ce4844f728e4e94c1b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787574
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867554}
This is a cleanup of a long-ago change I made to how cache storage got
initialized with the BlobStorageContext. As cache storage is moving to
the storage service, it can't access BlobStorageContext directly
anymore.
This cleans up the initialization dance to pass in the remote at
construction time rather than a pointer much later on. It also moves
BlobStorageContextWrapper (a sequence-bound refcounted remote) which is
only used by cache storage into the cache storage directory, as cache
storage will not be able to access blob_storage from the storage
service.
This is a reland of:
https://chromium-review.googlesource.com/c/chromium/src/+/2651182
Bug: 1147642,1172212
Change-Id: I1241abd435a1ccb316d04dcb706d4820db9eee63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2659226
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850762}
This is a cleanup of a long-ago change I made to how cache storage got
initialized with the BlobStorageContext. As cache storage is moving to
the storage service, it can't access BlobStorageContext directly
anymore.
This cleans up the initialization dance to pass in the remote at
construction time rather than a pointer much later on. It also moves
BlobStorageContextWrapper (a sequence-bound refcounted remote) which is
only used by cache storage into the cache storage directory, as cache
storage will not be able to access blob_storage from the storage
service.
Bug: 1147642
Change-Id: I8f41c5bca1cac12135eb85358fd1d49269693791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2651182
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848320}
Different storage partitions should not be able to resolve blob URLs
created in other partitions. To ensure this, give each partition their
own blob url registry.
There is one exception though, a <webview> inside a chrome app should
be able to resolve blob URLs that were created by the chrome app. To
enable this, we add the concept of a "fallback url registry" to
BlobUrlRegistry, and pass the BlobUrlRegistry of the app in as fallback
when creating the storage partition for a <webview>.
Bug: 1106890
Change-Id: I809f24a2c0b4d8d21e53d46bb6d3e2027b21281b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324110
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804321}
This reverts commit bd17f19837.
Reason for revert: Test is flaky, especially on Fuchsia bots.
Original change's description:
> appcache: delete appcache directory from profile when disabled
>
> Once AppCache has been removed from Chrome, sites will have no way of
> cleaning up user data in local profiles. To fix this, when a storage
> partition is accessed when AppCache has been disabled, we will delete
> the AppCache directory from that profile directory.
>
> Bug: 1081897
> Change-Id: Iea404f7c83595ba1397fab4a5d3f97d1e3280916
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343588
> Commit-Queue: enne <enne@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796938}
TBR=kinuko@chromium.org,mek@chromium.org,enne@chromium.org
Change-Id: Ic43fce0f9ad605a7bfb3a291a320e45d8c329b9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1081897, 1115296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351834
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797219}
Once AppCache has been removed from Chrome, sites will have no way of
cleaning up user data in local profiles. To fix this, when a storage
partition is accessed when AppCache has been disabled, we will delete
the AppCache directory from that profile directory.
Bug: 1081897
Change-Id: Iea404f7c83595ba1397fab4a5d3f97d1e3280916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343588
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796938}
Currently, disabling AppCache by turning off blink::features::kAppCache
is a shallow disabling, in that the web api and the loader no longer use
it, and its preference is disabled, but the service is still created.
This is a step towards adding data deletion behavior when this feature
is disabled. It doesn't make sense to delete the data folder when there
is still an appcache service that exists at runtime.
This patch makes the AppCache service optional and does not create it
when the kAppCache feature is disabled.
Bug: 1081897
Change-Id: I3a2a6cf4dd5bb8654a3c0da9ce310acff91766eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339920
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796715}
This reverts commit e16ff9f100.
Reason for revert: Bot was still red after revert: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/15944
Original change's description:
> Revert "Add StoragePartitionConfig class."
>
> This reverts commit 225f6f4c82.
>
> Reason for revert: I think this is causing failures in:
> virtual/omt-worker-fetch/external/wpt/workers/modules/dedicated-worker-import.any.worker.html
> http/tests/workers/worker-usecounter.html
> virtual/omt-worker-fetch/http/tests/workers/worker-usecounter.html
> and the "webkit_lint" step.
> See example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/47132
>
> Original change's description:
> > Add StoragePartitionConfig class.
> >
> > Introducing StoragePartitionConfig to make it easier for code to
> > directly request the StoragePartition they need instead of having to
> > go through the indirection of site URLs. Grouping the 3 attributes of
> > a config into a class also makes several call sites simpler. This is
> > being done as part of an effort to reduce the amount of code that
> > depends on site URLs.
> >
> > - Created class for storing the storage partition
> > <domain, name, in_memory> tuple.
> > - Update GetStoragePartitionConfigForSite() and related code to use
> > this new class.
> > - Create BrowserContest::GetStoragePartition() method that takes
> > StoragePartitionConfig as a parameter so future callers do not need
> > to construct a site URL to get a storage partition.
> > - Remove StoragePartitionImplMap::StoragePartitionConfig struct and
> > convert StoragePartitionImplMap to use the new StoragePartitionConfig
> > class.
> >
> > Bug: 1085275
> > Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240
> > Commit-Queue: Aaron Colwell <acolwell@chromium.org>
> > Reviewed-by: Aaron Colwell <acolwell@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: James MacLean <wjmaclean@chromium.org>
> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> > Auto-Submit: Aaron Colwell <acolwell@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#781691}
>
> TBR=acolwell@chromium.org,alexmos@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org
>
> Change-Id: Iec47df87cb66a779d2d569e825c9b4ecccf1f2ef
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1085275
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263216
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781798}
TBR=acolwell@chromium.org,alexmos@chromium.org,bsep@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org
# Not skipping CQ checks because this is a reland.
Bug: 1085275
Change-Id: I6eaf4a96de9e08f93e450f708cf6eea5c33ec5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264292
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781864}
This reverts commit 225f6f4c82.
Reason for revert: I think this is causing failures in:
virtual/omt-worker-fetch/external/wpt/workers/modules/dedicated-worker-import.any.worker.html
http/tests/workers/worker-usecounter.html
virtual/omt-worker-fetch/http/tests/workers/worker-usecounter.html
and the "webkit_lint" step.
See example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/47132
Original change's description:
> Add StoragePartitionConfig class.
>
> Introducing StoragePartitionConfig to make it easier for code to
> directly request the StoragePartition they need instead of having to
> go through the indirection of site URLs. Grouping the 3 attributes of
> a config into a class also makes several call sites simpler. This is
> being done as part of an effort to reduce the amount of code that
> depends on site URLs.
>
> - Created class for storing the storage partition
> <domain, name, in_memory> tuple.
> - Update GetStoragePartitionConfigForSite() and related code to use
> this new class.
> - Create BrowserContest::GetStoragePartition() method that takes
> StoragePartitionConfig as a parameter so future callers do not need
> to construct a site URL to get a storage partition.
> - Remove StoragePartitionImplMap::StoragePartitionConfig struct and
> convert StoragePartitionImplMap to use the new StoragePartitionConfig
> class.
>
> Bug: 1085275
> Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240
> Commit-Queue: Aaron Colwell <acolwell@chromium.org>
> Reviewed-by: Aaron Colwell <acolwell@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Auto-Submit: Aaron Colwell <acolwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781691}
TBR=acolwell@chromium.org,alexmos@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org
Change-Id: Iec47df87cb66a779d2d569e825c9b4ecccf1f2ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1085275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263216
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781798}
Introducing StoragePartitionConfig to make it easier for code to
directly request the StoragePartition they need instead of having to
go through the indirection of site URLs. Grouping the 3 attributes of
a config into a class also makes several call sites simpler. This is
being done as part of an effort to reduce the amount of code that
depends on site URLs.
- Created class for storing the storage partition
<domain, name, in_memory> tuple.
- Update GetStoragePartitionConfigForSite() and related code to use
this new class.
- Create BrowserContest::GetStoragePartition() method that takes
StoragePartitionConfig as a parameter so future callers do not need
to construct a site URL to get a storage partition.
- Remove StoragePartitionImplMap::StoragePartitionConfig struct and
convert StoragePartitionImplMap to use the new StoragePartitionConfig
class.
Bug: 1085275
Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781691}
There exists some base::DeleteFileRecursively() callers that want to use
PostTask() APIs to delete a path on another task runner. To do so, they
currently write:
base::BindOnce(base::IgnoreResult(&base::DeleteFile), path, true)
To simply the callers, and help transition base::DeleteFile() to remove
its |recursive| boolean parameter, add
base::GetDeletePathRecursivelyCallback(). Now, callers can just write:
base::BindOnce(base::GetDeletePathRecursivelyCallback(), path)
Use base::GetDeletePathRecursivelyCallback() in chrome/ and content/,
and add a TODO note to rename base::DeleteFileRecursively() to
base::DeletePathRecursively().
Bug: 1009837
Change-Id: I9c229fa668dea13f0bf24f20eb6ce066ac1eca33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204683
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777685}
Note to QA: This CL is purely mechanical and shouldn't be blamed
for future regressions on touched files.
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2211138
which already removed all usage using content::BrowserThread.
Hence this script now matches unqualified BrowserThread:: without
risking having "content::" be selected as "traits_before" by the regex
(ran on same revision as step #1).
content:: is now always added if outside namespace content {}
(deleting unused using content::BrowserThread; decls)
Script @ https://crbug.com/1026641#c92
(will TBR fdoray@ post-review for mechanical change)
TBR=fdoray@hchromium.org
AX-Relnotes: n/a.
Bug: 1026641
Change-Id: I51ae2f83eb17d19b54563fd9b4fc040d2aa0c948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212469
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772458}
