The check is failing because it was written as if the content of the
file returned with f.NewContents() is a string. It is actually a list.
This CL fixes it.
The check never worked.
Bug: 798289
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icfd216bbcaee78671878b65ac412b9063bd24509
Reviewed-on: https://chromium-review.googlesource.com/847372
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526452}
Add EarlGrey tests tryjobs to ios changes. We want to have EG
tests running for at least ios changes to reduce tree breakages.
Since the ios-simulator-full-configs has only 8 builders, iOS CLs might
experience extra landing time due to the tryjob size and limited capacity.
Bug: 782735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8c00dbe1963893af19c37d7410e6d57c8d37ab5d
Reviewed-on: https://chromium-review.googlesource.com/759166
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515214}
All TODOs in src/ios/ should follow the format TODO(crbug.com/######)
so add a PRESUBMIT.py check (and corresponding unit tests) for that.
BUG=677203
Change-Id: I360ad75c786f292d3a8ada8df519cb451c1c2828
Reviewed-on: https://chromium-review.googlesource.com/538613
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482589}
As we're adding more and more code outside of stc/ios/{web,chrome},
add a presubmit check enforcing "clang-format" for all of src/ios/
instead of limiting it to select sub-directories of src/ios/.
BUG=None
Review-Url: https://codereview.chromium.org/2665383002
Cr-Commit-Position: refs/heads/master@{#447541}
