0
Commit Graph

4 Commits

Author SHA1 Message Date
Victor Costan
e56cc68b9c sql: Switch from custom macro to COMPONENT_EXPORT.
TBR: jsbell
Change-Id: I5b998afa31810577e0bfd9d4d29ef9d462bce5b7
Reviewed-on: https://chromium-review.googlesource.com/c/1390332
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618989}
2018-12-27 01:53:46 +00:00
afakhry
7c9abe71bc Offer user to send feedback from profile error dialog
This CL makes the following:
- Improves the wording of the profile error dialog so as not to confuse users
- Adds a checkbox to offer the user to send a feedback report.
- Prepopulates the feedback description to ask the user what happened, and to
  add more debugging info (currently the name of the corrupted file).
- File the profile-error feedback reports under a category with name
  "FEEDBACK_PROFILE_ERROR"

Screenshots:
- Profile error dialog: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_La0tBU2RWTEdXQ28/view?usp=sharing
- Prepopulated feedback app - 1: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LZ19obE1Xa0hNSEE/view?usp=sharing
- Prepopulated feedback app - 2: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LZFc4WjdxcjFwN28/view?usp=sharing

BUG=455749

Review-Url: https://codereview.chromium.org/2107493002
Cr-Commit-Position: refs/heads/master@{#410094}
2016-08-05 17:35:28 +00:00
shess@chromium.org
7bb70e6421 Remove last client of sql::DiagnosticErrorDelegate.
In the first pass, there was a problem with histograms.  I do not
recall what the problem was, so removing things.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/15104003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201895 0039d316-1c4b-4281-b951-d872f2087c98
2013-05-23 21:45:53 +00:00
pkotwicz@chromium.org
0d04ede3f1 Move ErrorDelegate to its own file and add static utility functions to ErrorDelegate
BUG=151841
Test=None
R=shess, erikwright
TBR=cpu

Review URL: https://chromiumcodereview.appspot.com/11141012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162647 0039d316-1c4b-4281-b951-d872f2087c98
2012-10-18 04:31:53 +00:00