0
Commit Graph

8 Commits

Author SHA1 Message Date
Victor Costan
6370b7f013 test: Mark PlatformTest destructor as an override.
Change-Id: I4feba13a01190f3b8b9fba1911913c6902d49b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990511
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729341}
2020-01-08 15:18:30 +00:00
patricialor
df7b70bca5 MacViews/a11y: Typedef gfx::NativeViewAccessible to id for all of Mac & iOS.
Currently on Mac and iOS, gfx::NativeViewAccessible is 'typedef'ed to void*
or id depending on whether the file it's used in is an Objective C file or not
(i.e. if __OBJC__ is defined or not). Previously, when it was only ever used as
a return type on these platforms, this was fine. But in order to implement
AXPlatformNode::FromNativeViewAccessible() on Mac where
gfx::NativeViewAccessible is used as an method argument, this no longer works --
.cc and .mm files see different method signatures, and linking these together
fails (since the .mm file will declare an overload that doesn't exist).

To fix, typedef gfx::NativeViewAccessible to id.

BUG=610589

Review-Url: https://codereview.chromium.org/2739783002
Cr-Commit-Position: refs/heads/master@{#456594}
2017-03-14 02:51:27 +00:00
stkhapugin
b80a345285 Declare pool_ as id instead of NSAutoreleasePool.
File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2121893003
Cr-Commit-Position: refs/heads/master@{#413464}
2016-08-22 17:25:42 +00:00
lpromero@google.com
22d68da724 Change visibility of the destructor to public.
PlatformTest's destructor was set as protected, though the parent class
testing::Test declares it public.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11038058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161352 0039d316-1c4b-4281-b951-d872f2087c98
2012-10-11 16:08:07 +00:00
mark@chromium.org
c77043fc18 Move NSAutoreleasePool management into the PlatformTest constructor and
destructor.  The pool operations are moving from SetUp and TearDown, which are
scoped slightly too narrowly for our needs.  Using the constructor and
destructor ensures that the pools properly bracket tests.
Review URL: http://codereview.chromium.org/174171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23897 0039d316-1c4b-4281-b951-d872f2087c98
2009-08-20 22:37:59 +00:00
deanm@chromium.org
36dcefdc45 NO CODE CHANGE
Normalize end of file newlines in build/ media/ printing/ testing/ and tools/.  All files end in a single newline.

Review URL: http://codereview.chromium.org/43082


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11449 0039d316-1c4b-4281-b951-d872f2087c98
2009-03-11 15:17:55 +00:00
maruel@chromium.org
f0a51fb571 Fixes CRLF and trailing white spaces.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
2009-03-05 12:46:38 +00:00
jeremy@chromium.org
23887f04fb * Cleanup: move base/platform_test.h -> testing/
* Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild

Review URL: http://codereview.chromium.org/13052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
2008-12-02 19:20:15 +00:00