Alerting the error for use to use c++11 constructs |override| and |final|
instead of OVERRIDE and FINAL respctively
BUG=417463
Review URL: https://codereview.chromium.org/653883002
Cr-Commit-Position: refs/heads/master@{#299880}
Several values are always defined and the developer actually wants to
do an #if check, not #ifdef.
BUG=417804
Review URL: https://codereview.chromium.org/595213004
Cr-Commit-Position: refs/heads/master@{#297627}
The header include order checks were running on all
affected files, including third_party for example,
this causes issues when rolling harfbuzz-ng.
BUG=404105
NOTRY=true
Review URL: https://codereview.chromium.org/462323003
Cr-Commit-Position: refs/heads/master@{#289968}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98
Sometimes, changes to JSON/IDL files make them invalid. It's easier to check these at presubmit time than discovering they can't be parsed at runtime.
This just moves the check from chrome/common/extensions/api to top-level.
This presubmit check excludes files in test/data directories.
BUG=366395
Review URL: https://codereview.chromium.org/239283008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274432 0039d316-1c4b-4281-b951-d872f2087c98
This also fixes problems with generic trybots not being triggered
when other presubmit files which already support multiple masters
get in scope.
BUG=334892
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/197963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256698 0039d316-1c4b-4281-b951-d872f2087c98
Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file.
BUG=290401
Review URL: https://codereview.chromium.org/116443011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98
Currently as soon as we see an uncheckable include (like ipc/*macros.h or
windows.h) we stop checking the file. Instead we should just skip that line
and continue checking.
Review URL: https://codereview.chromium.org/105633012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98
Without this change, xxx_unittest_win.cc would cause an erroneous presubmit error by including xxx_win.h as its first 'special' include.
BUG=None
Review URL: https://codereview.chromium.org/26486003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227823 0039d316-1c4b-4281-b951-d872f2087c98
These files need to be included out-of-order.
BUG=NONE
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/24177004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224367 0039d316-1c4b-4281-b951-d872f2087c98
Sometimes the trailing slash doesn't exist on the DEPS on grit, but we
were expecting it.
BUG=None
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/20770002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213989 0039d316-1c4b-4281-b951-d872f2087c98
This enables the commit queue to commit patches where the #include order is
"wrong" according to the check.
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/11496010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172084 0039d316-1c4b-4281-b951-d872f2087c98
This is a follow-up to me having to remove some of these by hand in r171143.
R=maruel@chromium.org
NOTRY=true
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11448014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171287 0039d316-1c4b-4281-b951-d872f2087c98
E.g.,
need to be in this order, since the latter uses definitions from the former.
BUG=NONE
Review URL: https://codereview.chromium.org/11418128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169290 0039d316-1c4b-4281-b951-d872f2087c98
The previous version didn't take into account that source files
can have a platform specific suffix.
BUG=NONE
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11413012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167996 0039d316-1c4b-4281-b951-d872f2087c98
