These folks have left Chrome or Google. Removing them to make it clear
that these directories need more OWNERS (dgn@, aberent@,
shenghuazhang@, sgurun@).
Add mlamouri@ to replace removed //third_party/android_media OWNERS.
Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4cf85a5dace5bdd4929d12617e5e12f11a58ca11
Reviewed-on: https://chromium-review.googlesource.com/1160771
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582562}
Bug 850000 added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /components
Spec: https://drafts.csswg.org/css-logical/#box
BUG=862141
Change-Id: Id71b93522241bd4db07133ec98bdc5a32b0a2e4a
Reviewed-on: https://chromium-review.googlesource.com/1150231
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#578264}
The calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.
Removing the calls allows removal of definitions done in test code
under content/test/gpu.
This CL focuses on cleaning up javascript references to
domAutomationController.setAutomationId. A follow-up CL will remove
this method from content/renderer/dom_automation_controller.h/.cc
Bug: 662543
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d3664672eaf8ed4d90a67e27d3c817f52dba8c2
Reviewed-on: https://chromium-review.googlesource.com/626696
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Pam Greene (Please send IM for reviews) <pam@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497151}
In all other cases, the details section does not contain actionable information.
Also, update the block message per UI review.
Bug: 736043
Change-Id: Ib6cae1ac04f4af97398ea0bf6c5f16676d79f382
Reviewed-on: https://chromium-review.googlesource.com/566959
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485667}
Update the deprecation message to remove non-actionable information for
the user, and move it out of the Details section.
Bug: 736043
Change-Id: I1f87c2faeca77703ee14c9f68816e728d8bae5e8
Reviewed-on: https://chromium-review.googlesource.com/556038
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483503}
Identifiers in Blink now largely follow the standard Chrome style
conventions, with several additional rules:
- web-exposed methods remain namedLikeThis() for consistency with
Javascript bindings.
- method names are never named_in_hacker_case()
- enumerator names are kNamedLikeThis.
This commit was generated by the following process.
1. Running //tools/clang/rewrite_to_chrome_style across the codebase.
2. Apply manual fixes.
3. git cl format
BUG=578344
R=lukasza@chromium.orgTBR=darin@chromium.org
Change-Id: Ide5d397d3c6a5d973fd0a6f81dccf82561d4bb71
Reviewed-on: https://chromium-review.googlesource.com/472192
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463139}
The gn and (many!) DEPS changes were lovingly hand-crafted.
The cc changes were done with bash invocations similar to the others
mentioned in the bug.
BUG=401588
Review-Url: https://codereview.chromium.org/2712513004
Cr-Commit-Position: refs/heads/master@{#452591}
Webview gets its URL filtering information from Chrome; however
it can't do so until Chrome has signed in, which in a child account
environment it does automatically on first run.
This CL checks for the case where Chrome has never been run,
and attempts to force sign in Chrome. If it fails (as far as
I know this should only happen if GMSCore is out of date) it
generates a message asking the user to start Chrome.
BUG=686732
Review-Url: https://codereview.chromium.org/2695113002
Cr-Commit-Position: refs/heads/master@{#450961}
This patch typedefs a number of skia data structures used in painting in
Blink and ui.
SkCanvas -> PaintCanvas
SkSurface -> PaintSurface
SkPicture -> PaintRecord
SkPictureRecorder -> PaintRecorder
SkPaint -> PaintFlags
SkShader -> PaintShader
These are all typedef'd to Skia types in cc/paint headers. They are
forwarded to the Blink namespace via platform/graphics/paint headers.
This first step in this patch is to rename uses of these classes
everywhere and then further patches will replace their implementation.
This adds a cc:paint gn component that only depends on Skia that can
then be depended on by ui and Blink platform without depending on the
rest of cc. This allows ui and Blink platform to continue to
encapsulate its use of cc while still being able to use paint data
structures throughout the entire pipeline.
This patch will be followed up with another patch to change all of
the identifiers that refer to old names.
See: https://docs.google.com/document/d/135-2dYsilJCPucW7edvuh-eGOmmGvazX4QuF7vIboBY/edit?disco=AAAAA5r88Q0
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2640983002
Cr-Commit-Position: refs/heads/master@{#447861}
This CL:
- Lets WebView ask a content provider (the name of which is set by a
WebView policy) whether a URL should be accessible.
- Implements an error page when a URL is not accessible, that, if it
is supported by the content provider, lets the user request access
- Makes some fixes to the supervised user content provider so that
this works with WebView.
BUG=604330
Review-Url: https://codereview.chromium.org/1890203002
Cr-Commit-Position: refs/heads/master@{#412791}
This is a refactoring to allow WebView to use the supervised user error
page.
BUG=594973
Review URL: https://codereview.chromium.org/1808653003
Cr-Commit-Position: refs/heads/master@{#382015}
