0
Commit Graph

20 Commits

Author SHA1 Message Date
Aaron Gable
7e33ef11a8 Remove agable from src OWNERS files
Change-Id: I95178dde14672080b562d1cccbb978509adddd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216569
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780374}
2020-06-19 18:25:17 +00:00
Daniel Cheng
23eb572923 Clean up a stale line in codereview.settings.
//webkit/api hasn't existed in a long time.

Change-Id: I936e5883f5f29e3dad64eb2e982888077ded262b
Reviewed-on: https://chromium-review.googlesource.com/669710
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502650}
2017-09-18 19:47:31 +00:00
Aaron Gable
2434914307 Start running post-upload hooks again
This was a typo, I accidentally removed the RUN_POST_UPLOAD_HOOKS
line (which still has a function) when I meant to remove the
TRY_ON_UPLOAD line (which doesn't). I blame them both containing
the word 'UPLOAD'.

Bug: 746079
Change-Id: I007ed90443680a7f3741367b368c55e5056e3252
Reviewed-on: https://chromium-review.googlesource.com/576530
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487875}
2017-07-19 15:56:02 +00:00
Aaron Gable
ccfbae89e4 Make Gerrit the default codereview system
Bug: 685321
Change-Id: I75d180634a4f41faa15135bbfeb56c5cd25f701a
Reviewed-on: https://chromium-review.googlesource.com/541675
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484666}
2017-07-06 18:04:08 +00:00
Aaron Gable
64f27358c8 Add agable to OWNERS and WATCHLIST for codereview.settings
Change-Id: Idcbe4c0fb459ba49897ac6b7c34650ec0f1d7581
Reviewed-on: https://chromium-review.googlesource.com/463627
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460837}
2017-03-30 18:51:21 +00:00
prasadv
3d3ed829fb Update CL description by adding CQ_EXTRA_TRYBOTS for Telemetry changes.
This CL adds a post upload hook to add extra try bots list to the CL description in order to run
Telemetry benchmarks on Perf trybots in addtion to CQ trybots if the CL
contains any changes to Telemetry benchmarks.

BUG=462581

Review URL: https://codereview.chromium.org/1060763002

Cr-Commit-Position: refs/heads/master@{#327150}
2015-04-27 21:54:15 +00:00
Robert Iannucci
42a2ff8eb8 Switch codereview.settings to git.
R=vadimsh@chromium.org
BUG=263848

Review URL: https://codereview.chromium.org/505433003

Cr-Commit-Position: refs/heads/master@{#291562}
2014-08-23 00:46:45 +00:00
sheyang@chromium.org
0d170df0cf Replace unused CANONICAL_URL with PROJECT
NOTRY=true
TBR=darin@chromium.org
BUG=374398

Review URL: https://codereview.chromium.org/291173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274920 0039d316-1c4b-4281-b951-d872f2087c98
2014-06-04 21:54:19 +00:00
sheyang@chromium.org
40c2a1b882 add CANONICAL_URL in codereview.settings
BUG=

Review URL: https://codereview.chromium.org/283813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270741 0039d316-1c4b-4281-b951-d872f2087c98
2014-05-15 18:21:47 +00:00
jamescook@chromium.org
9a5bb05bd1 Revert accidental dartium code push
This reverts r264517 to r264538 from terry@google.com

BUG=none
TEST=none
NOTRY=true
NOTREECHECKS=true
TBR=terry@google.com

Review URL: https://codereview.chromium.org/239993009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264545 0039d316-1c4b-4281-b951-d872f2087c98
2014-04-17 16:50:56 +00:00
terry@google.com
412caade87 merged 1908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264526 0039d316-1c4b-4281-b951-d872f2087c98
2014-04-17 15:55:16 +00:00
ilevy@chromium.org
3d506f4f7c Upgrade chromium viewvc link to https
Automatic https upgrade was rolled back in r169815.
Use https for chromium repo src links.

TBR=maruel
NOTRY=True
BUG=107838

Review URL: https://chromiumcodereview.appspot.com/11411212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169853 0039d316-1c4b-4281-b951-d872f2087c98
2012-11-28 05:22:18 +00:00
thakis@chromium.org
b24d946027 Remove TRYSERVER_HTTP_ stuff.
The http method is broken, and having this in here means `git try` takes 60 seconds just to discover that it should retry using svn.

Removing this == developer_productivity++

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6312005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71606 0039d316-1c4b-4281-b951-d872f2087c98
2011-01-17 21:24:41 +00:00
maruel@chromium.org
971888bc3c Update codereview.settings GITCL_* urls for new viewvc server url format.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3822009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62919 0039d316-1c4b-4281-b951-d872f2087c98
2010-10-18 13:31:18 +00:00
maruel@chromium.org
6aa2cf2f55 Add back http access to the try server.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48640 0039d316-1c4b-4281-b951-d872f2087c98
2010-06-01 17:49:41 +00:00
maruel@chromium.org
79882c35f9 Remove http access.
TBR=jam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1762013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45744 0039d316-1c4b-4281-b951-d872f2087c98
2010-04-27 22:34:32 +00:00
jam@chromium.org
f060a159b2 Switch from chromium-reviews@googlegroups.com to chromium-reviews@chromium.org.
Existing issues will still use the old list.
Review URL: http://codereview.chromium.org/551111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36833 0039d316-1c4b-4281-b951-d872f2087c98
2010-01-22 02:10:26 +00:00
dpranke@google.com
ed43c9bdad Set LINT_IGNORE_REGEX to not try to lint files using webkit coding standards
(everything in webkit/api)

See  http://codereview.chromium.org/257054/show for the change to gcl that is also needed.

  R=maruel@chromium.org
  BUG=none
  TEST=none

Review URL: http://codereview.chromium.org/260014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30501 0039d316-1c4b-4281-b951-d872f2087c98
2009-10-29 20:11:39 +00:00
chase@chromium.org
76d7c661ed Configure git-cl hooks based on git-cl-upload-hook.
BUG=5339
TEST=git cl config downloads and installs configured
hooks

Review URL: http://codereview.chromium.org/257070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28748 0039d316-1c4b-4281-b951-d872f2087c98
2009-10-12 22:15:36 +00:00
nsylvain@chromium.org
6dd84d70e8 Make sure changes outside the src/ dir don't trigger a trybot run by default on Upload
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24659 0039d316-1c4b-4281-b951-d872f2087c98
2009-08-27 20:58:51 +00:00