When the --log-best-effort-tasks switch is specified, information about
all tasks posted with BEST_EFFORT priority is logged. This is useful to
diagnose issues with preventing BEST_EFFORT tasks from running during
startup (and eventually during page load).
Bug: 887407
Change-Id: I366a78485c1588741519c7254f8e1ab57d1df140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660635
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670886}
* Add support for test suite-specific sandbox policy.
* Add fuchsia.web.Debug API to the ContextProvider service.
* Add tests for that API by using the Fuchsia Hub.
Bug: 955589
Change-Id: Icc5d9a91c30b55e71f6f104f8b7ea984b811a1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578597
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665620}
Remove some usage of deprecated callback types in ui/ozone/*. Where
possible convert to the corresponding once type, otherwise replace with
the repeating type.
Also update PRESUBMIT so that deprecated callback types are banned in
ui/ozone/*.
Bug: 714018
Change-Id: Ida5c8c028435a220344981d09e508f3e0dd711b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637399
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665558}
I have gone through the code with the following script, delving into
sub-directories where it seemed appropriate, to build a list of places
that still use base::Bind/Callback/Closure and need to be migrated. The
PRESUBMIT check will ignore those places to avoid warning fatigue and
people using BindRepeating randomly and incorrectly.
This allows the check to continue to be run against places that have
been converted and are now clean (such as cc, components/viz, ui/views)
to prevent the addition of new uses there.
It also gives a convenient burn-down list of places to fix, and they
can be removed as they are done so.
Uses .join() because just giving the whole list makes the presubmit
check 7% slower against one c++ file.
R=ajwong@chromium.org, dcheng@chromium.org
Bug: 947414
Change-Id: I7cda063a0e02c6b4a18e8229093af6d48dfe7fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622869
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661906}
It turns out that converting from base::Bind() ->
base::Bind{Once,Repeating} is often much harder than expected. It's not
mechanical and in particular going to BindOnce() -- which is hte
preferred binder -- may have a viral effect on an API.
Removing the warning as conversion is not going to be aided by nagging.
Bug: 947414, 714018
Change-Id: I1f82a480c420fe0c5cc61f3bf7a9245fa3ac7bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620611
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661566}
ABSL is trying to be -Wundef clean and sending a patch for these
macros seems overkill. They are used inside a __APPLE__ block with
this pattern:
#if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
#endif
Bug: None
Change-Id: I863d099dcc3a2588388afab24a61be89884b392b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612913
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660995}
This change adds a check preventing new usages of mojo::ConvertTo since
TypeConverter is deprecated. The check excludes /third_party/blink and
content/renderer paths for now.
Bug: 621383
Change-Id: I63b36171447863cdd9ee0c42f973c2a8480ee4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549453
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#660438}
We added a check that no one is trying to add a file > 20MB
to the repo in r655002. That check depended on stat'ing files
using the path relative to the repo root.
However, it turns out that changes in a nested repo can also
cause the presubmit checks in this repo to run, and the local
path stat doesn't work in that case (it uses the wrong git repo
root).
This CL switches the check to using full paths, which doesn't
have that problem.
Bug: 958106
Change-Id: I929473efba38d0a17eb37025abb8030cfb9fafb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590446
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#655421}
To avoid bloating the chromium/src git repo with large binary
files, this adds a check that files are not too large and suggests
to use cloud storage otherwise.
Now without trying to check the size of deleted files and with the
limit increased to 20MB.
R=dpranke@chromium.org
Bug: 956017
Change-Id: Ieeb2e1a37017a375f9da7a48c7713077c4929ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581971
Commit-Queue: Daniel Bratell <bratell@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#655002}
This change implements StringFromGUID2 natively in Chromium in order to
avoid calling into ole32.dll. This is necessary to support the effort to
delayload user32.dll and gdi32.dll because StringFromGUID2 has some
callers in the renderer process and delayloading ole32.dll for this
method call will cause the process to crash.
Bug: 948829
Change-Id: I00a2d5735984268813ecccc43aa3cb464d21c62c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575869
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654978}
Simplifies generating factory files that can be used for targets like
factory:public_java in feature code.
This CL converts keyboard_accessory/factory targets as an example.
Bug: 846440
Change-Id: Ib87892132ea5f8db0406df2d7136d1e3714cba6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584406
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654922}
After removing SHFileOperation from Chromium, to avoid re-introducing
callers this change adds this Windows API to presubmit's banned APIs
list.
Bug: 945501
Change-Id: I637142a27eb936db64b8ae7698c8f90f48e51938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586736
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ben Lewis <ben.lewis@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#654917}
This reverts commit 343c786aa3.
Reason for revert: Presubmit failures on CLs with deleted files.
crbug.com/956247
Original change's description:
> Block files >10MB in a presubmit check
>
> To avoid bloating the chromium/src git repo with large binary
> files, this adds a check that files are not too large and suggests
> to use cloud storage otherwise.
>
> Bug: 956017
> Change-Id: Idf6e816a50030551fc6003b0f83b2071f685c9b5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581803
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Daniel Bratell <bratell@opera.com>
> Cr-Commit-Position: refs/heads/master@{#653733}
TBR=dpranke@chromium.org,bratell@opera.com
Change-Id: I219913f0c95f8ff43499ef700ce4b939d6301bf0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 956017, 956247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581826
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653762}
To avoid bloating the chromium/src git repo with large binary
files, this adds a check that files are not too large and suggests
to use cloud storage otherwise.
Bug: 956017
Change-Id: Idf6e816a50030551fc6003b0f83b2071f685c9b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581803
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#653733}
An #include "foo.cc" will often compile, until it causes linking
problems later, for instance in jumbo builds. The error messages are
then not good at pointing out what is wrong.
Change-Id: Ic155dc5542e22b54d13c213230d6df4977263642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566344
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653105}
Since userdebug and eng builds are debuggable build of Android.
BuildInfo.isDebugAndroid() is preferred over `Build.TYPE.equals()` or
''.equals(Build.TYPE). The CL adds a presubmit check for that.
Bug: 939924
Change-Id: Id2794374f2185c1f0f50abf9424a87b07467567e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564363
Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651269}
This CL imports the code for the Internet Explorer Browser Helper
Object (BHO) used by Legacy Browser Support. The new rule is
purposefully excluded from mini_installer.exe for now.
The code is imported from //googleclient/chrome/chrome_browserswitcher
The following changes were made to the original codebase:
- Add BUILD.gn rules to build the BHO DLL
- Remove unneeded code (e.g. XML parsing, InvokeAlternativeBrowser...)
- Flatten ie_bho/ and core/ folders
- Replace '#pragma once' with '#ifndef' guards, run 'git cl format'
- Update copyright comment in each file
- Add pre-generated header files from IDL
Bug: 950039
Change-Id: Ic4d05b360f6e93ff28afc2e37722e26325058fd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551704
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649113}
This is the first step in eliminating mojo::DataPipe. Marking it as
deprecated with a comment and adding a DLOG (that only logs once per
process launch) will hopefully stop it from being used in new code.
Previous change was reverted due to log spam.
Bug: 944990
Change-Id: I492f7ac2038db31ce4af6a31a0b1a80570c46aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544798
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#648821}
To avoid banned functions and features in C++ from being used
accidentally, add more presubmit checks.
This tests most of what is currently banned from C++11/14 except
for threads and thread_local. Those were excluded because
of a difficulty in expressing when they were ok and when not
and because of too many false positives.
This change follows a discussion on the cxx mailing list about how
to avoid that people use banned functions from pure ignorance.
Change-Id: I585c05efd72e62d2148be90a3088aa99c6279646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539040
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#644978}
std::to_string is one of the banned functions but people are
not aware of that so a presubmit warning is needed.
It is only a warning for std::string since it's already used
and I don't want to trigger presubmit errors when someone
changes something on the same line as an std::to_string().
std::shared_ptr has been banned for a while (use scoped_refptr)
but it was brought to my attention because of std::weak_ptr from
C++11 which builds on std::shared_ptr.
These updates comes as most of the rest of C++11 is removed from
the ban list and only some very few functions/types remain banned. See:
https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFDHbjTfGH0wktnDryONBEEyG2O9o-CCMVWuTYFokjrSUw%40mail.gmail.com
Change-Id: I9fb1450ee76046cb842cd5a64a55d2cc977492b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535872
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#644250}
This CL switches things so that instead of fetching GN
binaries from a Google Cloud Storage bucket, we just fetch them
directly from CIPD, which is generally faster and a bit safer.
This CL does *not* change the current version of GN we're using;
it still pulls r1496 (0790d304).
"Rolling" GN in the future will simply involve updating the revisions
in //DEPS and //buildtools/DEPS.
Bug: 855791
Change-Id: Id005250f680618206cbecaba4080933c40b23833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519726
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641353}
Due to limitations in how gclient works, we currently need to
duplicate entries in //DEPS and //buildtools/DEPS, and it is
possible for them to not be kept in sync. We don't want that.
This CL adds a presubmit check so that if you modify the relevant
lines in one file you are required to modify them in another.
If we ever fix the linked bug so that we don't need to duplicate
the content, we can remove these presubmit checks.
This CL also gets rid of deps_revisions.gni in //buildtools,
and switches to passing the libcxx_revision value from gclient
to GN via gclient_gn_args.
In order for this to work correctly, anyone using both
//buildtools and //build in GN will need to *also* export the
variable from their DEPS files.
Bug: 941824, 930836
Change-Id: I438c9966c497737cd4984a14cdb0c8993ffcad9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522466
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641021}
The original setup failed on bots with:
dependency_manager.exceptions.EmptyConfigError: \
Empty config at [...]/build/android/devil_chromium.json
Add this file to the isolate as well and reland.
The reason I listed in the original revert (crrev.com/637340) was probably
incorrect. The problem was that this change became more visible on the bots by
printing a stack trace - this is being mitigated by [1] and is orthogonal to
what is being fixed here.
[1] crashpad_stackwalker: no error when crash not found
http://crrev.com/637655
Original change's description:
> Add stacktrace scripts to telemetry isolate
>
> Add the crashpad stack walking scripts to the isolate that runs
> performance tests with Telemetry.
>
> There are multiple places where the python scripts can be inserted as
> 'data' dependencies. In the end choosing the place closest to where the
> native third_party/breakpad tools are pulled in.
>
> I checked that after the change the isolate 'performance_test_suite'
> (defined in testing/buildbot/gn_isolate_map.pyl) actually contains the
> new files. I used this command:
>
> shell> python tools/mb/mb.py isolate out/Release performance_test_suite
>
> Bug: 935979
> Reviewed-on: https://chromium-review.googlesource.com/c/1497076
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Egor Pasko <pasko@chromium.org>
Bug: 935979
Change-Id: I64867c51a3201b98647487f9c690c34ffe1ee039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499675
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640748}
This code is used to run WPT tests in the public upstream repository,
and is being integrated into Chromium CI.
This change begins the automatic import of this code, as well as adding
several lint and presubmit check exclusions.
Bug: 937369
Change-Id: Ie9409e671b0c06a10bb509a53946687c0b7a3f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495372
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637373}
