Original Review: https://codereview.chromium.org/113363004/
Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
the given path. This makes it difficult to create POSIX compatible API on
top of PPAPI.
This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
That makes a new directory according to the given PP_MakeDirectoryFlags
values. The flags provide exclusive operation option. If exclusive flag
is specified and a directory exists on the given path, the function fails
and returns PP_ERROR_FILEEXISTS.
BUG=314879
TEST=browser_tests
TBR=dmichael@chromium.org,yzshen@chromium.org,tsepez@chromium.org
Review URL: https://codereview.chromium.org/131403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244148 0039d316-1c4b-4281-b951-d872f2087c98
This breaks examples of NaCl SDK.
http://build.chromium.org/p/client.nacl.sdk/builders/mac-sdk-multi/builds/6796
> PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation
>
> Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
> the given path. This makes it difficult to create POSIX compatible API on
> top of PPAPI.
>
> This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
> That makes a new directory according to the given PP_MakeDirectoryFlags
> values. The flags provide exclusive operation option. If exclusive flag
> is specified and a directory exists on the given path, the function fails
> and returns PP_ERROR_FILEEXISTS.
>
>
> BUG=314879
> TEST=browser_tests
>
> Review URL: https://codereview.chromium.org/113363004TBR=nhiroki@chromium.org
Review URL: https://codereview.chromium.org/131473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243842 0039d316-1c4b-4281-b951-d872f2087c98
Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
the given path. This makes it difficult to create POSIX compatible API on
top of PPAPI.
This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
That makes a new directory according to the given PP_MakeDirectoryFlags
values. The flags provide exclusive operation option. If exclusive flag
is specified and a directory exists on the given path, the function fails
and returns PP_ERROR_FILEEXISTS.
BUG=314879
TEST=browser_tests
Review URL: https://codereview.chromium.org/113363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243802 0039d316-1c4b-4281-b951-d872f2087c98
This change brings Query() support back to FileRef for in-process and out-of-process plugins.
I've added testing for a file that exists and one that doesn't.
BUG=170721
Review URL: https://chromiumcodereview.appspot.com/12817009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191805 0039d316-1c4b-4281-b951-d872f2087c98
always be invoked asynchronously on success or error or skipped if the
operation can complete synchronously without blocking. Keep the default
behavior as-is until clients update their code. Bump revisions of all
interfaces that take callbacks as args. Update browser interface function
implementations and C++ layer to force callbacks if sync option is not set.
Change ppapi/tests to run tests involving callbacks with both flag options.
BUG=79376
TEST=ppapi_tests + bots
Review URL: http://codereview.chromium.org/6899055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91205 0039d316-1c4b-4281-b951-d872f2087c98
I moved to write access repository.
Review URL: http://codereview.chromium.org/7261004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90629 0039d316-1c4b-4281-b951-d872f2087c98
