The documented functionality was removed quite some time ago. Different
functionality has been re-introduced to support IP Protection, but this
is not available outside of that context.
This CL just brings the documentation into line with the implementation.
Change-Id: Icf0ba30959ad7ec2142e980dfc4b65f8fdff4148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5749209
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334947}
It was not clear to me until I looked at some example code whether a
caller could assume their callback was invoked if the function returned
a non-negative result.
Change-Id: I3a8a1d00663d63370d4a8e39ce85fec00ed72866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580927
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153190}
The Web Networking team is migrating its bug triage rotation from
Rotations to OnCall. We created a new document with instructions
to manage the rotation and a new team calendar synchronized with the
schedule. This change updates the links in this document.
Also, it's removing links to outdated bug dashboards.
Change-Id: I699fc9250a1dc51951ad8823911391e2a3ce6442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4191012
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Javier Garcia Visiedo <visiedo@google.com>
Cr-Commit-Position: refs/heads/main@{#1097190}
Remove `Internals>Network>Library` as this is part of the Cronet
rotation.
Fixing a typo in the markdown file where a new line was breaking a
hyperlink.
Change-Id: I74873867b37105f67cf3ca44da76826ff9b84132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4041764
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1074007}
Add `Internals>Network>ReportingAndNEL` and
`Internals>Network>Cache>Simple` to the bug triage query to update
according to the current networking team ownership.
Adding minor changes as well to the internal untriaged dashboards
with more details for the team to track the trend of untriaged bugs
Bug: none
Change-Id: I0e87dfbceb5d13caac31e4587d39b2dafdbe4599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853060
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Javier Garcia Visiedo <visiedo@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038653}
This CL removes the two base::FeatureParams named "DisabledProviders"
that controlled DoH providers' eligibility for autoupgrade and
visibility in the "Secure DNS" settings.
Removed feature params:
- kDnsOverHttpsUpgradeDisabledProvidersParam
- kDnsOverHttpsDisabledProvidersParam
Now, a given provider's eligibility for autoupgrade and settings
visibility are both controlled by the same base::Feature attached to a
DohProviderEntry. As it turns out, the old Finch experiment config was
not capable of disambiguating the two feature params because they had
the same name, so they were being controlled in lockstep anyway.
This CL aligns new versions of Chrome with the behavior currently
defined by the old config:
- Launched providers are enabled by default.
- Cox is disabled by default.
- Quad9Secure is disabled by default.
In the near future, we will enable Cox for the first time and restart
the gradual rollout of Quad9Secure. Until we turn down the old Finch
config in a few milestones (DnsOverHttps.gcl), we will need to mirror
these experiment changes between the old and new Finch new configs.
Bug: 1300296
Change-Id: I5e241842ac84d6ee7f54e55b0eb3aedbab351caa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500973
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979933}
Still more to consider (should FTP still be considered a web safe
scheme? No idea how the protocol handler stuff plugs in, but I
suspect not)
Bug: 333943
Change-Id: Ib109b75df275990d2675f306f322b2b129528621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3097966
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915400}
This change looks enormous but consists of only a few steps:
* Open all files containing the string "histograms_xml",
do a global case-sensitive search-and-replace this with "metadata",
then revert the changes in tools/metrics/BUILD.gn
* cd tools/metrics/histograms && git mv histograms_xml metadata
Bug: 1133549
Change-Id: I60a2047387acae3cb3fb64954ee25a76cc1160a9
No-Try: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3049316
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#906694}
Python2 has been considered obsolete since 2020-01-01. Some Linux
distributions are increasingly moving away from installing a
Python2 binary in `/usr/bin/python`, which means that any
Unix shebang lines that refer to it will stop working.
This CL changes (almost) all of the shebang lines found in
chromium/src to use `#!/usr/bin/env python` instead, which is
more portable (it allows you to have your own Python as long as
it is simply somewhere in $PATH). There are a few cases where
I did not update the changes because they were in third_party
code.
The actual command used to generate this CL was:
git grep -l '^#!\s*/usr/bin/python$' -- \*.py | egrep -v 'external/wpt|third_party/(abseil-cpp|android_platform|libxml|closure_compiler|google_input_tools|libxml|mako|opus|protobuf|wpt_tools|zxcvbn-cpp)' | xargs perl -pi -e 's-^#!/usr/bin/python-#!/usr/bin/env python-'
Bug: 1191100
Change-Id: Ifca134a1e24d56b25114c6f70a173d71fec8e6d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780719
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Owners-Override: Kentaro Hara <haraken@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866002}
This makes it easier to identify those that need to be pinged.
Also remove Internals>Network>Filters and Internals>Network>SDCH
labels, as they no longer exist.
Bug: None
Change-Id: Ia266b34fabd4ae6d89a9ee63ffc90e5b2f278cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2722914
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858482}
Added a new `use_extra_logging` field to the DoH providers list. Use
the new flag to only record the "SecureNotValidated" query metrics for
queries to servers identifiable as a provider with the flag set to true.
And now that the usage of these metrics is greatly reduced to be more
reasonable, extend the soon-expiring metrics another ~6 months.
Fixed: 1160857
Change-Id: Ic1ad6f4cd5bbfe36b5652de2b4fb97b20bdb461c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2659084
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848828}
Previously, our query would select all of Internals>Network>* and then
subtract bugs with one of the out-of-scope components. The problem is
this filters out bugs that contain both an in-scope and an out-of-scope
bug component.
The new queries use an additive approach that names each of the
in-scope components directly.
NOTRY=true
Change-Id: I8526c49a38d45d41caa4d53b3c6103d281e7f4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367983
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800644}
Documents the implementation and use of host resolution.
Remove net/docs/host-resolver.md as it is old, dated, and largely
replaced by this newer documentation.
Change-Id: Ia440e7593446a1b7af5646c1fd5fd630eee4073d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597224
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791411}
