chromium/src
0
Fork 0
Code Activity
1,126,163 Commits 3 Branches 23,233 Tags
7226a9f40ef895696a6ffb1c10770806f94743f4
Commit Graph

5 Commits

Author SHA1 Message Date
Joshua Hood
3fade1f647 Reland "[CodeHealth] Migrate remainder of testing/ to Python3 compatible 
syntax"

This is a reland of commit 8defc6c6da

Uses `sys.path.append(...)` to import the `common` module in
testing/scripts/run_variations_smoke_tests.py (as is done elsewhere in
the original CL) and resolve errors thrown for attempting a relative
import with no known parent package.

Original change's description:
>and Pylint2.7, and fix resulting errors.
>
>Bug: 1262363
>Change-Id: I09628427dd4caf9d873f3b489b897054430f8567
>Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557490
>Reviewed-by: Ben Pastene <bpastene@chromium.org>
>Commit-Queue: Joshua Hood <jdh@chromium.org>
>Cr-Commit-Position: refs/heads/main@{#996200}

Bug: 1262363
Change-Id: I60fe062f62962d0b3dc4e93d9e29626ed181f688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3610783
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Joshua Hood <jdh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999432}
 2022-05-04 16:00:42 +00:00
Sebastien Lalancette
53ef7d3a9b Revert "[CodeHealth] Migrate remainder of testing/ to Python3 compatible syntax" 
This reverts commit 8defc6c6da.

Reason for revert: Makes win-chrome fail:
https://ci.chromium.org/p/chrome/builders/try/win-chrome/4538

Original change's description:
> [CodeHealth] Migrate remainder of testing/ to Python3 compatible syntax
>
> and Pylint2.7, and fix resulting errors.
>
> Bug: 1262363
> Change-Id: I09628427dd4caf9d873f3b489b897054430f8567
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557490
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Joshua Hood <jdh@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#996200}

Bug: 1262363
Change-Id: I74384a8cbd77e0db5adbbd5815d54e836472b756
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607233
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996362}
 2022-04-26 20:53:45 +00:00
Joshua Hood
8defc6c6da [CodeHealth] Migrate remainder of testing/ to Python3 compatible syntax 
and Pylint2.7, and fix resulting errors.

Bug: 1262363
Change-Id: I09628427dd4caf9d873f3b489b897054430f8567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557490
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Joshua Hood <jdh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996200}
 2022-04-26 15:35:06 +00:00
Chris McDonald
c3e0f26bef Make test_env compatible with python 2 & 3 
Use the vendored copy of the `six` library to make this code work across
Python versions.

Bug: 942720
Change-Id: I4bdb1032ed8e89e733b929eb13ada54efeb3b019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229335
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774934}
 2020-06-04 02:15:14 +00:00
Caleb Rouleau
6844df15de [testing] Fix signal handling on Windows. 
See https://bugs.chromium.org/p/chromium/issues/detail?id=733612#c6
for details.

Also add tests both for windows and non-windows.

Bug: 733612
Change-Id: Id656635a5fc79ea8f805658873599b526e764406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796572
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695429}
 2019-09-11 01:11:59 +00:00