0
Commit Graph

26177 Commits

Author SHA1 Message Date
ppi
cd56adef2d Delete battery_status_message_filter.h.
He's dead, Jim.

BUG=

Review URL: https://codereview.chromium.org/746963002

Cr-Commit-Position: refs/heads/master@{#305235}
2014-11-21 17:41:24 +00:00
aae039a4d5 Fix WeakPtrFactory member ordering in content
Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/737353003

Cr-Commit-Position: refs/heads/master@{#305234}
2014-11-21 17:40:17 +00:00
0f0d0b39f8 Remove pure-virtual MediaStreamProvider::Unregister method and make overrides non-virtual.
The method is never called via virtual method dispatch, only directly on subclasses.

Review URL: https://codereview.chromium.org/701103002

Cr-Commit-Position: refs/heads/master@{#305222}
2014-11-21 16:20:19 +00:00
064170774d Roll WebRTC, Libjingle to revision 7728.
R=kjellander@chromium.org
TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/746123002

Cr-Commit-Position: refs/heads/master@{#305219}
2014-11-21 15:20:09 +00:00
bfa0ec0ee9 cc: Small BeginFrameArgs cleanup.
* Rename BeginFrameArgs::CreateTyped to BeginFrameArgs::Create and remove
   other versions.
    * The other constructors where not used anywhere.
    * The non-typed version was accidentally being used to create a SYNCHRONOUS
      BeginFrameArgs.

 * Fixed testing methods to understand type information.

 * Create method for converting the type enum to string.

BUG=346230

Review URL: https://codereview.chromium.org/742683002

Cr-Commit-Position: refs/heads/master@{#305218}
2014-11-21 15:14:05 +00:00
0fede3fa66 Use the same task queue for immediate and delayed tasks
When a task is posted through the WebTestDelegate (used in
LayoutTests), it should go to the same task runner regardless of
whether it is a delayed task or not.

BUG=432129

Review URL: https://codereview.chromium.org/751563002

Cr-Commit-Position: refs/heads/master@{#305216}
2014-11-21 14:39:25 +00:00
0c5eab87cc Referrer Policy: Add new policies to URLRequest.
This patch introduces two new referrer policy at the network level in order
to support stripping detail from the referrer header when a redirect
transitions across origins. These policies support both the "reduce referer
granularity" command-line flag, as well as the yet-to-be-implemented
"OriginWhenCrossOrigin" referrer policy specified at [1].

[1]: http://www.w3.org/TR/referrer-policy/#referrer-policy-state-origin-when-cross-origin

BUG=431711

Review URL: https://codereview.chromium.org/714813003

Cr-Commit-Position: refs/heads/master@{#305211}
2014-11-21 14:19:21 +00:00
04cd96433f remove some calls to to-be-deprecated v8::Value::To* functions
R=jochen@chromium.org
TBR=kalman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/753523002

Cr-Commit-Position: refs/heads/master@{#305209}
2014-11-21 13:58:26 +00:00
ba71aa04f3 [content/common] Convert VLOGs to DVLOGs
BUG=101424

Review URL: https://codereview.chromium.org/727443002

Cr-Commit-Position: refs/heads/master@{#305198}
2014-11-21 11:03:30 +00:00
24ab5d3666 Add missing dependencies to the GN build.
The need for these dependencies was shaken out by the (local, so far) addition
of public_configs to //mojo/public targets that need to be propagated
throughout the build.

Review URL: https://codereview.chromium.org/742053002

Cr-Commit-Position: refs/heads/master@{#305194}
2014-11-21 10:12:32 +00:00
75c75366d0 Add missing dependencies to the GYP build.
Adds dependencies that local work on moving the location in which code
from the Mojo repo is pulled in to Chromium shook out.

Review URL: https://codereview.chromium.org/744943002

Cr-Commit-Position: refs/heads/master@{#305192}
2014-11-21 10:08:48 +00:00
b9f5521acd Create an AcceleratedWidgetMac
Split BrowserCompositorCALayerTreeMac into two parts. One part is the
ui::Compositor bits of the structure, and the other is the
AcceleratedWidgetMac which has the gfx::AcceleratedWidget bits of the
structure.

Update BrowserCompositorViewMac to explicitly hold these two parts, the
ui::Compositor and the AcceleratedWidgetMac, and rename it to
BrowserCompositorMac.

Make AcceleratedWidgetMacNSView provide the link to bind an
AcceleratedWidgetMac to draw the contents of an NSView. An
AcceleratedWidgetMac may be bound to multiple NSViews in sequence.

Update the recycling mechanism of BrowserCompositorMac to use this
binding mechanism.

Remove some of the few dependencies that AcceleratedWidgetMac would have
on content by making the callers for GotAcceleratedFrame specify a
callback for when the frame displays (in addition to the callback that
the client has, as the client may be far away from the caller).

The next steps after this are to move the AcceleratedWidgetMac to ui,
and then to typedef ui::AcceleratedWidgetMac* to gfx::AcceleratedWidget
for Mac.

BUG=424058

Review URL: https://codereview.chromium.org/745453002

Cr-Commit-Position: refs/heads/master@{#305188}
2014-11-21 09:33:14 +00:00
d4dc81df18 Introduce CdmContext interface.
CdmContext is what a media pipeline needs from a CDM to decrypt (and decode) an
encrypted stream.

BUG=401264

Review URL: https://codereview.chromium.org/748473002

Cr-Commit-Position: refs/heads/master@{#305181}
2014-11-21 06:30:48 +00:00
380390fc2b Enable webrtc and most of blink and content in the Mac GN build.
There are still a few linker errors from missing files. I'll try to
get those fixed in a follow-on build, but this adds several
thousand edges as-is.

R=brettw@chromium.org
BUG=431177

Review URL: https://codereview.chromium.org/746003002

Cr-Commit-Position: refs/heads/master@{#305179}
2014-11-21 06:09:44 +00:00
0fa51299fb [Android] Add a flag to disable the pull-to-refresh effect
Some people may not like pull-to-refresh. Some people may not like our
implementation of pull-to-reresh. Some people may not like refreshing
at all. Let's accomodate such users with a disabling override,
particularly now as we're experimenting with the initial version of the
effect.

The flag also allows for experiments gauging accidental activation and
other potentially negative side-effects.

Also remove the kEnableOverscrollNotifications flag; overscroll
notifications are now bundled with event acks, creating
minimal extra overhead for non-consuming platforms.

BUG=428429

Review URL: https://codereview.chromium.org/733293002

Cr-Commit-Position: refs/heads/master@{#305154}
2014-11-21 03:19:44 +00:00
07ece1bfe7 IDB: Make readonly transactions wait for earlier readwrite transactions
The spec recently tightened to more explicitly match the
behavior of non-chrome browsers:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25251

Blink layout tests are waiting over in
https://codereview.chromium.org/745553002/

BUG=432259

Review URL: https://codereview.chromium.org/742033002

Cr-Commit-Position: refs/heads/master@{#305152}
2014-11-21 03:11:22 +00:00
080f90fecf Fix accessibility of remaining input types on Android
This fixes the accessibility of the html select element and
html input elements with a type of date, time, and color.

BUG=378799

Review URL: https://codereview.chromium.org/739063002

Cr-Commit-Position: refs/heads/master@{#305145}
2014-11-21 01:57:45 +00:00
2d2f447ab6 Clean up for UIResourceLayer use in EffectLayer
Following up on https://codereview.chromium.org/664173002/,
we no longer need to call SetUIResourceId() when we add UIResourceLayer to another layer.

BUG=435376

Review URL: https://codereview.chromium.org/747683002

Cr-Commit-Position: refs/heads/master@{#305139}
2014-11-21 01:39:27 +00:00
5cd8444c9a Remove #include of compiler_specific.h from macros.h.
Include it directly in files which want it.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/733763003

Cr-Commit-Position: refs/heads/master@{#305137}
2014-11-21 01:38:17 +00:00
9325d7ca3d Allow URL requests for object/embed tags to be intercepted as streams.
BrowserPlugins make URL requests on behalf of object tags. Requests on behalf of
object tags should be treated in a similar way to requests in behalf of frames
in that they are allowed to be intercepted as a stream request, however unlike frames they should never be downloaded. This CL allows
these requests to be intercepted in that way.

BUG=416310
TBR=mkosiba@chromium.org,benwells@chromium.org

Review URL: https://codereview.chromium.org/694773003

Cr-Commit-Position: refs/heads/master@{#305130}
2014-11-21 01:03:06 +00:00
mek
ddb153288a Properly queue messages sent to message ports that are transferred to a service worker.
There can be some delay between the message port being transferred to the
browser process and the renderer for the service worker being available, so
this change makes sure that during this period messages sent to these message
ports are queued, rather than get lost/cause assertions to fail.

Additionally, ports that are send to these ports while they are queued will be similarly delayed, and thus also need to be put in this special state.

Finally when for some reason launching the service worker fails all these ports (that are not associated with any renderer) need to be cleaned up, which might have to happen asynchronously, since the source renderer process might not have finished sending the message queue for this port yet.

Some layout tests for this are in https://codereview.chromium.org/729923004/

BUG=432678

Review URL: https://codereview.chromium.org/737833002

Cr-Commit-Position: refs/heads/master@{#305120}
2014-11-21 00:31:40 +00:00
f7cbdde4cc ChildProcessLauncher: Don't access context_ private members directly.
This cleanup should not modify behavior.

BUG=417532
R=creis@chromium.org

Review URL: https://codereview.chromium.org/738283002

Cr-Commit-Position: refs/heads/master@{#305110}
2014-11-20 23:30:52 +00:00
be940e9e15 Enable MSVC warning for unused locals.
There is seemingly a bug in the compiler where it occasionally claims a local is
unused when it isn't.  This forces a few places to either inline such locals or
mark them ALLOW_UNUSED_LOCAL.

BUG=81439
TEST=none
R=brettw@chromium.org, cpu@chromium.org, jamesr@chromium.org, rvargas@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, wolenetz@chromium.org

Review URL: https://codereview.chromium.org/731373002

Cr-Commit-Position: refs/heads/master@{#305108}
2014-11-20 23:16:57 +00:00
bebcbc64be Added few validations in Direct Write Font Cache code.
- Added exclusive_write while writing to cache file, so that if there is any
case where two utility processes try to write to cache at same time, it could be prevented.
- Also added check to read minimum structure size bytes.

BUG=434503
R=cpu,ananta

Review URL: https://codereview.chromium.org/733253005

Cr-Commit-Position: refs/heads/master@{#305105}
2014-11-20 23:10:50 +00:00
9f5942b3e5 Collect frames into a work queue to simplify the state machine. This
corrects a bug with flushing and will make it easier to implement the
reorder queue.

BUG=133828

Review URL: https://codereview.chromium.org/706023004

Cr-Commit-Position: refs/heads/master@{#305098}
2014-11-20 22:57:05 +00:00
c5be44c904 Add cc::RendererSettings for use in with cc::Display
The settings are taken from the ui::Compositor's LayerTreeSettings. Previously it was just using the default LayerTreeSettings, which can be suboptimal.

Review URL: https://codereview.chromium.org/675083002

Cr-Commit-Position: refs/heads/master@{#305087}
2014-11-20 22:17:33 +00:00
323f0ecd1c Don't set page scale limits inside EventSender::setPageScaleFactor.
This prevents proper testing of pinch-zoom as the limits change on every zoom
and limits are used to calculate the main frame size in virtual-viewport pinch
to zoom. This is part of a 3-sided patch:

1) Add a setPageScaleFactorLimits to EventSender
2) Change existing layout tests that use setPageScaleFactor to use this method
   to set up the limits.
3) This patch removes the setPageScaleLimits call inside setPageScaleFactor.

BUG=435151

Review URL: https://codereview.chromium.org/738463003

Cr-Commit-Position: refs/heads/master@{#305084}
2014-11-20 22:04:25 +00:00
20db5d6d85 Use the request URL as the URL of the resources which are fetched ServiceWorker [2/3 chromium]
1/3 blink: https://codereview.chromium.org/732963003
 - Intorduce originalURLViaServiceWorker in ResourceResponse and WebURLResponse
 - Change CSP check to use originalURLViaServiceWorker if exists in ResourceFetcher::didReceiveResponse().
2/3 chromium: https://codereview.chromium.org/731983003 [THIS PATCH]
 - Stop updating the request's URL in ResourceDispatcher::OnReceivedResponse() and WebURLLoaderImpl::Context::OnReceivedResponse().
 - Set WebURLResponse's originalURLViaServiceWorker in WebURLLoaderImpl::PopulateURLResponse().
3/3 blink: https://codereview.chromium.org/732003002
 - Change CSP check to use originalURLViaServiceWorker.
 - Add LayoutTest for this bug.

BUG=433743

Review URL: https://codereview.chromium.org/731983003

Cr-Commit-Position: refs/heads/master@{#305075}
2014-11-20 20:34:44 +00:00
mek
aa5ac2e2e0 Make sure message ports that are transferred to a serviceworker end up in the right process.
This still has one remaining issue in that there are some situation where MessagePortService in the browser process might unqueue these transferred message ports before the service worker has been started. That will be fixed in a separate CL.

https://codereview.chromium.org/730543005/ has a test for this fix.

BUG=432678

Review URL: https://codereview.chromium.org/733703002

Cr-Commit-Position: refs/heads/master@{#305074}
2014-11-20 20:25:30 +00:00
2847144d7e Fix compilation of ipc fuzzer utilities.
TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/743243002

Cr-Commit-Position: refs/heads/master@{#305067}
2014-11-20 19:54:37 +00:00
cee75f0a79 Fix a bunch of Java Checkstyle issues.
BUG=318404
TBR=samuong@chromium.org

Review URL: https://codereview.chromium.org/744453002

Cr-Commit-Position: refs/heads/master@{#305047}
2014-11-20 18:46:15 +00:00
fcefc83beb Undoing instrumentations for task URLRequestSimpleJob::StartAsync
After the fix, jankiness disappeared from this task.

BUG=422489
TBR=tony@chromium.org, danakj@chromium.org, thestig@chromium.org, finnur@chromium.org, michaeln@chromium.org, avi@chromium.org

Review URL: https://codereview.chromium.org/747443002

Cr-Commit-Position: refs/heads/master@{#305037}
2014-11-20 18:16:46 +00:00
a261b771b9 remove some calls to to-be-deprecated v8::Value::To* functions
TBR=eroman@chromium.org, kalman@chromium.org, jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/744723002

Cr-Commit-Position: refs/heads/master@{#305034}
2014-11-20 17:55:28 +00:00
6730701ccd [DevTools] Move PNG encoding from UI to worker thread.
BUG=397107

Review URL: https://codereview.chromium.org/716053003

Cr-Commit-Position: refs/heads/master@{#305033}
2014-11-20 17:53:23 +00:00
e70be8b875 PepperVideoSourceHost: Use natural_size instead of visible_rect.size
media::VideoFrame may be scaled lazily by having natural_size < visible_rect.size. PepperVideoSourceHost currently ignores this and sends the full resolution to the effects plugin anyway. This CL makes PepperVideoSourceHost respect natural_size by downscaling the frame if necessary before sending it to the effects plugin.

TEST=Open the camera in 1080p with e.g. https://apprtc.appspot.com/?debug=loopback&video=minWidth=1920,minHeight=1080. Join a Hangouts. Natural size will be set to 720p and trigger a rescaling.

Review URL: https://codereview.chromium.org/736033002

Cr-Commit-Position: refs/heads/master@{#305031}
2014-11-20 17:48:44 +00:00
e72da7ae10 Remove dead code in ContentVideoView.
This code was used when Android native controls were
used for fullscreen video instead of html5 controls.

Review URL: https://codereview.chromium.org/739613003

Cr-Commit-Position: refs/heads/master@{#305028}
2014-11-20 17:34:46 +00:00
6dbe8de85a [DevTools] Used generated Worker.disconnectedFromWorker
BUG=405566

Review URL: https://codereview.chromium.org/744683002

Cr-Commit-Position: refs/heads/master@{#305027}
2014-11-20 17:33:38 +00:00
d28baa33b8 [Android] Isolate OverscrollRefresh from device density
Make the OverscrollRefresh effect take the target drag threshold as a
parameter. This isolates it from direct dependencies on the device scale
factor, making associated unit tests determnistics across all devices.

BUG=435125

Review URL: https://codereview.chromium.org/748433002

Cr-Commit-Position: refs/heads/master@{#305026}
2014-11-20 17:27:39 +00:00
4edf9ba767 Disable two tests that need to be updated after a Blink change lands.
BUG=378799
TBR=aboxhall
NOTRY=true

Review URL: https://codereview.chromium.org/725463004

Cr-Commit-Position: refs/heads/master@{#305025}
2014-11-20 17:07:56 +00:00
bf82318b89 LevelDB: Using base::File for all file I/O
Eliminated platform specific (stdio & Windows) File I/O calls and replaced with
the use of base::File. This makes Chrome's Env (nearly) platform agnostic while
simplifying the implementation.

BUG=431914

Review URL: https://codereview.chromium.org/710373002

Cr-Commit-Position: refs/heads/master@{#305020}
2014-11-20 16:33:17 +00:00
9c9d7fc864 [DevTools] Used generated Inspector.detached in DevToolsHttpHandlerImpl
BUG=405566

Review URL: https://codereview.chromium.org/733443003

Cr-Commit-Position: refs/heads/master@{#305018}
2014-11-20 16:13:54 +00:00
4c60e323e1 Rename network_prefix to prefix_length in NetworkInterface structure.
BUG=

Review URL: https://codereview.chromium.org/730623002

Cr-Commit-Position: refs/heads/master@{#305017}
2014-11-20 16:01:49 +00:00
2aaf4e3d37 [DevTools] Used generated inspector protocol handler
BUG=405566

Review URL: https://codereview.chromium.org/738373002

Cr-Commit-Position: refs/heads/master@{#305010}
2014-11-20 14:20:07 +00:00
d98157d4fd Remove the old Web Notification code-path (Chromium)
This patch removes the old Web Notifications code-path now
that we've switched to the new Workers-enabled path.

BUG=392187

Review URL: https://codereview.chromium.org/740543003

Cr-Commit-Position: refs/heads/master@{#305005}
2014-11-20 13:15:25 +00:00
5e431c1548 Create "stream texture proxy" before "stream texture"
Background: WebMediaPlayerAndroid's constructor does not know
video meta data. Meta data is received in OnVideoSizeChanged().
If ShouldUseVideoOverlayForEmbeddedEncryptedVideo answers true
WebMediaPlayerAndroid's constructor postpones stream texture
creation until OnVideoSizeChanged().

Problem: When constructor sets needs_establish_peer_ = false,
TryCreateStreamTextureProxyIfNeeded() does not create a proxy.
Without a proxy OnVideoSizeChanged() cannot create a stream
texture.

Solution: Once we get meta data, create proxy AND texture.

BUG=433833
TEST=Manual,
 1. Play a Youtube clip (no black frame).
 2. Play a purchased movie at Youtube (no black frame).

Review URL: https://codereview.chromium.org/730103002

Cr-Commit-Position: refs/heads/master@{#304995}
2014-11-20 09:04:12 +00:00
112adc89f9 Reland rewrite clipboard write IPC handling to be easier to understand.
The original implementation sent clipboard data to be written over IPC
as a map of clipboard formats to 'parameters' for that format. The
parameters were just vectors of byte vectors. Needless to say, this
logic was complicated, fragile, and prone to bugs. In the browser
process, this resulted in the IPC validation logic being scattered
between ClipboardMessageFilter and Clipboard::DispatchObject.

The rewrite adds an IPC message for each flavor of data that the
renderer is allowed to write to the clipboard. On the browser side,
the logic is simply delegated to ScopedClipboardWriter. Since the
clipboard object map is no longer under the control of an untrusted
process, this allows the removal of a lot of validation logic.
Unfortunately, bitmap handling is still a bit complicated because it's
sent over shared memory, but all the validation logic has been moved
into ClipboardMessageFilter.

BUG=319285
TBR=avi@chromium.org,jamesr@chromium.org,wfh@chromium.org

Review URL: https://codereview.chromium.org/740763003

Cr-Commit-Position: refs/heads/master@{#304988}
2014-11-20 07:17:08 +00:00
cba132919f Use uint16 for port numbers more pervasively.
We currently use a mixture of ints and uint16s for port numbers.  This triggers a variety of "value possibly truncated" warnings on MSVC (currently disabled) wherever we implicitly truncate.  Fix this by using uint16 consistently through more functions.  (Using int consistently would be more problematic as the majority of third-party/system APIs that use port numbers use 16-bit types for them.)

By far the majority of these changes are fallout from changing IPEndPoint, which is widely used; it'd be difficult to split this CL up into smaller pieces :(

Note that I didn't use uint16_t to avoid introducing inconsistencies between existing uint16 usage and new uint16_t usage.  Conversion of everything to uint16_t can happen later.

This CL was reviewed and approved in pieces in the following CLs:
https://codereview.chromium.org/716223002/
https://codereview.chromium.org/717263003/
https://codereview.chromium.org/717373002/
https://codereview.chromium.org/718273002/
https://codereview.chromium.org/722503002/
Committing as TBR to the original reviewers.

BUG=81439
TEST=none
TBR=gunsch,cpu,jhawkins,davidben,jyasskin,mmenke

Review URL: https://codereview.chromium.org/655063002

Cr-Commit-Position: refs/heads/master@{#304961}
2014-11-20 03:35:46 +00:00
14bcfc52eb Emit Media Source codec names as media_log events.
Media source codec names will appear in chrome://media-internals
and be recorded by the PipelineStatus histogram.

BUG=431447

Review URL: https://codereview.chromium.org/743483002

Cr-Commit-Position: refs/heads/master@{#304943}
2014-11-20 00:30:33 +00:00
872df152e5 Mojo: Raise the message size limit.
The default message size limit 4MB is too small for Chrome IPC.

TEST=Layout Tests with a flag on
BUG=377980
R=viettrungluu@chromium.org, jam@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/741813002

Cr-Commit-Position: refs/heads/master@{#304938}
2014-11-20 00:15:21 +00:00
15071e55a8 [Android] Tweak the pull-to-refresh effect animation
Modify pull-to-refresh drag movement, as well as the initial activation
animation, to more closely align with the default Android platform
effect.

BUG=428429

Review URL: https://codereview.chromium.org/733273004

Cr-Commit-Position: refs/heads/master@{#304931}
2014-11-19 23:55:46 +00:00