There is only one remaining use of NotificationService which is
pending removal [1]. In the meantime, we can start removing
supporting code for NotificationService which is not needed for this
remaining case.
In particular:
- Remove checks for a non-null NotificationService in code that
otherwise doesn't use it.
- NotificationService is no longer used on the IO thread, so we no
longer create one there.
- Move code that no longer needs to be in content public into the
content Impl classes.
- Remove code that's dead and trivial to remove or code that can be
defaulted by the compiler.
Note that some NotificationService functionality is now essentially
dead code outside of unit tests, but this CL leaves the core
implementation alone, given that's it's just going to be deleted
entirely.
[1] b/301214499
Bug: 40327896
Change-Id: Id70b6ead574d401f63b4d20b845b1c6e96b3b575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5622038
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1314368}
It's left over from when the network service was run in the browser
process, but that's no longer the case. All consumers have now been
migrated, so we can at at last delete it.
Bug: 1010491
Change-Id: I5191cb715e70c64eb865d3309ac31fcb02b8a081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702852
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015073}
This replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes
where a local script is able to detect its insertion place (~Foo() is
public => insert before this line).
This is incomplete as not all classes have a public ~Foo() declared, so
not all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.
IWYU cleanup is left as a separate pass that is easier when these macros
go away.
Bug: 1010217
Change-Id: Iea478401b7580682c7b9f195f7af9cbbdb6ce315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3167292
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923194}
