Splitting the changes required to switch to clang_rt/libunwind will
allow to have faster review/landing cycle with reduced amount of
required approvals.
This is a requirement to migrate to the NDK r23 and enablement
of new features (e.g. PAC/BTI).
Bug: 1184398, 1246049
Change-Id: I97300024573287ec38ff7ded7f0f44278de30700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242085
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935235}
This CL makes some small changes to the chromevox classic earcon engine,
to ax_enums, perf docs and an a11y test to use the modern 'main'
instead of the previously used language. The change should have no
user-facing effects.
AX-Relnotes: N/A
Bug: N/A
Change-Id: I3837689f837f4772d0489c9e675f0eba590ff0fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243269
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935059}
This CL makes some small tweaks to our lookalike documentation in
an attempt to make the instructions clearer, and encourage site
owners to use DAL-based verification instead of manual reviews.
Change-Id: I0e88d58d72447e328a9a009c9012796423d74263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233777
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#933523}
Other mandatory command steps are called out using <pre> blocks.
This makes to more obvious that running gclient after unpacking
depot_tools.zip is a mandatory step.
Bug: 1259839
Change-Id: I7a8eb512b7f59697d411da0e481fafac00faaae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230403
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#933124}
Test runner and TUF installation rules are rewritten to make use of
the "fuchsia_run_script_with_packages" template, which adds package
handling to wrapper script generation and little else.
Adds a new target "chrome_fuchsia_runner", which deploys and executes
the standalone Chrome executable on a device.
Test runner script generation is relocated from testing/test.gni to
reduce clutter in that BUILD.gn file.
Bug: 1256870
Change-Id: I23058a8bc1b59b1be3dae79bb986d6efee72b680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206480
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Chong Gu <chonggu@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932266}
This is in preparation for adding a separate directory for focal.
In addition, the name of the prebuilt binaries changes from
msan-no-origins-xenial.tgz to msan-no-origins.tgz. This is so that
projects like V8 do not have to manually update their DEPS entries
when auto-rolling //third_party/instrumented_libraries.
BUG=1260217
R=thestig
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng
Change-Id: Id2eb94405f76e590cbc25b425c80eb08353d871f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224627
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932225}
Test modules needs to have a stub version of the interface class
available to satisfy the linker. This stub is declared with the
macro GREY_STUB_CLASS_IN_APP_MAIN_QUEUE.
Xcode code completion is broken if the macro is not followed by
a semi-colon, but clang complains about trailing semi-colon in a
place where it is not required.
To bypass this issue, for each foo_interface.h file, create a
foo_interface_stub.mm file containing just the macro call. It
also avoid putting the stub declaration in a random source file.
Fix some naming inconsistency in file/target names.
Bug: 1015113
Change-Id: I6596575e8b7f8c0fac42fc8aace1568cecd69dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222908
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931916}
Make some guidance available on re2 use in privileged processes.
This position is fairly conservative and reflects recent enquiries to the security team.
Change-Id: I01b7f19275c83dc867b2d61ff092ba7ca3e91a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209461
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931715}
This patch renames `GURL::GetOrigin()` to
`GURL::DeprecatedGetOriginAsURL()`. A subsequent patch will
reintroduce a `GURL::GetOrigin()` that returns a `url::Origin`
rather than a `GURL`.
This patch was brought to you by sed, followed by a little manual
work to deal with look-alike methods (most notably
`CascadePriority::GetOrigin()` and `NudgeTracker::GetOrigin()`) and
two or three spots that held pointers to GURLs:
```
git grep -n -l ".GetOrigin(" | \
xargs -L1 sed -i '' \
-e 's/\.GetOrigin(/.DeprecatedGetOriginAsURL(/g'
```
Bug: 512374
Change-Id: I03fb290650b8759d9849af0911cad9bdc92a5132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220292
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931431}
You can specify a number of different "footers" in your CL
description to change how the CQ and builder recipes will process
your CL. This CL updates the documentation for three footers that
were previously missing (Binary-Size, Disable-Retries, and
Include-Ci-Only-Tests).
Change-Id: If0592ab21f2ae08dcf3cb65cc29f7086d85099dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221455
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#931311}
Adds ServiceSandbox attribute to AudioService and NetworkService
interfaces and deletes the final service_sandbox_type.h file. All
service sandboxes are now specified this way.
These two services are different, however. Their sandboxes can be
disabled (to kNoSandbox) by policy or feature flags. This means
the service launching machinery must know how to do this. In this
CL we move this logic into the ServiceProcessHost which in turn
asks the ContentBrowserClient if the sandboxes should be enabled.
As this is only necessary for two sandbox types we have not
generalised the CBC interface.
We also delete `sandbox_type` from service process host options
as it cannot be specified as an option and must be specified using
the ServiceSandbox attribute on the launched mojom. We migrate
the type used within ServiceProcessHost to sandbox::mojom::Sandbox.
A future CL will replace sandbox::policy::mojom::SandboxType with
the mojom type throughout.
Bug: 1210301
Change-Id: I4de13359487158a52da8ad414c8beb9cd93033bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209992
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#930365}
