This enables the CETCOMPAT linker flag for Windows marking binaries
as CET compatible. On supporting hardware this will cause Chrome to
run with Hardware Enforced Stack Protection for compatible modules.
CET will still be disabled for the renderer process as the feature
CetForRenderer is default-disabled.
x86 is not supported: build/config/compiler/BUILD.gn:2519
Tests: mini_installer on supporting hardware
Bug: 1131225
Change-Id: Ic5db6eca0acf4cdfb0eff0f624e4d4f4e5a7da50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602845
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845041}
This experimental build option to mark binaries as compatible with Shadow
Stack of Control-flow Enforcement Technology (CET).
THe option is not any close to enable in official builds, it's here
for convenice of evaluation.
As it passes base_unittests and components_unittests.
Bug: 1136224
Change-Id: I6fcd61c2e76066b444cc37c88228273838300243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454988
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819145}
- Regularised capitalisation of Windows.
- Removed some hemming and hawing about out of support Windows versions.
- Tidied a couple of broken links and references.
Change-Id: I2e84b9ee6ec83ad77a31f4998273989c9dd1852b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649299
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669858}
This is the last step after moving all the code.
Sorry for the ginormous review. It would have been tedious to split
up.
BUG=876924
TEST=covered by tests
TBR=tsepez@chromium.org
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I237c4377115ad12fefb95a1bcf2eabe1cbef3414
Reviewed-on: https://chromium-review.googlesource.com/1195809
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587338}
The nested code section was not rendering correctly on the live
Markdown server, and didn't match the tools/md_browser preview.
Simplify the layout to avoid inconsistencies.
Bug: 801929
Change-Id: Id8f84f24407d39dd2d125d8f349d214fccbe254a
Reviewed-on: https://chromium-review.googlesource.com/892478
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533106}
Simplify GenSyncTokenCHROMIUM and GenUnverifiedSyncTokenCHROMIUM to
implicitly insert the fence and issue ordering barrier or flush. Change
all call sites and update the documentation to reflect this.
R=piman
BUG=NONE
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8551f8d0ccf3b7f6027f3e54443ae06cfa0d074b
Reviewed-on: https://chromium-review.googlesource.com/826007
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524576}
Implement a command buffer interface for native file descriptor backed
cross-context GpuFence objects. See CHROMIUM_gpu_fence.txt for the GLES
API description and docs/design/gpu_synchronization.md for background
information including usage examples.
gl::GLFenceAndroidNativeSyncPoint - low-level wrapper for underlying GL
calls.
gfx::GpuFenceHandle - IPC-transportable wrapper for the sync file
descriptor.
gfx::GpuFence aka ClientGpuFence - owning container for a GpuFenceHandle,
and convertible to/from a ClientGpuFence for use with GL calls.
gpu::gles2::GpuFenceManager tracks GpuFenceEntry objects by client-assigned
ID number. Each entry stores a gl::GLFence as currently implemented
by the gl::GLFenceAndroidNativeSyncPoint subclass.
BUG=761432
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibae5c377528db9a9382b64a2648ac56a5a0f53f6
Reviewed-on: https://chromium-review.googlesource.com/680135
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523001}
The helper function make_scoped_refptr() doesn't match the base/std
naming convention for make to construct the object. Now there is
MakeRefCounted() to make a new scoped_refptr and WrapRefCounted() to
wrap something in scoped_refptr, similar to MakeUnique() and
WrapUnique(). This is a purely mechanical regex search and replace.
Bug: 765333
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5057e51282e519693f6fca504bd54deb638b712f
Reviewed-on: https://chromium-review.googlesource.com/667726
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506316}
This reverts commit 6127a86f3a.
Reason for revert: Suspect this caused spike in ThreadWatcher hang reports: crbug.com/768886
Original change's description:
> Remove all remaining deprecated Web/BrowserThreads!!
>
> (except BrowserThread::FILE which has a handful use cases left still and
> will follow suit shortly)
>
> (BrowserThread::PROCESS_LAUNCHER migration was put on hold because of
> Android specific requirements around process launching)
>
> Remaining usage of TestBrowserThreadBundle::REAL_DB_THREAD could simply
> be removed as all of the product code was already migrated to TaskScheduler
> which always uses real threads in unit tests.
>
> Bug: 689520, 365909, 752144
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
> Change-Id: Id70b722aa35e8568795d5aac16947392ac1597be
>
> NOPRESUBMIT=True (for content/browser/browser_thread_impl.cc:211)
>
> Change-Id: Id70b722aa35e8568795d5aac16947392ac1597be
> Reviewed-on: https://chromium-review.googlesource.com/610880
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503732}
TBR=gab@chromium.org,jam@chromium.org,dpranke@chromium.org,asvitkine@chromium.org,sdefresne@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
NOPRESUBMIT=True (for restoring the deprecated browser threads)
Bug: 689520, 365909, 752144, 768886
Change-Id: I53d93572118303743e1dde71b2a473350717b215
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/689254
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504939}
(except BrowserThread::FILE which has a handful use cases left still and
will follow suit shortly)
(BrowserThread::PROCESS_LAUNCHER migration was put on hold because of
Android specific requirements around process launching)
Remaining usage of TestBrowserThreadBundle::REAL_DB_THREAD could simply
be removed as all of the product code was already migrated to TaskScheduler
which always uses real threads in unit tests.
Bug: 689520, 365909, 752144
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Id70b722aa35e8568795d5aac16947392ac1597be
NOPRESUBMIT=True (for content/browser/browser_thread_impl.cc:211)
Change-Id: Id70b722aa35e8568795d5aac16947392ac1597be
Reviewed-on: https://chromium-review.googlesource.com/610880
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503732}
Calling a callback with a raw pointer argument while binding a scoped_refptr to
it requires using base::RetainedRef. Correct the same in threading
documentation. Also, introduce std::move in the example to demonstrate
preventing an extra AddRef/Release pair.
BUG=None
Review-Url: https://codereview.chromium.org/2944313004
Cr-Commit-Position: refs/heads/master@{#482065}
