0
Commit Graph

10 Commits

Author SHA1 Message Date
Raul Tambre
4cec3657e2 tools: Use Python 3 style print statements [2/9]
Initial conversion performed using '2to3 -f print .'.
Imports added and duplicate parentheses removed manually.
Manually converted files, comments and inline code that 2to3 missed.
Afterwards ran "git cl format --python" and cherry-picked the formatting changes.

Fixed a syntax error in check_grd_for_unused_strings.py due to a missing comma (caught by pylint).

There are no intended behavioural changes.

Bug: 941669
Change-Id: Ie0c67e5e416f386830e95aa2469b18a98b5425a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818477
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#698787}
2019-09-22 17:30:32 +00:00
drott
7813ff35ac Fix encoding issue in check_git_config
Fix for
"Unicode equal comparison failed to convert both arguments to Unicode"
when the git username contains non-ascii characters. Fixed by
utf-8 decoding data imported from git.

BUG=521519

Review URL: https://codereview.chromium.org/1301453003

Cr-Commit-Position: refs/heads/master@{#343836}
2015-08-18 06:27:33 +00:00
groby
a285259d41 Fix "Managed Mode" URL.
At some point, managed mode got its own subpage - fix URL in
deprecation warning to point there.

BUG=none
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/766273002

Cr-Commit-Position: refs/heads/master@{#306255}
2014-12-01 21:23:00 +00:00
vadimsh
910466bbf7 Do not suggest to replace .DEPS.git with DEPS.
Both are valid since depot_tools r291592.

TBR=agable@chromium.org
NOTRY=true
BUG=406934

Review URL: https://codereview.chromium.org/488313003

Cr-Commit-Position: refs/heads/master@{#291630}
2014-08-24 23:04:25 +00:00
Vadim Shtayura
d484d5934e Do not freak out if 'deps_file' is not specified.
Default DEPS is now correct.

BUG=406661
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/499013002

Cr-Commit-Position: refs/heads/master@{#291565}
2014-08-23 02:50:14 +00:00
Vadim Shtayura
daf35abca9 Check that 'DEPS' is used in gclient solution (not '.DEPS.git').
R=iannucci@chromium.org
BUG=406661

Review URL: https://codereview.chromium.org/493753003

Cr-Commit-Position: refs/heads/master@{#291564}
2014-08-23 02:27:48 +00:00
vadimsh@chromium.org
b3b918c753 Show additional warning about managed workflow.
Additional changes:
 * Use git.bat on Windows.
 * Collect insteadOf entries.
 * Catch one more ACL error.

R=iannucci@chromium.org
BUG=399054
NOTRY=true

Review URL: https://codereview.chromium.org/488243002

Cr-Commit-Position: refs/heads/master@{#290955}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290955 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-21 00:09:39 +00:00
vadimsh@chromium.org
97c58bc39e Do not complain about wrong gclient config if there's no 'src' solution.
BUG=405475
TBR=iannucci@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/495613002

Cr-Commit-Position: refs/heads/master@{#290870}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290870 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-20 18:24:27 +00:00
vadimsh@chromium.org
e92d872c35 Recognize one more git push error message as ACL related.
TBR=iannucci@chromium.org
BUG=399054
NOTRY=true

Review URL: https://codereview.chromium.org/485263004

Cr-Commit-Position: refs/heads/master@{#290662}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290662 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-19 21:03:26 +00:00
vadimsh@chromium.org
46b32a8d53 Verify that gclient solution looks correct.
Print big nagging warning (everytime gclient hooks run) if gclient solution
is not configured to use unmanaged git workflow.

Also stop uploading reports on Oct 1. We don't want to keep appengine app
online forever.

R=iannucci@chromium.org
BUG=404747
NOTRY=true

Review URL: https://codereview.chromium.org/482083004

Cr-Commit-Position: refs/heads/master@{#290430}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290430 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-19 00:39:06 +00:00