Updates the following in the GPU documentation:
1. Links to the Skia Gold instance. There were still references to the
old chrome-gpu-gold.skia.org instance that has been gone for a long
time.
2. Links to the pixel_wrangling.md documentation, which has been moved
to various internal documentation pages.
Bug: 1250846
Change-Id: Ib72b870c91a8048bbe4568256ff1845c2d72d7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173927
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#924044}
Adds a script to find optimal values for inexact matching in the GPU
pixel tests and enables inexact matching on several problematic tests
that could benefit from it.
Bug: 1074130
Change-Id: If4597bbda1a94fdc4dd28f87ca59ea86489c2ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173415
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764424}
Merges various parts of the GPU Gold documentation from
gpu_pixel_testing_with_gold.md into the other parts of the GPU
documentation. Also removes references to the legacy pixel tests and
their triage process since the code for them has been removed.
Bug: 985007
Change-Id: I19d5480de77f1066046ef8fe0f076264cff01ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721523
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681868}
Removes all the code that was only used by the legacy (cloud
storage-based) GPU pixel tests since Gold is now used everywhere.
Additionally, moves much of the remaining code out of
cloud_storage_integration_test_base and into specific subclasses since
it was only actually being used by one subclass.
This is pretty much cut/paste work - refactoring work to make the code
more readable will come in a follow-up CL.
Bug: 985007
Change-Id: Ifd42142629f641e737675b5b4c0b1091b98b9757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715626
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680655}
Adds a --local-run flag to the GPU pixel tests. This causes goldctl to
run in --dryrun mode (i.e. no uploads) and makes the test runner output
file:// URLs to the produced images. This makes it much more suitable
for local runs, since Gold's normal usage mode is designed to be used on
the bots.
Bug: 985418
Change-Id: I70021679e725d619c9dfc38598655c881b2dcb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713588
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679778}
Adds a small section to the GPU Skia Gold Markdown documentation
explaining how to find a failed swarming task for a bad image in the
rare case that a bad image is found without a link to the failed build.
Bug: 965234
Change-Id: I257c95ed686f8b6902bd0739b9a1bb93054906f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700293
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677127}
Updates some portions of the GPU Skia Gold markdown documentation, such
as the new triage process using the links reported in Milo.
Bug: 965234
Change-Id: If22ee0f6e7af1054df98630f2f9ebb616a8fdbf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668092
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675816}
Adds Markdown documentation on the GPU team's Skia Gold-enabled pixel
tests, such as how to triage images, how they work, and how to modify
Gold if necessary.
Bug: 965234
Change-Id: Ie77c9679e458d7196af1457edbf2b06f45799f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638739
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668976}
