0
Commit Graph

99 Commits

Author SHA1 Message Date
wfh
0539f2f521 Block NPAPI plugins by default
Add --enable-npapi flag in chrome://flags to support re-enable.

BUG=295137
TEST=browser_tests, unit_tests, content_browsertests, blink layout tests

Review URL: https://codereview.chromium.org/645203002

Cr-Commit-Position: refs/heads/master@{#312374}
2015-01-21 14:38:17 +00:00
rvargas
b805615793 Plugin service: Use the correct registry key for each watch operation.
6f315b85b9 master@{#300036} introduced a regression where the two
registry keys that are watched for changes to detect installation of NPAPI
plugins, were being mixed.

This CL fixes the issue... using the correct key each time a new StartWatching
is called.

BUG=428560
R=piman@chromium.org

Review URL: https://codereview.chromium.org/708933002

Cr-Commit-Position: refs/heads/master@{#303347}
2014-11-08 01:44:44 +00:00
thestig
27bf1c27bf Cleanup: Remove unneeded path_service.h includes.
Review URL: https://codereview.chromium.org/689563002

Cr-Commit-Position: refs/heads/master@{#303095}
2014-11-06 21:56:07 +00:00
rvargas
6f315b85b9 Remove raw handles from base::win::RegKey
BUG=419210, 423634
R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org

Committed: https://crrev.com/1aa0fa75b65f403e08ae0f3f2fcb053c02cd9ef2
Cr-Commit-Position: refs/heads/master@{#299737}

Review URL: https://codereview.chromium.org/632833002

Cr-Commit-Position: refs/heads/master@{#300036}
2014-10-17 01:29:21 +00:00
dcheng
4fe6ccadfd Revert of Remove raw handles from base::win::RegKey (patchset id:330001 of https://codereview.chromium.org/632833002/)
Reason for revert:
Causing base_unittests failures on XP Tests (1)

Original issue's description:
> Remove raw handles from base::win::RegKey
>
> BUG=419210, 423634
> R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org
>
> Committed: https://crrev.com/1aa0fa75b65f403e08ae0f3f2fcb053c02cd9ef2
> Cr-Commit-Position: refs/heads/master@{#299737}

TBR=cpu@chromium.org,eroman@chromium.org,jam@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=419210, 423634

Review URL: https://codereview.chromium.org/652903005

Cr-Commit-Position: refs/heads/master@{#299828}
2014-10-16 03:09:45 +00:00
rvargas
1aa0fa75b6 Remove raw handles from base::win::RegKey
BUG=419210, 423634
R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/632833002

Cr-Commit-Position: refs/heads/master@{#299737}
2014-10-15 19:17:09 +00:00
jam
3458fc0095 Stop using an atom to store plugin name/version on Windows.
On the swarming bots we are seeing flakes in the plugin tests. Setting the atom fails because the atom table fills up. I tracked this down to the fact that sometimes the atom destruction path doesn't get hit depending on how the plugin shuts down. Rather than fix it, I removed this code and used a simpler mechanism to get the title & version in the browser process.

BUG=412042

Review URL: https://codereview.chromium.org/557893003

Cr-Commit-Position: refs/heads/master@{#294088}
2014-09-10 03:25:27 +00:00
dcheng
54c3719d6b Remove implicit conversions from scoped_refptr to T* in content/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/504273002

Cr-Commit-Position: refs/heads/master@{#291986}
2014-08-26 21:54:29 +00:00
brettw@chromium.org
47927870b2 Add base:: qualification to some COmmandLine references in content.
TBR=sky

Review URL: https://codereview.chromium.org/456513002

Cr-Commit-Position: refs/heads/master@{#288787}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288787 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-11 20:33:10 +00:00
hamaji@chromium.org
aec5ed535e Pepper: Whitelist dev channel APIs for some apps.
Some applications need access to dev channel APIs before they will
become stable. As written, this change only performs whitelisting for NaCl
apps; I don't think we have any need for enabling this in the non-NaCl case.

I need to find a good way to test this.

BUG=383937
R=dmichael@chromium.org, jln@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/338523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278645 0039d316-1c4b-4281-b951-d872f2087c98
2014-06-20 07:51:42 +00:00
thestig@chromium.org
a01c8c8f7c Linux: Remove some unused NPAPI code.
Review URL: https://codereview.chromium.org/271753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269358 0039d316-1c4b-4281-b951-d872f2087c98
2014-05-09 17:24:53 +00:00
bauerb@chromium.org
aa7f880a41 Restart plugin loading only if the plugin list has actually become stale.
BUG=171404

Review URL: https://codereview.chromium.org/128773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247252 0039d316-1c4b-4281-b951-d872f2087c98
2014-01-27 16:56:32 +00:00
avi@chromium.org
3295612b18 Update uses of UTF conversions in content/ to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/121033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242483 0039d316-1c4b-4281-b951-d872f2087c98
2013-12-25 07:29:24 +00:00
teravest@chromium.org
8ddc6b7c44 Pepper: Send dev/canary channel status to plugins.
As part of supporting "dev channel" methods in Pepper APIs, the plugin needs to
know whether or not it's running in a channel that supports those methods.

This patch plumbs that information through LoadPlugin so it's available by the
time get_interface<>() would ever be called.

TBR=piman
BUG=325403

Review URL: https://codereview.chromium.org/104673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240398 0039d316-1c4b-4281-b951-d872f2087c98
2013-12-12 20:42:06 +00:00
ihf@chromium.org
132bca8c3e Instrument pepper plugin load failures.
ChromeOS experiences an increased failure to load Pepper Flash plugins.
To help investigate these failures in the field increase logging.
Also disallow npapi plugin generation on ChromeOS as a fallback. We
don't need a zombie process when this failure happens.

BUG=chromium:314301
TEST=kill -stop, reload, kill -9 ppapi process on Pixel.

Review URL: https://codereview.chromium.org/103623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239740 0039d316-1c4b-4281-b951-d872f2087c98
2013-12-10 09:14:47 +00:00
jam@chromium.org
60eca4eb05 Move more of the plugin code in the renderer to use RenderFrame instead of RenderView.
This is part of the work of making ContentRendererClient's OverrideCreatePlugin and CreatePluginReplacement take only a RenderFrame. I'm still not there yet, which is why their signatures haven't been trimmed.

BUG=304341
R=fsamuel@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/107183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239075 0039d316-1c4b-4281-b951-d872f2087c98
2013-12-06 00:02:16 +00:00
brettw@chromium.org
fcf75d4016 Convert string16 to base::string16 in content.
BUG=

Review URL: https://codereview.chromium.org/102593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
2013-12-03 20:11:26 +00:00
scottmg@chromium.org
efde84b013 LOG(INFO) -> VLOG(0) in content/
Let me know if you prefer to keep some of these as INFO or just delete
them.

R=jam@chromium.org
BUG=322805

Review URL: https://codereview.chromium.org/84293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236936 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-23 04:18:20 +00:00
creis@chromium.org
f89b2a2bb1 Remove webview-based behavior from --site-per-process flag.
We're getting close to actually swapping RenderFrameHosts instead.

BUG=99379, 314791
TEST=none

Review URL: https://codereview.chromium.org/53153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232969 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-05 13:55:54 +00:00
Geo.Liaskos@gmail.com
a220b593c5 Add more support for FreeBSD
BUG=

Review URL: https://chromiumcodereview.appspot.com/16206002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224546 0039d316-1c4b-4281-b951-d872f2087c98
2013-09-21 03:47:44 +00:00
ddorwin@chromium.org
3627aa3fa3 Check whether the Pepper CDM is available before adding the key system.
This adds a synchronous IPC from chrome_key_systems.cc to the browser process to
check with the PluginService.

BUG=224793
TEST=existing IsTypeSupported browser tests and new negative tests

Review URL: https://chromiumcodereview.appspot.com/23828007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223719 0039d316-1c4b-4281-b951-d872f2087c98
2013-09-17 22:32:51 +00:00
ben@chromium.org
bde885b4e8 Move a bunch of windows stuff from ui/base/win to ui/gfx/win
R=sky@chromium.org
BUG=103304

Review URL: https://codereview.chromium.org/23769011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222860 0039d316-1c4b-4281-b951-d872f2087c98
2013-09-12 20:55:53 +00:00
ygorshenin@chromium.org
8522332eef TCPSockets are switched to the new Pepper proxy.
BUG=230784
TEST=browser_tests:*TCPSocket*, *TCPServerSocket*

Review URL: https://chromiumcodereview.appspot.com/22923014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220073 0039d316-1c4b-4281-b951-d872f2087c98
2013-08-28 19:42:59 +00:00
jam@chromium.org
7327029fef Get rid of webkit/plugins/plugin_constants.* and move them to content/public/common/content_constants. This allows us to delete webkit_plugins.gyp and webkit/plugins.
BUG=265753
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/22723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216553 0039d316-1c4b-4281-b951-d872f2087c98
2013-08-09 03:48:07 +00:00
jam@chromium.org
dac6a5ac4f Split PepperPluginRegistry into the pieces that are needed in each process. content/common only needed a simple method to get the list of pepper plugins. The zygote specific method moves to content/zygote. The rest moves to content/renderer, as that has dependencies on the pepper implementation which depends on blink.
BUG=263054
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/20172004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213593 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-25 05:06:48 +00:00
jam@chromium.org
d7bd3e5a34 Move webplugininfo.h to content/public.
BUG=237249
TBR=scottmg

Review URL: https://codereview.chromium.org/19894003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212812 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-21 04:29:20 +00:00
jam@chromium.org
9a60ccb9a1 Remove webkit/plugins/npapi.
-NPAPIPluginsSupported moves to PluginService
  -no need to call it in PluginList methods anymore since PluginService is now the only place that calls these methods, and it can check first
  -no need for the renderer to call this first since now the browser won't enumerate NPAPI plugins if it's disabled
-CreateVersionFromString moves to WebPluginInfo. I couldn't find a better place to put it.
-move the constants back to plugin_constants_win.h
-move PLUGIN_QUIRK_DIE_AFTER_UNLOAD handling to WebPluginDelegateStub and PluginThread instead of being a global
-GetDefaultWindowParent moves to plugin_constants_win.h. I couldn't find a better place.
-IsPluginWindow moves to PluginService
-GetPluginNameFromWindow and GetPluginVersionFromWindow are both replaced by GetPluginInfoFromWindow which is on PluginService
-IsDummyActivationWindow was called by one place so I moved the code there

BUG=237249
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/19844003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212672 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-19 22:23:36 +00:00
jam@chromium.org
29e2fb456d Move NPAPI implementation out of webkit/plugins/npapi and into content.
Notes:
-gtk_plugin_container_manager* and gtk_plugin_container* move to content/browser/renderer_host/ since that's all where they're used
-plugin_list* and plugin_constants_win* move to content/common as they're used by child processes and the browser
-webplugin_impl* and webplugin_page_delegate.h move to content/renderer as that's where they're used. I will remove webplugin_page_delegate.h in a followup change as it's no longer needed.
-the rest moves to content/child/npapi
-a few constants moved from plugin_constants_win.h to plugin_util.h temporarily

BUG=237249
TBR=scottmg

Review URL: https://codereview.chromium.org/19761007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212485 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-19 01:13:47 +00:00
jam@chromium.org
8f337212cc Remove plugin_list.h includes from chrome tests in preparation for moving webkit/plugins to content/. To do this, I simplified how we disable plugin loading for tests, and also updated the test in content to use the new way.
BUG=237249
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/19706002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212249 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-18 04:34:14 +00:00
avi@chromium.org
2fccd3f47b Use a direct include of the message_loop header in content/, part 2.
BUG=260807
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19618002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212184 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-18 00:10:52 +00:00
jam@chromium.org
fb476a2653 Remove the two years old code to enable the nacl plugin once if it's disabled. This was added to deal with old profiles when we had the plugin disabled by default. There have been 15 releases in the meantime, which is enough chances to update this pref.
This is in preparation for moving webkit/plugins to content/.

BUG=237249
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/19518006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212104 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-17 19:01:47 +00:00
jam@chromium.org
1021245332 Remove unused includes of plugin_list.h. Also remove unused ContentClient and webkit_support methods that referenced or used PluginList.
BUG=237249
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/19381007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211830 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-16 20:10:55 +00:00
jam@chromium.org
6d057a0cd2 Make utility process run in-process when running in single-process mode.
Remove the unit test/single process code path for SandboxedUnpacker as a first step.

BUG=19192
R=asargent@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/18119009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210620 0039d316-1c4b-4281-b951-d872f2087c98
2013-07-09 21:12:07 +00:00
sevalo@google.com
e87ce8639c Adding --disable-plugins-discovery command line switch to not load third-party plugins from common locations.
When --disable-plugins-discovery switch is set, any built-in plugins are still loaded as well as third-party ones that are explicitly requested with --extra-plugin-dir or --load-plugin switches. No other plugins are loaded.

Switch is effective on posix, mac and win platforms.

BUG=239325

Review URL: https://chromiumcodereview.appspot.com/16369004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205850 0039d316-1c4b-4281-b951-d872f2087c98
2013-06-12 17:30:48 +00:00
avi@chromium.org
348fbaac32 Use a direct include of strings headers in content/browser/, part 2.
BUG=247723
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16625010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205435 0039d316-1c4b-4281-b951-d872f2087c98
2013-06-11 06:31:51 +00:00
brettw@chromium.org
7ccb707107 Update includes of message_loop_proxy.
This keeps the forwarding header, just updates all current callers.

BUG=
R=avi@chromium.org

Review URL: https://codereview.chromium.org/16514006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
2013-06-10 20:56:28 +00:00
avi@chromium.org
74ebfb1e11 Use a direct include of utf_string_conversions.h in content/.
BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16408017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204917 0039d316-1c4b-4281-b951-d872f2087c98
2013-06-07 20:48:00 +00:00
rsleevi@chromium.org
fc72bb18b1 Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*"
Linux fixes

BUG=110610
TBR=darin

Review URL: https://chromiumcodereview.appspot.com/16294003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203624 0039d316-1c4b-4281-b951-d872f2087c98
2013-06-02 21:13:46 +00:00
xhwang@chromium.org
dd32b127ce content: Use base::MessageLoop.
BUG=236029
R=avi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14335017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198316 0039d316-1c4b-4281-b951-d872f2087c98
2013-05-04 14:17:11 +00:00
thestig@chromium.org
d8c7006078 Cleanup various bits of BrowserThreadImpl and PluginServiceImpl.
Review URL: https://chromiumcodereview.appspot.com/13896004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195957 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-24 00:22:34 +00:00
erg@chromium.org
59383c78c7 Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>.
In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes
these in content/.

BUG=232084

Review URL: https://codereview.chromium.org/14081010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194608 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-17 16:43:27 +00:00
dcheng@chromium.org
007b3f812f Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-09 08:46:45 +00:00
dcheng@chromium.org
69d7f89d6a Revert "Rewrite std::string("") to std::string(), Linux edition."
This reverts commit e59558b78e.

Revert "Fix build after r193020."

This reverts commit 558a35897f.

Revert "Really fix build after r193020."

This reverts commit e3748a79b5.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-09 06:41:12 +00:00
dcheng@chromium.org
e3748a79b5 Really fix build after r193020.
Argh. Macros are evil.

BUG=
TBR=darin

Review URL: https://codereview.chromium.org/13937002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193029 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-09 06:27:43 +00:00
dcheng@chromium.org
e59558b78e Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-09 05:45:17 +00:00
yzshen@chromium.org
fd8d8d6cab Record stats on Chrome users running PPAPI Flash vs NPAPI Flash.
- Plugin.FlashUsage: Number of browser processes that start at least one NPAPI/PPAPI Flash process during their lifetime.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/12319137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185124 0039d316-1c4b-4281-b951-d872f2087c98
2013-02-28 02:48:33 +00:00
brettw@chromium.org
57999817d3 Move file_path.h to base/files.
TBR=sky

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
2013-02-24 05:40:52 +00:00
brettw@chromium.org
2dec8ec385 Use base namespace for FilePath in content/browser
Review URL: https://codereview.chromium.org/12213066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181349 0039d316-1c4b-4281-b951-d872f2087c98
2013-02-07 19:20:34 +00:00
jschuh@chromium.org
05f51128a7 Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/
BUG=172573
Review URL: https://codereview.chromium.org/12177018
Recommit of: https://codereview.chromium.org/12177018

TBR=cevans@chromium.org
Review URL: https://codereview.chromium.org/12209008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180700 0039d316-1c4b-4281-b951-d872f2087c98
2013-02-05 15:02:50 +00:00
jschuh@chromium.org
6a7c000f98 Revert 180600
> Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/
> 
> BUG=172573
> Review URL: https://codereview.chromium.org/12177018

Windows and aura bots are failing, and this is the only CL
in range that had no passing try runs for those tests.
If the bots don't go green, I'll unrevert the revert.

TBR=cevans@chromium.org
Review URL: https://codereview.chromium.org/12210009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180620 0039d316-1c4b-4281-b951-d872f2087c98
2013-02-05 06:18:37 +00:00