Updates the GPU Samsung A23 mixin to target the devices deployed as part
of the full A23 procurement instead of the single device we had for
initial testing.
Bug: 40236913, 380269801, 40241618, 40241614, 395060191
Bug: 40939890
Change-Id: I6220eca7790fc289ef2d41b3fdaf1fc3227f773d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240414
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417625}
Previously, fuzztest required that all possible command line arguments
be declared using absl flags. That's fine if the fuzzing engine used is
centipede, since it too uses absl flags. In Chromium though, we use
libfuzzer widely, since we need to support non-Linux platforms, and it
does not use absl flags. For that reason we had to make all possible
libfuzzer arguments known to absl by declaring them using this 'undefok'
syntax.
Fortunately, a recent change to fuzztest has relaxed this restriction
and now no longer objects if there are extra flags unknown to absl. This
enables us to remove this code.
Bug: 40286211
Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel
Cq-Include-Trybots: luci.chromium.try:linux-libfuzzer-asan-rel
Cq-Include-Trybots: luci.chromium.try:win-libfuzzer-asan-rel
Change-Id: Id02e6a131579c98bacc8263b2ee8c0c84fbc647d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463506
Auto-Submit: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Paul Semel <paulsemel@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417483}
I am putting together changes that will address a subset of these
failures. It will be useful to be able to remove just the failing tests
and see the ones that are left after those changes.
Bug: 389148369
Change-Id: I235e62f18e77adfaa425c63ced7c777ba1ba34f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6243401
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417349}
A test needs to explicitly disable a feature to still succeed when
the feature is enabled by field trial.
Fix a crash in ChromeOS guest mode in settings_ui.cc since it doesn't
have a PasswordChangeService.
Bug: 362225975, 394803563, 394874186
Change-Id: I1391d55519f9edf4ac29a2b3090a70b90404892c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6235266
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417221}
This is a reland of commit b9b854bf90
Original change's description:
> Reapply "Roll protobuf to 29.3"
>
> This reverts commit 7f3d30b9cf
> with fixes for:
> * Chromecast
> * CFI
> * siso
> * a couple other issues fixed separately from this CL
>
> ===========================
> Original issue description:
> ===========================
>
> Roll protobuf to 29.3
>
> * Roll protobuf and write new build targets by hand since the existing
> script no longer works (gen_chromium_file_lists.py)
>
> + Tweaks to upstream listed in README.chromium
>
> * Roll protobuf-javascript to newest version since the existing
> version is incompatible with newer protobuf (and the newest version
> of protobuf-javascript is incompatible with older protobuf, so this
> can't be done separately)
>
> * Roll libprotobuf-mutator to newest version, reasoning: ditto
>
> * Update some Chromium code (other, preparatory updates were possible
> prior to the role as they were compatible with either version of
> protobuf)
>
> * GRPC is *not* rolled but has some minor hacks added to avoid
> referencing non-existent files and symbols. These hacks wouldn't
> stand up to linking, but the relevant code is not actually used.
> GRPC is not rolled because there are seemingly substantial changes
> needed to both its build and its code, some of which are not
> related to protobuf, but the fact that GRPC is months to years out
> of date (depending on what commit we attempt to roll it to). For
> example: use of GCC extensions.
>
> * Protobuf uses absl for logging now and therefore its `LogSilencer`
> is removed. Lots of fuzzers are using `LogSilencer`, but it's not
> clear how crucial that is. `LogSilencer` usage is simply removed
> for now.
>
> NO_IFTTT=upstream code
>
> Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
> No-Presubmit: true
> Bug: 328417294
> Change-Id: Ie27ad5e64ebe6edadebcf40fa869dd7b83cb97fb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6228766
> Owners-Override: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1416848}
Bug: 328417294
Change-Id: Iba40a3c6168631797af2c755c5c29db4c835210a
Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6243314
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Greg Thompson <grt@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417187}
This reverts commit b9b854bf90.
Reason for revert: broke win-presubmit and linux-presubmit "Too large files found in commit"; see https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/24487/overview
Original change's description:
> Reapply "Roll protobuf to 29.3"
>
> This reverts commit 7f3d30b9cf
> with fixes for:
> * Chromecast
> * CFI
> * siso
> * a couple other issues fixed separately from this CL
>
> ===========================
> Original issue description:
> ===========================
>
> Roll protobuf to 29.3
>
> * Roll protobuf and write new build targets by hand since the existing
> script no longer works (gen_chromium_file_lists.py)
>
> + Tweaks to upstream listed in README.chromium
>
> * Roll protobuf-javascript to newest version since the existing
> version is incompatible with newer protobuf (and the newest version
> of protobuf-javascript is incompatible with older protobuf, so this
> can't be done separately)
>
> * Roll libprotobuf-mutator to newest version, reasoning: ditto
>
> * Update some Chromium code (other, preparatory updates were possible
> prior to the role as they were compatible with either version of
> protobuf)
>
> * GRPC is *not* rolled but has some minor hacks added to avoid
> referencing non-existent files and symbols. These hacks wouldn't
> stand up to linking, but the relevant code is not actually used.
> GRPC is not rolled because there are seemingly substantial changes
> needed to both its build and its code, some of which are not
> related to protobuf, but the fact that GRPC is months to years out
> of date (depending on what commit we attempt to roll it to). For
> example: use of GCC extensions.
>
> * Protobuf uses absl for logging now and therefore its `LogSilencer`
> is removed. Lots of fuzzers are using `LogSilencer`, but it's not
> clear how crucial that is. `LogSilencer` usage is simply removed
> for now.
>
> NO_IFTTT=upstream code
>
> Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
> No-Presubmit: true
> Bug: 328417294
> Change-Id: Ie27ad5e64ebe6edadebcf40fa869dd7b83cb97fb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6228766
> Owners-Override: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1416848}
Bug: 328417294
Change-Id: Ie73624e635a90d8a28abaff88bbf3404504ebfbd
Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6242714
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Greg Thompson <grt@chromium.org>
Owners-Override: Greg Thompson <grt@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1417184}
Add explicit "pixels": "4000" to match finch configuration. This
doesn't change any behavior. It's mainly to avoid the finch CL
warning about mismatching finch config.
Bug: 361344221
Change-Id: I4eb1f50af9f51387ca5b0b8de94b8f1deef0ed3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240233
Reviewed-by: Philip Rogers <pdr@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417025}
This CL finishes the conversion of GPU integration test args being
specified through mixins rather than individually on each test.
There are a couple tests where tests have real differences in their
args. Leave these as is since it needs investigation to see if all the
differences are intended.
Bug: 391899126
Change-Id: I8bc0de0d41d093a6e297f62f05032398c5a0682c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6230017
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416960}
This reverts commit 7f3d30b9cf
with fixes for:
* Chromecast
* CFI
* siso
* a couple other issues fixed separately from this CL
===========================
Original issue description:
===========================
Roll protobuf to 29.3
* Roll protobuf and write new build targets by hand since the existing
script no longer works (gen_chromium_file_lists.py)
+ Tweaks to upstream listed in README.chromium
* Roll protobuf-javascript to newest version since the existing
version is incompatible with newer protobuf (and the newest version
of protobuf-javascript is incompatible with older protobuf, so this
can't be done separately)
* Roll libprotobuf-mutator to newest version, reasoning: ditto
* Update some Chromium code (other, preparatory updates were possible
prior to the role as they were compatible with either version of
protobuf)
* GRPC is *not* rolled but has some minor hacks added to avoid
referencing non-existent files and symbols. These hacks wouldn't
stand up to linking, but the relevant code is not actually used.
GRPC is not rolled because there are seemingly substantial changes
needed to both its build and its code, some of which are not
related to protobuf, but the fact that GRPC is months to years out
of date (depending on what commit we attempt to roll it to). For
example: use of GCC extensions.
* Protobuf uses absl for logging now and therefore its `LogSilencer`
is removed. Lots of fuzzers are using `LogSilencer`, but it's not
clear how crucial that is. `LogSilencer` usage is simply removed
for now.
NO_IFTTT=upstream code
Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
No-Presubmit: true
Bug: 328417294
Change-Id: Ie27ad5e64ebe6edadebcf40fa869dd7b83cb97fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6228766
Owners-Override: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416848}
This enables SkiaGraphite in fieldtrial_testing_config.json for Android.
This only causes *some* Android devices to run graphite, namely devices
that were already running Ganesh/Vulkan. This will cause a change on
some bots, such as Pixel 6, Pixel 7 and Samsung S23. Most Android bots
with older hardware will not see any change.
This is expected to cause a regression on Pixel 6 perf bots. The
benchmark stories start with a clear slate and empty shader cache.
Graphite shaders are bigger than Ganesh shaders and take longer to
compile. With graphite there is a significant delay compiling shaders at
the start of each story which negatively impacts metrics. There are real
performance regressions mixed in with this shader compilation delay as
well that will need to be fixed before launch.
Bug: 40945084
Change-Id: Ie1bb22a86f718c24edef2c89c31d6198d18b12ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904349
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416745}
To prepare for an experiment. This time we drop android_webview
because it seems that we need to support socket tags for webview.
Bug: 346835898
Change-Id: I0a60a0336682d89d2ad14cb8ebbb3a249e8ca7da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6204845
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416702}
The origin trial ran from M127 through M134, inclusive. Now that
it has come to an end, this removes the origin trial. It also
removes the about_flags flag to enable/disable mutation events.
A subsequent CL will remove the enterprise policy, which is
still active - therefore, most functionality for mutation events
is still present. This CL also removes an older flag that was
used to pre-test the deprecation, and is no longer needed.
Bug: 40268638,358407357,326507612
Change-Id: I232e972070502bc2415666a83bfed961abc28ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6227019
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416564}
Due to the grammar being translated into protobuf, it is very hard to
keep the protobuf structure stable when the grammar changes. Since the
WebIDL fuzzer and the soon to be IPC fuzzer are automatically generating
their grammar based on the current state of the IDL/IPC definitions, we
need a way to make the corpuses stable. Hashing the lines as proto IDs
allows ensures that if the grammar line doesn't change, the binary
protobuf will be mappable to that line, independently of potential
grammar change not tied to that grammar line.
Change-Id: I8329c746afeaea724debca4e06883ae319fc48ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6234013
Auto-Submit: Paul Semel <paulsemel@chromium.org>
Reviewed-by: Ali Hijazi <ahijazi@chromium.org>
Commit-Queue: Ali Hijazi <ahijazi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416306}
We may revisit this experiment in a different form later in 2025, but
there aren't immediate plans to ship a change to the 100ms threshold.
Removing this code for now to simplify the prioritization logic.
Additionally, this changes the default back to a TimeDelta constexpr and
lifts it to the header -- which puts it near the other threshold and
enables using it in unit tests (also updated in this CL).
Fixed: 40874128
Change-Id: I9129128ddb2accd4c093c76e15633b34d9fd5a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871515
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416274}
