chromium/src
0
Fork 0
Code Activity
1,371,053 Commits 3 Branches 23,233 Tags
be826009dec48265af15f6f4dbc8266a334f4df1
Commit Graph

7 Commits

Author SHA1 Message Date
Avi Drissman
9bf75c5e9a Remove ARC boilerplate in /content 
ARC is now enabled by default, so there’s no need to enforce it
against files being put into non-ARC targets.

Bug: 1468376
Change-Id: If25307bfbea5a1df8937b433dde5fa83871cff74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4738888
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1178112}
 2023-08-01 22:39:26 +00:00
Avi Drissman
7fba3d8bdc Convert content_browsertests to use ARC 
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.

This CL landed earlier as https://crrev.com/c/4622073. This version of
the CL has a fix, more carefully managing the lifetimes of the test
windows.

Bug: 1280317
Change-Id: I6ffe2da3d1c9686f24903c00dcf48d72186b170c
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4650276
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Jayson Adams <shrike@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1163738}
 2023-06-28 20:10:27 +00:00
Justin Huang
ba2970f11c Revert "Convert content_browsertests to use ARC" 
This reverts commit 360b0a82f4.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1458292

Original change's description:
> Convert content_browsertests to use ARC
>
> See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
> for information about this conversion.
>
> This CL landed earlier as https://crrev.com/c/4507593. This had to
> be reverted due to issues with gfx::AcceleratedWidget on iOS.
> This is fixed with https://crrev.com/c/4629669 so this can land.
>
> Bug: 1280317
> Change-Id: Ic7431f06d00e9f7f61d90e40544738d4d9f1fd23
> Include-Ci-Only-Tests: true
> Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
> Cq-Include-Trybots: luci.chrome.try:mac-chrome
> Validate-Test-Flakiness: skip
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622073
> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Jayson Adams <shrike@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1162659}

Bug: 1280317
Change-Id: Ib3e09e352e38b681bfabf6ddac88b56d7bc2cb9a
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Cq-Include-Trybots: luci.chrome.try:mac-chrome
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4649148
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Justin Huang <justinhuang@google.com>
Commit-Queue: Justin Huang <justinhuang@google.com>
Cr-Commit-Position: refs/heads/main@{#1162799}
 2023-06-27 06:25:42 +00:00
Avi Drissman
360b0a82f4 Convert content_browsertests to use ARC 
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.

This CL landed earlier as https://crrev.com/c/4507593. This had to
be reverted due to issues with gfx::AcceleratedWidget on iOS.
This is fixed with https://crrev.com/c/4629669 so this can land.

Bug: 1280317
Change-Id: Ic7431f06d00e9f7f61d90e40544738d4d9f1fd23
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622073
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Jayson Adams <shrike@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1162659}
 2023-06-26 23:04:31 +00:00
Joshua Pawlicki
8d34584fb0 Revert "Convert content_browsertests to use ARC" 
This reverts commit a390f41d21.

Reason for revert: Breaks tests, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/37859/blamelist

Original change's description:
> Convert content_browsertests to use ARC
>
> See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
> for information about this conversion.
>
> Bug: 1280317
> Change-Id: I938b6af7d61b658de3e26812f83bb679bc8a4cdc
> Include-Ci-Only-Tests: true
> Validate-Test-Flakiness: skip
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507593
> Auto-Submit: Avi Drissman <avi@chromium.org>
> Commit-Queue: Jayson Adams <shrike@chromium.org>
> Reviewed-by: Jayson Adams <shrike@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1140162}

Bug: 1280317
Change-Id: I6bb05285735630c129149fa9ba5114ad91cc6ac1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507877
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1140239}
 2023-05-05 18:56:14 +00:00
Avi Drissman
a390f41d21 Convert content_browsertests to use ARC 
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.

Bug: 1280317
Change-Id: I938b6af7d61b658de3e26812f83bb679bc8a4cdc
Include-Ci-Only-Tests: true
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507593
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1140162}
 2023-05-05 16:23:13 +00:00
Dave Tapuska
a47d2063c8 [ios] Fix build failures for content_browsertests 
- While the tests currently do not run due to launcher problems this
gets us closer to a green build bot.
- Add keyboard and pointer lock helpers on iOS
- Explicitly include the window occulusion test on mac as it will
be included in the iOS build if GN filters it based on the suffix.

Bug: 1411704
Change-Id: I244476e824d9c6d01cce0275cb637298f48938d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240383
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103951}
 2023-02-10 18:47:36 +00:00