There are no functional changes, as RASTER is a constant that expands
to RASTER_READ | RASTER_WRITE. This will allow us to subsequently (1)
eliminate RASTER and (2) refine all RASTER_READ | RASTER_WRITE usage
based on where raster reads and writes are actually necessary.
Bug: 1519074
Change-Id: I61a882ad741efb7aeb5afd56347c340c212a4222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5210411
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1248658}
These SharedImages are created as individual planes for a VideoFrame.
They will be read via the raster interface, which is specified as being
OOP-raster. The individual planes would be converted to a single RGB
texture before being read by GLES2 (e.g., if a WebGL codepath is
exercised by this test). Thus, these SIs don't need any GLES2 usage.
Bug: 1512542
Change-Id: I69890242acf93d04550805511194fb5f9f7e1964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185619
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1245922}
which can happen in the case that MDNS is used to obfuscate the
candidate address. Also fix VPN detection and improve comments.
BUG=chromium:1375217
Change-Id: Ic036fa297bf2c309f2c53d086dccff3aa83b7279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5149642
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1241866}
SelectFileDialog::Listener has two variants for each type of
selection. Consolidate each of those two variants into one.
Fixed: 1514382
Low-Coverage-Reason: LARGE_SCALE_REFACTOR This is a refactor of how a specific interface works
Change-Id: I6cf8c2ebb36ba30b351c0108dd7cad848ace9380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5148579
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1241424}
Use the correct command line switch to disable HW-accelerated encoding,
and add the switch early enough.
Also increase the test canvas size above the threshold for
HW-accelerated encoding.
Bug: 1512622
Change-Id: Ibed3f3eb1852f3efe04856b11b43dc42e3796103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5125961
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/main@{#1239057}
We're getting rid of SHARED_IMAGE_USAGE_GLES2 in favor of
SHARED_IMAGE_USAGE_GLES2_READ and SHARED_IMAGE_USAGE_GLES2_WRITE. The
former is currently a constant that is equal to the bitwise-or of the
two latter. This CL replaces usage of the former with the bitwised-or
of the latter in //content.
Bug: 1510440
Change-Id: Idc38226f0fa890430f0ce73aa1bfe4791213f99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5115119
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236265}
This API unshipped in M117 (as in, calling throws an exception), since
then the API has only been available for users of a Deprecation Trial.
That Deprecation Trial ended in M121 so we are now ready to delete all
code associated with legacy getStats() in Chromium.
There are a handful of old tests that are being deleted as part of this
CL because of their dependency on the non-standard API. E.g. I don't
think anyone has been paying attention to the browser perf tests for
years. These days we have more sophisticated testing dashboards
that doesn't rely on chrome://webrtc-internals/ in order to obtain
getStats results (which didn't make much sense to start with if you
ask me).
https://chromestatus.com/feature/4631626228695040
Delete! Delete!
Bug: chromium:822696
Change-Id: I6a1b7337fdf936a82fdac2dab5efd2567a857c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5093107
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234621}
This test was brittle because `MediaDevicesManager` requires some
setup time and the test wasn't providing enough time for the setup to
happen. Adding an enumerate call at the beginning of the test ensures
that everything is set up and ready to go.
Bug: 1126373
Change-Id: I0be57364b8618b7c9d7ac76e848e8aba5ddcba5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5009028
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1221653}
In this part all references under the following folders:
- components/
- content/
- ios/
Also adding ui/webui/PLATFORM_OWNERS as OWNERS for trivial/mechanical
changes in:
- components/commerce/core/internals/resources
- content/browser/webrtc/resources/
Bug: 1497028
Change-Id: I9112fea44301b3082b9043143604ad5949256605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4985632
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217365}
The browser should be using RasterInterface instead of GLES2Interface
for graphics functionality now. Convert a few remaining browser tests
that were using GLES2Interface to use RasterInterface instead.
Bug: 1453633
Change-Id: I276494a1da3e6da8b49464f02dad1fc9c33b77e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4974495
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1215518}
* `FromDoubleT()` -> `FromSecondsSinceUnixEpoch()`
* `ToDoubleT()` -> `InSecondsFSinceUnixEpoch()`
* `FromJsTime()` -> `FromMillisecondsSinceUnixEpoch()`
* `ToJsTime*()` -> `InMillisecondsFSinceUnixEpoch*()`
* `FromJavaTime()` -> `FromMillisecondsSinceUnixEpoch()`
* `ToJavaTime()` -> `InMillisecondsSinceUnixEpoch()`
These are more descriptive of the functionality.
No other changes, aside from typecasting fixes in the following files:
* chrome/browser/ash/arc/fileapi/arc_documents_provider_root.cc
* third_party/blink/renderer/modules/notifications/notification_data.cc
* third_party/blink/renderer/modules/notifications/notification_data_test.cc
Further cleanup will happen separately, since this CL as-is isn't really
reviewable, only stampable.
Bug: none
No-Try: True
Change-Id: I9ba11d4a5ff0692e6060e3aa47327a6dfc37bbe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4956111
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1213083}
Per instruction in select_file_dialog.h, classes that inherit from
SelectFileDialog::Listener should let the SelectFileDialog know about
their destruction via ListenerDestroyed().
Also add more comments in select_file_dialog.h to highlight this
requirement.
Low-Coverage-Reason: OTHER Non-trivial cleanup where existing code lacks coverage.
Change-Id: Ie28c71e5b7df5a9a7b39ace5f2e33d1250293aaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900261
Reviewed-by: Elad Alon <eladalon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1202768}
since these do not change over time. Also clean up suppression of
datachannelid which does not exist and does not follow the ...Identifier
suffix rule and is only available on legacy stats.
BUG=chromium:1375217
Change-Id: I139ca28677e042a6a44aa7243e362f26db04d6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4887030
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200890}
by adding keepRemovedConnections to the URL parameters, i.e.
?keepRemovedConnections
This is useful to see the history in case of tab crashes.
BUG=chromium:416876
Change-Id: I78230bbe094131484e4d64582aeb6466543f293a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876665
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1199452}
which makes them easier to track. Also renames
user_media.js
to
user_media_table.js
which is the name of the class it contains
BUG=chromium:1484453
Change-Id: Ie30f68b4d8c2391405455e95e13eed1ee4e38f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4872837
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1198236}
The issue described in https://crbug.com/1482684 is fixed by updating
the metricName parsing logic in the event that the metric is a computed
one (ending with ']').
This fixes the reported bug (populating invalid metric names as
"(removed)") while still supporting having computed metrics being
removable. Today I don't think we ever remove computed metrics? But if
we did this logic would still work since we are parsing even computed
metric names correctly.
Bug: chromium:1482684
Change-Id: Iddc5c0845b060c7172979617dcfd9d85cc38859a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4866120
Reviewed-by: Philipp Hancke <phancke@microsoft.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1196475}
It is perfectly valid for metrics to change from a defined value to the
undefined value. For example, some encoder implementations report a
scalabilityMode and others do not (scalabilityMode is undefined).
Because webrtc-internals was only updating metrics that had a value
this resulted in what looked like invalid encoder implementation and
scalability mode combinations, causing much confusion.
This CL fixes that problem by taking all previously reported metrics
that are now undefined and changing their obsolete values to
"(removed)".
This CL also ensures that the "Stats graphs" title (containing
information such as scalabilityMode and encoderImplementation) is made
up-to-date.
Bug: 1467461
Change-Id: Ifbe748dad4c9be58d3d178d7dae3c7c2154dfa67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4714889
Reviewed-by: Philipp Hancke <phancke@microsoft.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1174779}
Before CL[1], mac platforms always used zero-copy(GBM) regardless of
commandline switch.
(a) A zero-copy copy is used even when
--disable-video-capture-use-gpu-memory-buffer is provided.
(b) If a switches are not provided, zero-copy is used.
CL[1] implements zero-copy selection based on command-line switches.
After CL[1], Chorme's behavior is changed when launched without any
GBM-related switch. Previously, Chorme used zero-copy (GBM), but now
since no explicit instruction to use GMB is provided, it doesn't use
zero-copy. Refer discussion on [2] for more information.
The Mac and iOS share this implementation, but iOS does not yet
support zero-copy(GBM), so switches are required to select software
path (shared memory) implementation.
In this CL, for mac platform, zero-copy(GBM) is always used unless the
user explicitly asks to disable it.
[1] https://crrev.com/c/4551060
[2] https://crrev.com/c/4551060/3/media/capture/capture_switches.cc
Bug: 1458391
Change-Id: Ia35090b9306fc3c185d15da5b6c2c5e5a534c8a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4653786
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168585}
This is a reland of commit e02efb1c70
with an updated test expectation on the number of data series in the dump.
Original change's description:
> webrtc-internals: export timestamp for statistics in the JSON dump
>
> adding a new entry per stats report like this:
> "AP-timestamp": {
> "startTime": "2023-07-06T10:36:30.299Z",
> "endTime": "2023-07-06T10:36:39.950Z",
> "statsType": "media-playout",
> "values": "[1688639790299,more,values,1688639799950]"
> },
>
> BUG=chromium:1462567
>
> Change-Id: I28411a29619528369c323d06432b00c15b078a5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4668789
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Philipp Hancke <phancke@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1166483}
BUG=chromium:1462567
Change-Id: Id94ef68daab03f8b34bbae901e56a272f93417bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670786
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1167385}
Adding calculators for fecBytesReceived and fecPacketsReceived on inbound-rtp as well RTX stats which was only calculated outbound.
Also reorder the entries in a more logical fashion.
BUG=webrtc:15250,webrtc:15096
Change-Id: Ia0e719cbcd6744afae845460c63146665e06bf51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637885
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1162418}
This patch:
- Uses file includes to remove redundant entries from OWNERS and
DIR_METADATA files.
- Adds myself as a NA time zone OWNER for urgent/routine patches.
- Removes emeritus OWNERS from content/browser/webrtc/OWNERS.
Change-Id: I2a332cb8420915b523ff827d359ea5a83cf0025d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583635
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1154060}
That's because all functions are called from browser process.
For content/renderer/workers, IsOutOfProcessNetworkService() is
used ([1]) to terminate workers if the network service crashes.
However, if the crashed network service is in the browser process,
then the workers are going to get terminated anyway, so introducing
this condition doesn't actually help. Thus we can remove them.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1264139
Bug: 1329834
Change-Id: Iaf3c9847b2231aef9e413481d6bdf53f7e9065ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547630
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Owners-Override: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150766}
which is useful when opening a new webrtc-internals tab with
an already established connection.
This re-emits the state using the following events:
* setLocalDescription
* setRemoteDescription
* signalingstatechange, iceconnectionstatechange, connectionstatechange
BUG=chromium:1320617
Change-Id: I7d4ee468ef4e12b43b7c1eb13ddd9154afd229c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4492439
Reviewed-by: Elad Alon <eladalon@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144560}
