0
Commit Graph

8 Commits

Author SHA1 Message Date
dpapad
468d67cc44 WebUI: Update a few docs, make it clear that CSS Mixins no longer work.
Bug: 1374865
Change-Id: I4d9e6b40360d2405547d1a2bc6e173d8e3e5f647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3971059
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1062396}
2022-10-21 23:06:00 +00:00
dpapad
b6ce7d0584 Update compress="gzip" related documentation to reflect latest behavior.
WebUI Gzip/compression related documentation is quite obsolete and
does not reflect the following (not so recent anymore) changes:

 - compress="gzip" is the default behavior for HTML, JS, CSS and
   SVG files.
 - The UseGzip() C++ method no longer exists (as it is not necessary).

Bug: 1068407
Change-Id: I36be8895abd5b115c07a40d094e52d00efb9d764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290997
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787664}
2020-07-13 08:30:22 +00:00
Dan Beam
a6f790c1ff Change WebUIDataSource::UseGzip() to an exclusion callback (not a list)
This is so callers that need to do dynamic exclusion (print preview) can

R=thestig@chromium.org
BUG=840024

Change-Id: I27e057a79ee91001e8244ae88a2e267a13236308
Reviewed-on: https://chromium-review.googlesource.com/c/1408032
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622912}
2019-01-16 00:17:49 +00:00
dpapad
d0ef1a9772 WebUI cleanup: Rename use_vulcanize GN flag to optimize_webui
Vulcanize tool has been replaced with polymer-bundler. But also several
other optimization tools are invoked when this flag is used
(polymer-css-build, crisper, uglify), therefore the more generic
"optimize_webui" name seems more appropriate. This is addressing an
already existing TODO in the code.

Bug: 731881
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d25b1306141ef01f4d40a0cb9c0b79cccb6837f
Reviewed-on: https://chromium-review.googlesource.com/663215
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502639}
2017-09-18 19:32:12 +00:00
Peter Kasting
cd14904afd Avoid using an unordered set to pass items we're going to iterate over linearly.
This should just be a vector.  While I'm at it, simplify the API using a default
arg.

TBR=avi

Bug: none
Change-Id: Idddc75916904717c7428c5670125f213b2322b6e
Reviewed-on: https://chromium-review.googlesource.com/663773
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501705}
2017-09-13 18:55:21 +00:00
dpapad
1e6a87f5d3 WebUI: Replace vulcanize with polymer-bundler.
Summary of changes needed for the migration:
 - Excluded URLs behavior is different than Vulcanize, need to explicitly list
   all URLs to be excluded (unlike Vulcanize, transitive deps of an excluded
   URL are not implicitly excluded).
 - Excluded URLs need to match exactly, unlike Vulcanize where foo.html would
   match chrome://some-path/foo.html.
 - Input HTML files need to have
   <html><head>...</head><body>...</body></html> tags.
 - A single invocation of poylmer-bundler produces both "basic" and
   "lazy" modules (achieved by using the --shell flag), unlike Vulcanize
   which required two separate invocations.
 - Using new --manifest-out instead of previous --out-request-list flag to
   generate depfiles for Ninja.
 - Using --rewrite-urls-in-templates to preserve previous rewriting behavior.
 - polymer-bundler does not blow up when it can't find a file (unlike Vulcanize,
   so check output manifest for any reported "missing" dependencies).
 - Removed some Windows specific hacks that don't seem necessary anymore.

BUG=731881
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2936333002
Cr-Commit-Position: refs/heads/master@{#488821}
2017-07-22 00:22:25 +00:00
dbeam
d51c79fa34 Remove references to or invocations of vulcanize.py. It's deleted.
Vulcanize now happens dynamically with GN/Ninja. \o/

R=dpapad@chromium.org
BUG=673825
NOTRY=true

Review-Url: https://codereview.chromium.org/2690743003
Cr-Commit-Position: refs/heads/master@{#449875}
2017-02-11 20:58:07 +00:00
dbeam
f02a25aa9e Make vulcanize.md more generic and remove specifics about node modules
Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG=673825
NOTRY=true

Review-Url: https://codereview.chromium.org/2647203002
Cr-Commit-Position: refs/heads/master@{#445594}
2017-01-24 01:58:38 +00:00