chromium/src
0
Fork 0
Code Activity
1,381,226 Commits 3 Branches 23,233 Tags
c12bda144290ac5c776b05fce978ea8d66ea6acd
Commit Graph

147 Commits

Author SHA1 Message Date
Allen Bauer
64d99144d5 Update Metadata docs and comments. 
Bug: 1485768
Change-Id: Id4a4488adf10de728d0278bb66dbd617e038e6c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278430
Reviewed-by: David Yeung <dayeung@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258052}
 2024-02-08 18:45:30 +00:00
Peter Kasting
f4b162eda9 Update docs for removal of SetChildViewIgnoredByLayout(). 
Bug: 1267319
Change-Id: I70d51e91d41844614afdcacaa69b51d81d9ab461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279008
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257952}
 2024-02-08 16:25:48 +00:00
David Yeung
73c594dd41 Add note to UI Dev tool doc about bubble lock. 
Clarify that devtools has to be the active window before attempting bubble lock.

Change-Id: I36798c2ee5a2e318d3f7beb8f76dba05e230ab3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5262384
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255683}
 2024-02-02 18:55:53 +00:00
Peter Kasting
1e3a1e996a Change View::Layout() to take a PassKey. 
This prevents direct access from outside View itself.

Must be landed as a single large CL, or LayoutSuperclass() will not
select the correct method to call.

Bug: 1521108
Change-Id: Id4e0439c048f26e55cc2189aa362e723662d0755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255142}
 2024-02-01 18:10:41 +00:00
Peter Kasting
df36f33ea6 Replace Layout() calls with DeprecatedLayoutImmediately(): docs/ 
Direct access to Layout() is being deprecated. This marks all callsites
for future fixing, and ensures they all go through the common layout
wrapper functions.

Bug: 1521108
Change-Id: I3adff3b9b005329096d2d1fbe960b1bf4b3da076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246255
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1254666}
 2024-01-31 19:21:34 +00:00
Peter Kasting
8e6535e64d Convert superclass Layout() calls to LayoutSuperclass<>(): docs/ 
Direct access to Layout() is being deprecated; this is the blessed way
to invoke it for this use case.

Bug: 1521108
Change-Id: Iae98dea60469f4a8279c5501bf6cb1f3defc594f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5244024
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253606}
 2024-01-29 23:05:39 +00:00
Peter Kasting
a4284caa64 Add LayoutImmediately(). 
This synchronously invokes Layout(). For now, it does nothing else, but
eventually it can do any pre-layout work necessary, e.g. collecting
metrics or setting state/access control variables.

Ultimately, this should become the only way for any code to reach
Layout().

Bug: 1521108
Change-Id: Idd40832c6e5f2d407e970a089d3c2801423922f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243921
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253558}
 2024-01-29 22:30:07 +00:00
Peter Kasting
94c0f2e056 Direct people to use RunScheduledLayout() as the preferred route. 
Calling LayoutRootViewIfNecessary() is fine, just less obvious.

Bug: none
Change-Id: I1ed1f951f616e49bf264da4e6d516c9e75359459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243697
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253372}
 2024-01-29 18:14:20 +00:00
Erik Chen
14380c4a7e update views documentation 
Change-Id: I7bcd3dd09c278628419b0ce7e866ff9dffc336e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5197896
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247739}
 2024-01-16 21:27:52 +00:00
Joseph Park
daba6597cb Update macro name and hyperlink. 
Change-Id: I93ac676d8c7f8f19adbde8cc17c13659ab93bfe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5080387
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Auto-Submit: Joseph Park <josephjoopark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232498}
 2023-12-03 19:19:07 +00:00
Takashi Toyoshima
33928e76dd ui/views/overview.md: update the stale BubbleDialogDelegateView link 
https://crrev.com/c/1171907 introduced bubble_dialog_delegate_view.h.
https://crrev.com/c/1171919 removed bubble_dialog_delegate.h and
recommended to include bubble_dialog_delegate_view.h instead.
So, this document change is a follow-up for these changes.

NOTRY=true

Bug: n/a
Change-Id: I502cb9a29e308f890f332851102277040f616964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5052470
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1229181}
 2023-11-27 06:41:05 +00:00
Elaine Chien
7894271095 [MVC] Edits to mvc developer guide 
Edits to model ownership based off of experiences with real features.

Bug: None
Change-Id: I1b7e6b5d2bd8042a9cc2e67a0a108f46392526e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4998599
Auto-Submit: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219546}
 2023-11-03 17:17:39 +00:00
Sam Maier
b1cb900579 Removing references to fragment_activity_replacer 
Bug: 1485106
Change-Id: I50b0dadefe42d16202938540aa9427881c2a8976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4927148
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207711}
 2023-10-10 16:42:55 +00:00
Sky Malice
430f74338e Linked dynamic colors doc to internal figma color mapping go link. 
Bug: 1224883
Change-Id: I58719fcc1cb99ad6e9dc6bcda62760c44a0e83b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4893402
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1203520}
 2023-09-29 23:07:24 +00:00
Aishwarya Rajesh
ea17bbdc76 [APS] Update tab container visibility and color on tab hover events 
TODO (crbug.com/1469949): Add fade-in animation on the TSR tab container on hover.

Demo: https://drive.google.com/file/d/1tuqrtr-LkzOdiYoVv7ORR8yvIbAuSYyo/view?usp=sharing

Screenshots:

GM2:
Light: https://screenshot.googleplex.com/APnXK87WCC56T8s
Dark: https://screenshot.googleplex.com/48pRov7iwiiRDg5
Incognito: https://screenshot.googleplex.com/3Xp67zZNxbpbzAB

Folio:
Light: https://screenshot.googleplex.com/4xpqG8fZ3gwEBoK
Dark: https://screenshot.googleplex.com/KbYjZph9AQv5E8c
Incognito: https://screenshot.googleplex.com/3Xd3LtjhwM6yjmY

Detached:
Light: https://screenshot.googleplex.com/39vA7ohVPWkMLGu
Dark: https://screenshot.googleplex.com/YAaoz2qf3xZeaw4
Incognito: https://screenshot.googleplex.com/9aE7dgb4tESg8hX

Low-Coverage-Reason: Tests for updates in this CL require execution on a tablet, that is not available in the CQ; adequate test coverage has been added for these changes.
Bug: 1451925
Change-Id: Ied4a403e46669a5b3bc9f95d33fe482919842411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717726
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com>
Reviewed-by: Neil Coronado <nemco@google.com>
Cr-Commit-Position: refs/heads/main@{#1180649}
 2023-08-08 02:11:15 +00:00
Elaine Chien
719e2d8c8b [MVC] Add developer guide to ui/views docs 
Bug: None
Change-Id: I3643337f306da49eb1d53a1f10199ffb7e8700d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721955
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1176167}
 2023-07-27 18:00:19 +00:00
Avi Drissman
a127340f6c Simplify lifetime reasoning of AppController: it's a singleton 
Make AppController be a singleton and to always be the
NSApp delegate. This simplifies reasoning about the code.

Bug: 1280317
Change-Id: Iebddee9077c9ec4f786a3e3307a10e812a187457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566530
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1149854}
 2023-05-26 19:17:43 +00:00
Joseph Park
528bc048a7 Update documentation involving deprecated GetSystemColor() 
Change-Id: I1c760b52d6029066d20262d7160eb41b294e601f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4518506
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Joseph Park <josephjoopark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1142287}
 2023-05-10 19:22:31 +00:00
Henrique Nakashima
485c8acf53 [Android] Replace LocalRobolectricTestRunner with RobolectricTestRunner 
LocalRobolectricTestRunner is just RobolectricTestRunner, so remove
that layer of inheritance. This prevents tests from using it instead of
BaseRobolectricTestRunner, which Clank tests should be using.

The Clank tests that were using LocalRobolectricTestRunner have been
migrated in past CLs.

The exceptions that shouldn't depend on base/ realistically won't need
common functionality, and even then we could use test rules.

Also update references to Local- in docs and DEPS exceptions that are not
needed anymore.

Bug: 1431327
Change-Id: I52b43058fe30c9004f2a3c90892683761805247c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4450326
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1134023}
 2023-04-21 20:38:25 +00:00
James Feister
b756267d24 Update doc for debug tools flag 
Bug: None
Change-Id: If39f2b9cffe0acfc2eccfd2b443733faa8f874d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420113
Reviewed-by: Zork <zork@chromium.org>
Commit-Queue: Zork <zork@chromium.org>
Auto-Submit: James Feister <jamesfeister@google.com>
Cr-Commit-Position: refs/heads/main@{#1129493}
 2023-04-12 21:19:05 +00:00
David Yeung
3bd204d0fa [views-examples] Improve views-example documentation 
Added links to each button example
Added gif to showcase the exe
Improved the general layout

Change-Id: I33978b25715b7aaf3784763739f18dc2fb43849a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288226
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109874}
 2023-02-24 23:17:37 +00:00
Peter Kasting
b4470df57c Improve contrast with pervasive system accent colors. 
This attempts to guarantee color visibility/readability in many more
scenarios. To do this, PickGoogleColorTwoBackgrounds() is moved to ui::.

Bug: 1413984
Change-Id: Idd8842449848cf3989996ead099e9cfad3d41f3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4283758
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1108711}
 2023-02-23 01:25:59 +00:00
Peter Kasting
198b59fc95 Add "starter guide" for those new to UI development. 
Bug: none
Change-Id: Ia5303c532cf90f4ffc4e45239ee0776dd7383bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4124329
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106385}
 2023-02-16 19:50:04 +00:00
David Yeung
f0d81e3b76 [Render text] Added variation selector to doc + fixed incorrect unicode 
Added a bit on variation selector codepoints and fixed an incorrect codepoint in the airplane example

Change-Id: I849ad13b4408c8e3f2a0ff60aebe697ae8e30d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220143
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1101802}
 2023-02-06 21:54:16 +00:00
Elaine Chien
e1bda98709 [RenderText] Add documentation for overview of RenderText implementation 
Bug: None
Change-Id: I471e114f822f6a367508998bf798a201bebcf94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113163
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096417}
 2023-01-24 22:13:06 +00:00
David Yeung
63470481ba [RenderText Doc]: Unicode overview 
Adding documentation on how Unicode works wrt text rendering

Change-Id: I197b8272b91b21fd753dc47295f006b8da28438f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098976
Commit-Queue: David Yeung <dayeung@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096253}
 2023-01-24 17:49:32 +00:00
Avi Drissman
bb9cd02c17 Update header includes for /base/functional in /d*, /e*, /f* 
bind.h, callback.h, callback_forward.h, and callback_helpers.h
moved into /base/functional/. Update the include paths to
directly include them in their new location.

Bug: 1364441
Change-Id: I6ce44f5813ff87215cb0df1d13bb649885a54c6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4152775
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091122}
 2023-01-11 01:03:29 +00:00
David Yeung
564b73be07 [views] Added more terms to glossary 
Change-Id: If645e852917da9ca3dbd2c0a6e78111b28bdf30b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4123011
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1087607}
 2022-12-29 17:38:49 +00:00
Peter Kasting
cf344829eb Skeleton of a UI glossary. 
Bug: none
Change-Id: I430c1ac40021adf6d0cd05b4a61bbc65b4d22482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113989
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1086164}
 2022-12-22 00:23:55 +00:00
Peter Kasting
0c5225dcaf Fix broken link. 
Bug: none
Change-Id: I422dc08ecf06282e7136d435fcc919ccdb1c740f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114463
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1085039}
 2022-12-19 19:22:28 +00:00
Elaine Chien
64fbae6c9a Add initial folder for Render Text docs and alphabetize 
Bug: None
Change-Id: I4dd4530b4fcf41ab9cc102749b299a8802b5b3ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112848
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084470}
 2022-12-16 19:45:26 +00:00
Keren Zhu
5f2e01b647 views: Add doc about Widget destruction 
slides (for easier commenting):
https://docs.google.com/presentation/d/14aFNW5DPQey0Mmr6cgg_KABWwr_-SoMHToU3JYmJ6SI/edit?usp=sharing&resourcekey=0-xqJAbv7729LfgEk5QNa8TA

Bug: None
Change-Id: I752ea7e516d8cd12f9e356881e8b377c5623f39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4103544
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1083168}
 2022-12-14 17:28:38 +00:00
Wissem Gamra
755f4b15e7 Update dynamic colors doc to reflect minimum APK being no longer 23. 
default is 24 right now: https://source.chromium.org/chromium/chromium/src/+/main:build/config/android/config.gni;drc=a297b4db5e286f3e32cad79c92b3e6ccb30516a4;l=46

Change-Id: If344ce2744c686ef7f35d982d21ef948715725f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4090311
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Wissem Gamra <wiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1081227}
 2022-12-09 00:04:28 +00:00
Tom Sepez
3fb6555a8f Fix typo in docs/ui/learn/bestpractices/{layout,ownership}.md 
Missing a '>' to close the template in one place in each file.

Change-Id: I6eec1c8d469f8dc8bf350b17b5018e0e4970887a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4072348
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078282}
 2022-12-01 21:33:49 +00:00
Sky Malice
0b2dcb4c21 Adjust dynamic colors doc for Surface-0 simplification. 
Change-Id: I62b3521f1c8eb2fead40da53cb0f0175444be2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3877120
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1044113}
 2022-09-07 19:09:35 +00:00
Avi Drissman
7b017a99d8 Update copyright headers in docs/ and styleguide/ 
No-Try: true
Bug: 1098010
Change-Id: Id44652c3572c46c4ec732b69473fb951749d35eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3878321
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1043985}
 2022-09-07 15:50:38 +00:00
Mike Frysinger
e69fa05666 drop "All rights reserved" from examples 
OSS licensing has asked us to remove this from new file headers.

Change-Id: I89121dd167aa88617ce2090f8684148bbbac90ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792556
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1031130}
 2022-08-03 18:40:53 +00:00
Elaine Chien
eb7088a657 Update animation docs with OnAborted caveat 
Bug: None
Change-Id: Id14b44aa0abb060a9aa1c21a12fc7f18612a0c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795742
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1030332}
 2022-08-02 00:15:54 +00:00
Elaine Chien
9ee33317e0 Add callback usage notes to animation builder docs 
Bug: None
Change-Id: I887869172988083761fcf0365170c9fa5bbd4630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3790203
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1029211}
 2022-07-28 13:04:31 +00:00
Alison Gale
0d53dc824d Update views example documentation to account for namespaces and spacing. 
Code samples at the end were missing namespaces and there was inconsistencies
in how symbols were referenced. This also fixed a spacing issue, sorted two
imports, and fixed a few types.

Change-Id: Iee837396cb5ff8195f4d3eb844cd7e2ab917454d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3763613
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1024799}
 2022-07-15 17:03:17 +00:00
Adem Derinel
9f6160b9b6 Fix links in Simple RecyclerView use in MVC tutorial 
Parenthesis were causing URLs to be invalid

Change-Id: I10c8545973f6f75683c52b0b19bc6e8b865c0ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3683418
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Adem Derinel <derinel@google.com>
Cr-Commit-Position: refs/heads/main@{#1009518}
 2022-06-01 10:04:00 +00:00
Ted Choc
a21201e4f4 Migrate Chrome Android MVC Overview to markdown from internal doc. 
BUG=

Change-Id: I3a95c44bddef9096d952ee5b5ed80738d67cdcad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3586381
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#992832}
 2022-04-15 03:23:09 +00:00
Sinan Sahin
8265050111 [GMNext] Add dynamic color documentation 
Bug: 1224883
Change-Id: I76073fc27150827f1f2c068b255ab14970022580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3573051
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#990014}
 2022-04-07 18:00:21 +00:00
Gabriel Charette
1f57c9b8ae Migrate remaining odd callers of base::PostTask/Create*TaskRunner in /docs 
Most callers were already migrated via scripts, this is a split
of the remaining callers or comment-references that weren't caught
by those scripts.

@QA: This CL is a logical no-op.

This CL was uploaded by git cl split.

R=estaab@chromium.org

Bug: 1026641
Change-Id: Ie08915968b50da8c04cc9b206cc6a2beaec11901
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3531170
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981891}
 2022-03-16 22:54:34 +00:00
Allen Bauer
f6e2362e88 Update color best pratices to change from a View to a rooted entity. 
Added best practices examples for MacOS and WebUI.

Bug: <None>
Change-Id: I2b1caad103273d2e17380a0427431f561f825d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3457382
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970705}
 2022-02-14 18:13:03 +00:00
Mark Schillaci
e1d37e70e9 Rename DummyUiActivity to BlankUiTestActivity 
This CL renames the DummyUiActivity class to BlankUiTestActivity.

Per Google's documentation and style guidelines, the words "dummy" and
"dumb down" should be avoided. For this reason we are replacing the
DummyUiActivity with the more appropriately named BlankUiTestActivity.
We also make the following renames:

DummyUiActivityTestRule -> BlankUiTestActivityTestRule
DummySettingsForTest -> PlaceholderSettingsForTest

This CL also makes updates to comments and method names where needed
to match these changes.

Bug: 1295312
Change-Id: Ib712a292e0dcee32a97e9d7c487af2fb920f5084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445111
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#969056}
 2022-02-09 19:43:54 +00:00
Maksim Sisov
6c96ed0a06 ozone/x11: update link in the input event docs. 
Bug: None
Change-Id: Ifbf63bf23d587395a312e014ec76b1b9989cdecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3416870
Auto-Submit: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Alexander Dunaev <adunaev@igalia.com>
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/main@{#963427}
 2022-01-26 08:33:48 +00:00
Xiaohan Wang
0727d88b16 docs: Use BUILDFLAG for OS checking 
Use BUILDFLAG(IS_XXX) instead of defined(OS_XXX).

R=thakis@chromium.org

Bug: 1234043
Test: No functionality change
Change-Id: Ib3b75c6ef2af6b681367b6b41f8b9095ed7aef01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405220
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#961767}
 2022-01-21 03:03:43 +00:00
Nick Yamane
fd6fb40b16 fix x11_window.cc ref in input events docs 
Bug: None
Change-Id: I830c4bf2e947e002b50565306effb66c9b02bac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340527
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952000}
 2021-12-15 17:56:40 +00:00
James Cook
aec0504c09 docs: Add views_examples to animation builder docs 
Add a note that you can see the example animation by running views_examples.

Bug: none
Change-Id: I5224c4d607d55f3f1976a1143fcd548897535aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3251492
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935980}
 2021-10-28 17:53:08 +00:00