0
Commit Graph

116967 Commits

Author SHA1 Message Date
4c3aa4744f Dedup TestPrefetchService
Three of `TestPrefetchService` overriding `PrefetchUrl()` are mostly the
same and thus merged into one.

The other one in `prefetch_url_loader_interceptor_unittest.cc` is
different and is renamed to `TestPrefetchServiceForInterceptor`.

Bug: 400761083
Change-Id: I1ed8813f1fa8df3615717bb1a04fa2335bab9805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6337367
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Auto-Submit: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432543}
2025-03-13 22:13:49 -07:00
055871f28b [ServiceWorker+Prefetch] Plumb ServiceWorkerClient with RequestHandler
For the ServiceWorker-controlled prefetches, `ServiceWorkerClient` is
also a part of prefetched result (as the prefetch record's request's
reserved client).

This CL is plumbing only and doesn't change the behavior (especially
with the flag disabled, where the returned `ServiceWorkerClient` is
always null).

Bug: 40947546
Change-Id: Id96d5e2d0a08151e2d6f28a6f481091187ae156a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250403
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432522}
2025-03-13 20:27:38 -07:00
0830e186b2 [ServiceWorker+Prefetch] Implement prefetching side
This CL implements (behind the flag) prefetching of
ServiceWorker-controlled pages.

At this time, prefetches for ServiceWorker-controlled pages are done but
served incorrectly (e.g. not used because navigations are intercepted by
ServiceWorkerMainResourceLoaderInterceptor first), but for now this
should be OK because it's only behind the flag. WPT expectations are
updated because prefetch requests reach the server.

The upcoming CL
https://chromium-review.googlesource.com/c/chromium/src/+/6021277 will
soon implement/fix the serving side and tests.

Design doc:
https://docs.google.com/document/d/1kbs8YJuh93F_K6JqW84YSsjVWcAeU41Mj9nwPr6IXRs/edit?tab=t.0#heading=h.9fuqzdmgb6kv

Bug: 40947546
Change-Id: I6456431dd7f445acf23a2231c727ab41992f705c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6228199
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432506}
2025-03-13 19:03:06 -07:00
c6b35725d2 Reland "[a11y] Fixes move by format for CSS spellcheck highlights"
This is a reland of commit c6bfb8a155

Nothing changed from the original CL -- we reland the same change we did
originally. The reason for this change of mind is that we have found the
fix to the bug that prompted us to revert the change, and we intend to
land that (very scoped) fix in a separate CL we can then cherry-pick
directly to release branches.

Original change's description:
> [a11y] Fixes move by format for CSS spellcheck highlights
>
> Uses Spelling/Grammar error CSS highlight markers in the
> Accessibility Tree to break format boundaries around those
> errors to help navigate better around these spelling/grammar
> errors.
>
> This CL achieves following:
> 1) Fixes Move by format to accommodate CSS spellcheck highlights.
> 2) Narrator calls out the spelling issues correctly.
>
> Bug: 364795299
> Change-Id: I4842a49449c666100e31f859447f951e9f9eb09e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6178990
> Auto-Submit: Vinay Singh <vinaysingh@microsoft.com>
> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1415710}

Bug: 364795299
Change-Id: I561aa47ece506a7077d2b7ef08c4ca6a74662a10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354023
Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1432488}
2025-03-13 18:02:10 -07:00
207bad305a Introduce net::IOBuffer::first() convenience method
Follow-on from suggestion in an earlier Cl about avoiding calls
to span() followed by first(), a very common pattern.

Change-Id: I9564fe1bb93d7065ed638943e1374bd02706ea24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6345073
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432487}
2025-03-13 18:01:09 -07:00
0cc9782786 [ServiceWorker+Prefetch] Add feature flag and virtual tests
Right now the behavior is the same as
virtual/prerender2-fallback-prefetch-spec-rules-prefetch
and upcoming CLs will change the behavior under
virtual/prefetch-serviceworker.

Bug: 40947546
Change-Id: Ic9cff5a6a3df09ec675433f1c239c0c58b4f3132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6227918
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432484}
2025-03-13 17:58:44 -07:00
60269f65f0 Fix inconsistency with CSS system colors Field and FieldText
This CL addresses an issue with CSS system colors where the values of
`Field` and `FieldText` were shared with `Canvas` and `CanvasText`
respectively. This occurred after switching to retrieve system colors
from color providers instead of the NativeTheme in Blink
(http://crrev.com/c/5322440).

Previously, for Windows, `Field` and `FieldText` were retrieved using
the NativeTheme in light mode and forced colors mode, sharing the same
colors as `Canvas` and `CanvasText`. However, for Dark mode on Windows
and non-forced colors scenarios for other OSs, we used
`LayoutTheme::DefaultSystemColor()`, which treated these colors
separately.

To fix this discrepancy, new color ids have been added to the color
pipeline for these system colors, allowing them to share the same colors
when appropriate and have distinct colors when necessary.

Bug: 400746852
Change-Id: I47f7c8dd56bbd66bdde04c70847a5274cc431cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349557
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1432463}
2025-03-13 17:18:07 -07:00
84e05386c3 Update estade@chromium.org to new/active account
Most OWNERS entries are updated from estade@chromium.org to
evanstade@microsoft.com. These accounts are both owned by the same
human.  Committer affiliations are also updated in Blink (although
evanstade@microsoft.com is expected to be the only active account
going forward).

Change-Id: If047d2df9fb7d2b352ac6ce74017949331aa5c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6348619
Owners-Override: Rick Byers <rbyers@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Evan Stade <evanstade@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1432449}
2025-03-13 16:42:46 -07:00
4b726b369c [ios blink] Resign first responder on url entry
Close the keyboard when we follow a location from the url
entry field.

Change-Id: I084b58c3595a2d0a92e35f4629aa0e160fad4909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354324
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432420}
2025-03-13 15:41:22 -07:00
2197b668be Remove file-wide unsafe buffer suppression from content/ [3 of N]
-- Several files are already clean as either via previous changes or
   improvements to the compiler.

Bug: 342213636
Change-Id: I41b3d725dd75d6bbafa4e5fa9338e7d69b7673aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6341711
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432391}
2025-03-13 14:53:59 -07:00
7164360554 Shared Storage: Partial refactor of event params static creators
We refactor several of the static creator methods for
SharedStorageEventParams in preparation for adding several new members
to the class.

Bug: 401011862
Change-Id: Idfafcccce0f8ecd3d530e3223fc0036b79efd654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351803
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432387}
2025-03-13 14:48:10 -07:00
a63af5bc9c [CSC] Ensure forwardWheel() triggers the CSC indicator
The Captured Surface Control indicator in the tab-sharing infobar should
trigger for all write-actions. In the past, sendWheel() was the only
gesture-related action; now forwardWheel() replaces it, and it should
also trigger the indicator even before the user actually scrolls.

Bug: 402532195
Change-Id: I1c4f66d3f20a49e9364081e7e2ec21433b328c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347522
Auto-Submit: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432375}
2025-03-13 14:24:58 -07:00
04f5ab713b clickiness: Add ViewAndClickEvents table and read + write logic
This just adds basic functionality and doesn't include things like
full compaction support, expiration, manual clearing logic, etc., as
those will come in subsequent CLs.

The mojom type that will eventually be passed to the worklet process is
defined, but the plumbing to actually pass values to the worklet process
will come in a future CL.

Bug: 394108643
Change-Id: If7948579a78c909c0bd372ac4e5751cb8a86549d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6256880
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432359}
2025-03-13 14:05:34 -07:00
7861236c71 WebSQL: Remove WebSQL everywhere
WebSQL has been deprecated and removed from WebView in M133,
and M119 on all other platforms. This change updates
RuntimeEnabledFeatures to remove the feature from everywhere.

Chromestatus: https://chromestatus.com/feature/5134293578285056
I2D&R: https://groups.google.com/a/chromium.org/g/blink-dev/c/fWYb6evVA-w/m/pziWcvboAgAJ

Bug: 395838064
Change-Id: Ic5840a5372cd26559b6ec385eef4f2f610343487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318423
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432355}
2025-03-13 14:02:01 -07:00
34d4865e1d Call GetPrefetchCompleteCallbackForTesting() before loader_callback_
`loader_callback_` can resume navigation which can reentrantly call
PrefetchURLLoaderInterceptor::OnGetPrefetchComplete() on another
`PrefetchURLLoaderInterceptor` object, at least after
https://chromium-review.googlesource.com/c/chromium/src/+/6021277.

In order to call `GetPrefetchCompleteCallbackForTesting()` in the
correct order (i.e. the order of `OnGetPrefetchComplete()` calls), this
CL moves `GetPrefetchCompleteCallbackForTesting()` before
`loader_callback_`.

Bug: 40947546
Change-Id: Ic9b7d3aeb0d2bb2b63225862c094061b48d9a4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347576
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432331}
2025-03-13 13:31:44 -07:00
ce728e4a96 Cleanup prefetch feature params in tests that no longer exist
The following `kPrefetchUseContentRefactor` params no longer exist and
thus are removed:

- block_until_head_eager_prefetch
- block_until_head_moderate_prefetch
- block_until_head_conservative_prefetch
- use_streaming_url_loader

Some no-op lines (e.g. enabling `kPrefetchUseContentRefactor` with no
parameters) are removed.

`ExemptSpeculationRulesHeaderFromCSP` is removed from
`VirtualTestSuites` because it is enabled by default.

Tests with identical features after the removal are merged:

- `virtual/prefetch-no-vary-search` -> `virtual/prefetch`.
- `PrefetchServiceStreamingURLLoaderTest`
  -> `PrefetchServiceTest`
- `PrefetchServiceAllowRedirectsAndAlwaysBlockUntilHeadTest`
  -> `PrefetchServiceTest`
- `PrefetchServiceAlwaysBlockUntilHeadWithTimeoutTest`
  -> `PrefetchServiceAlwaysBlockUntilHeadTest`

`PrefetchServiceNeverBlockUntilHeadTest.HeadNotReceived` is removed
because the `{"block_until_head_eager_prefetch", "false"}` param etc.
are actually no-op and navigation is actually blocked-until-head but
timed out, which is already covered by
PrefetchServiceAlwaysBlockUntilHeadWithTimeoutTest.
BlockUntilHeadTimedout.

Bug: 403138272, 40947546
Change-Id: I75ea7738307bdd616fe60b4508d0c08e847888ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6343622
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432329}
2025-03-13 13:29:10 -07:00
84a6cefea9 [FedCM] Record whether RP is calling FedCM on a page with a path
This should give us insight into whether for an RP, FedCM is called on
their homepage (which we assume doesn't have a path).

UKM collection review
https://docs.google.com/document/d/1iwS4WAL9x6nA9cR4y1hwVP0WcYTkGMtIJMvpJE5ARF0/edit?usp=sharing

Bug: 401072314
Change-Id: Ifb3dcf34833a9215c14129b5e3f17933d5947dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330179
Reviewed-by: Sun Yueru <yrsun@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432318}
2025-03-13 13:08:02 -07:00
9bdabf6587 Rebaseline form controls tests
These tests were updated after https://crrev.com/c/6328778
landed and were outside the existing fuzzy match parameters.
I have updated the baseline images.

Bug: b:403163171
Change-Id: I402b37b5435e3cfe7beafa9919b6a3986915554b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351054
Auto-Submit: Kaylee Lubick <kjlubick@chromium.org>
Commit-Queue: Kaylee Lubick <kjlubick@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432317}
2025-03-13 13:06:28 -07:00
e957ae4d84 Translator: Ensure that all progress updates are normalized correctly
This update ensures that a progress updates are normalized to zero
and 1 rounded to the nearest 0x10000th will.

Instead of updating OnDownloadProgressUpdate to a single double and
assuming that it is normalized properly, this ensures that it is
normalized properly by forcing the caller to pass it's total as
0x10000. This forces the caller to be aware that it should be normalized
to 0x10000.

Bug: 391715395
Change-Id: I3c25b7a737b9077d597c9f1d003471299858ced7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300721
Reviewed-by: Christine Hollingsworth <christinesm@chromium.org>
Commit-Queue: Nathan Memmott <memmott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432316}
2025-03-13 13:06:15 -07:00
0347f013fe Javaless renderer: remove native->java logging
This has been on canary long enough that I think I have pretty high
confidence that we've captured all meaningful exisiting Java uses.

I've put the list of uses in go/renderer-java-uses

This reverts commit c3fc8848ef.

Bug: 403265579
Change-Id: Ia2fb822b26cd1f8e59a90a25e25b2ce518ac7c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6353237
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Owners-Override: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432314}
2025-03-13 13:03:19 -07:00
5662c56494 Shared Storage: Assign ID to each worklet host for DevTools
At construction, we assign a monotonically increasing ID to each
SharedStorageWorkletHost, which will be reported to DevTools for
each worklet event.

The current CL only partially plumbs the worklet ID to DevTools by
setting it in the event params for addModule, createWorklet, run, and
selectURL.

Followups will have to send the ID for the remaining worklet events,
as well as update the DevTools protocol and forward to the DevTools
frontend.

Bug: 401011862
Change-Id: I554d3c2ac3b6ce9f239dddcebe71a7b52359517f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6348125
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432308}
2025-03-13 12:56:33 -07:00
5ed862b107 Set credentials_mode to kOmit in WebAuthRequestSecurityChecker::RemoteValidation::Create
The network traffic annotation suggests the intent here is to
not include cookies in requests. However, the ResourcRequest's
credentials_mode is still kInclude.

If this is intentional, let me know and I will not change
credentials_mode, but we should also probably add a comment
to avoid future confusion.

Bug: 402803381
Change-Id: I657e8bb323827b95b18396340dc68cedf658af5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351143
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1432305}
2025-03-13 12:52:29 -07:00
b2255e8e91 [A11yPerformance] Move AXModeObserver
From a grt@'s review comment in CL:6336932 where we were creating ui/accessibility/assistive_tech.h:

"i don't think //ui/accessibility is the right place for this (nor for ax_mode_observer.h -- it belongs in //ui/accessibility/platform since it's part of the browser-side platform integration, not part of the codebase shared with blink/renderers).
how do you feel about moving this and the observer into //ui/accessibility/platform?"

Bug: none
Change-Id: Ie284ff3b3ccb7d0bc714da222b1054e3f8ae0d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351802
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432302}
2025-03-13 12:47:45 -07:00
4cec59ba64 Mark TraceTest_ViewTransitionsCapture Slow
We removed Graphite from Windows Arm. Since then this test has begun timing out on some builds. Marking as slow

Bug: 371949935
Change-Id: Ibfb2fdca07d434bc2d8ca3629be7842cb5d89a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6353064
Auto-Submit: Jonathan Ross <jonross@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1432299}
2025-03-13 12:45:20 -07:00
706c80481e Refactor: Introduce PrefetchResponseReader::load_state()
To clarify read-only/write accesses to `load_state_`.

Bug: 400761083
Change-Id: I8d0da96de04abfcc1efbbeafdc646433276370d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335681
Reviewed-by: Ken Okada <kenoss@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432288}
2025-03-13 12:18:42 -07:00
33d92a0a17 Refactor: Introduce PrefetchResponseReader::EventCallback
Bug: 400761083
Change-Id: I4188da559d84a999d5e13cc957cededb8395ffb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336797
Reviewed-by: Ken Okada <kenoss@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432278}
2025-03-13 12:07:58 -07:00
496fc9b80e [ServiceWorker+Prefetch] Introduce ServiceWorkerClient for prefetch
This CL supports ServiceWorkerClient creation for prefetching requests,
where `FrameTreeNodeId` is not associated.

This is a mostly comment-only change that annotates how
`ServiceWorkerClient` for prefetch works, and leaves TODOs for future
fix.

Bug: 40947546
Change-Id: Ic774ae636436a87bf398a5554f4aff4f34ac4c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6217142
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Reviewed-by: Keita Suzuki <suzukikeita@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Ken Okada <kenoss@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432275}
2025-03-13 12:00:50 -07:00
d3b0d8da1f Remove file-wide unsafe buffer suppression from content/ [7 of N]
Bug: 342213636
Change-Id: Ie87253a13b7a9412782c86f79ad5b3318c8b876e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6344995
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432249}
2025-03-13 11:16:28 -07:00
00e78b454c Avoid transient std::string construction when deserializing GURL from database
GURL lacks a single-argument constructor accepting a std::string;
rather, it accepts a std::string_view, so there is no need to create a
temporary string; sql::Statement::ColumnStringView can be used instead.

Bug: 403218784
Change-Id: I899cee54e4eb35ff6efaedb18152cdacf9d308a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351720
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432241}
2025-03-13 11:07:51 -07:00
00b8ba5378 Add test case StartAndStopLoading for BackForwardCacheBrowserTest.
This case checks DidStartLoading and DidStopLoading will be invoked when
navigating back or forward. Also add the related observer classes for
StartAndStopLoading.

Bug: 40647940
Change-Id: I7f46222c735c62248ac40f8bd893e1a0cb1730ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336721
Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com>
Commit-Queue: Eain Chen <eainchen@microsoft.com>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432223}
2025-03-13 10:47:07 -07:00
0b4c83cb84 Mark Pixel_2DCanvasWebGL Slow
This test is now consistently timing out on the Mac Intel ASAN bot

Bug: 403252788
Change-Id: Ib8a11bd2bf26829ccf9ad1fa666df32c8635b4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351800
Auto-Submit: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1432211}
2025-03-13 10:31:06 -07:00
1f19c23b45 Set RFH token in clipboard only after writing other data
See crbug.com/401379144 for an explanation of the fix and fix.

Bug: 401379144
Change-Id: I6df206c6b0e3e64bc6c8c654f0ecfe357f64ee7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6337392
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432185}
2025-03-13 09:59:10 -07:00
aef69ee52d IndexedDB: Fix flakiness in NotifyIndexedDB related tests
This change addresses the flakiness in the tests caused by improper
initialization of BucketLocator.

Key Points:

The expected count for various assertions of notify_list_changed_count
has been decreased. This adjustment is necessary because there are two
definitions in indexed_db_context_impl.cc that call
OnIndexedDBListChanged internally (OnFilesWritten and
DidForceCloseForDeleteBucketData).

When OnFilesWritten is called, incrementing the
notify_list_changed_count for each observer. During the Teardown phase
of IndexedDBTest, all observers are cleared.

Consequently, when DidForceCloseForDeleteBucketData is called, no
observers remain to trigger OnIndexedDBListChanged and increment the
count. Therefore, the expected count has been decreased in the new
implementation.

Bug: 41348374, 324111895
Change-Id: Idac145cfe04a79434b9e5d541511aaeb97386e0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6275787
Auto-Submit: Garima Chadha <garimachadha@microsoft.com>
Commit-Queue: Abhishek Shanthkumar <abhishek.shanthkumar@microsoft.com>
Reviewed-by: Steve Becker <stevebe@microsoft.com>
Reviewed-by: Abhishek Shanthkumar <abhishek.shanthkumar@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1432173}
2025-03-13 09:44:28 -07:00
32bee7a740 Cleanup canonical_cookie.h includes
Also for net/cookies/cookie_monster.h,
net/cookies/cookie_partition_key.h and
services/network/restricted_cookie_manager.h

Removed unused includes, added forward declarations where possible.

Saves 150MB of compile size, according to the compile-size bot.

Bug: 40318405
Change-Id: I88ab337c0c660894a7f0a662d3d67b00e3bd1984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349077
Auto-Submit: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432148}
2025-03-13 09:03:11 -07:00
6da2f3ce5e Reland "Enable accent color testing on MacOS"
This is a reland of commit 0996144caf

Changes:
* move accent color tests from chrome/browser to content/browser
* add accent color for Mac OS

Notes:
The implementation of Accent Color on Mac OS is mainly in
content/browser/*. To ensure the maintainability of future tests,
I have also relocated the Windows/ChromeOS tests to
content/browser/* and consolidated the code accordingly.

Original change's description:
> Enable accent color testing on MacOS
>
> I have verified on main that Accent Color related features
> are now working correctly on Mac, thanks to Priya's series
> of CLs:CL:5763388,CL:5785551,CL:5789206,CL:5793044,CL:5766135,
> CL:5909355 and Joey's CL:4523388.
>
> Bug: 40229450
> Change-Id: Ib51c4bdfc35e5f3bffbc2751198c8be03e5bfce4
> Reviewed-on: CL:6170547
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com>
> Reviewed-by: Alison Maher <almaher@microsoft.com>
> Commit-Queue: Huiting Chen <huitingchen@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1409428}

Bug: 40229450
Change-Id: I63b0202d750d31e93d78d171e15f9565208dc590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6265044
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Huiting Chen <huitingchen@microsoft.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1432136}
2025-03-13 08:47:02 -07:00
f562b92ae0 Fix zoom for PdfOopif
This CL updates the zoom system to enable PdfOopif PDFs to zoom
properly, i.e. to replicate the zooming behavior of PDFs rendered
with MimeHandlerViewGuest.

When a PDF is viewed, the viewer's UI should not be affected by
the default browser zoom, nor should it change size if the user
changes either the default browser zoom or the zoom of the page
displaying the PDF.

If the PDF is viewed in the mainframe, this involves (i) setting
the zoom mode of the main frame to manual (to prevent changes to
the page's zoom being persisted in the HostZoomMap under the url
of the PDF's content), and (ii) setting the scheme+host zoom level
for the PDF extension to be zoom factor 1.0 (zoom level 0). This
second step is what allows the UI to be rendered at a consistent
size regardless of the page's zoom.

If the PDF is is embedded in a page, only step (ii) is necessary,
as changes to the page's zoom will be persisted under the main
frame's URL.

In both cases, the PDF extension monitors the page's zoom level
so it can be applied to the content without applying it to the
viewer's UI.

There are two major changes involved in this CL:

1) The PdfViewerStreamManager is modified to a) set up a separate
   ZoomController for the RenderFrameHost that contains the Pdf
   extension (this will allow the PDF viewer's frame to keep its
   zoom factor at a different level than the page zoom), and b) a
   call to HostZoomMap to set the desired (independent) zoom factor
   for the PDF extension frame at 1.0.

2) Modifications to WebContentsImpl::GetPendingZoomLevel() to allow
   it to identify a RenderWidgetHost/RenderFrameHost that has
   independent zoom, and which isn't a main frame. This frame hosts
   the PDF extension.

Note that although with PdfOopif the PDF extension frame will create
its own ZoomController (1), any calls it makes to the TabsAPI zoom
functions still use the ZoomController for the main frame. This allows
it to prevent zoom levels for full-page PDFs from being persisted.

Note also that no PDF extension JS code has been modified.

Bug: 372932834
Change-Id: Iaf418d03227817ec18fe1623d1f77f93be483608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6281436
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: James Maclean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432129}
2025-03-13 08:36:19 -07:00
4b79d0656e Remove SK_IGNORE_BLURRED_RRECT_OPT flag
In https://codereview.chromium.org/48623006/ Skia added an optimization
for blurring rounded rectangles (treating them as a ninepatch to
do less blurring and make the results cacheable). This saw up to an
80% reduction in time for rendering with the CPU backend in Skia's
benchmarks. However, due to differences in rendering between this
fast path and the existing path, it was not landed in Chromium and sat
unused here for 11+ years. It's been used in Android and all other
clients since then.

I addressed those rendering diffs [1][2][3] and this CL makes Chromium
use that fast path. This required setting up Chromium's discardable
memory cache (which Skia uses to cache masks and other things) because
in the new code path, Skia caches those blurred masks to save time
if there are, for example, multiple blurry rrects being drawn with 5px
border and the same sigma values.

There are still some very minor differences in appearance between the
two implementations, which I've addressed by rebasing and adding some
slight fuzzy tolerances, to make the tests less brittle for future
blur changes.

[1] http://review.skia.org/953496
[2] http://review.skia.org/953516
[3] https://crrev.com/c/6328778

Change-Id: I140844d24a9e31cb2bde4e25b6cb1cce1b812f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335820
Commit-Queue: Kaylee Lubick <kjlubick@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ashley Prasad <ashleydp@google.com>
Cr-Commit-Position: refs/heads/main@{#1432101}
2025-03-13 07:41:12 -07:00
f8f8a51015 [content] Track and reuse free and empty renderer processes.
This change introduces a mechanism to track and reuse free and empty
renderer processes that have not yet been terminated, reducing the
overhead of creating new ones.

To achieve this:
- A new 'SiteProcessCountTracker, keyed by
'kEmptySiteProcessCountTrackerKey'. This tracker specifically monitors
processes that become free and empty.
- The 'RenderProcessHostImpl::RemoveFrameWithSite' method now adds a
process to this tracker when its last frame is removed, indicating it is
now free and empty.
- Conversely, 'RenderProcessHostImpl::AddFrameWithSite' removes a
process from the tracker if a frame is added to it.

When assigning a process to a new 'SiteInstance', the code prioritizes
reusing a suitable, free and empty process identified by this tracker
(currently only background hosts are considered). If found, the
'SiteInstance' is marked with `REUSED_EXISTING_PROCESS`. Finally,
'RenderProcessHostImpl' destruction clears the process from the tracker
via 'ClearProcessForAllSites()'.

Bug:365958798

Change-Id: Icc1fb48b75b78fe25f83d179f4989124e929785b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6217969
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Attar <aattar@google.com>
Cr-Commit-Position: refs/heads/main@{#1432081}
2025-03-13 07:03:33 -07:00
2fa1d9bf11 [A11yPerformance] Suppress disable_on_hide for known screen readers
When ProgressiveAccessibility is configured with mode=disable_on_hide,
web accessibility is ordinariliy turned off for tabs when they are
hidden. This CL exempts known screen readers from this behavior.

Bug: 40925658
Change-Id: I791fff91a967d0e9464ce3f8e22c23225ffd8d18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347049
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432075}
2025-03-13 06:51:46 -07:00
ed2d8321be Add DWA metrics to measure Attribution Reporting registrations on
client bounce

The UMA client bounce metrics were added in https://crrev.com/c/6012217,
and as indicated we're only interested in non-navigation tied
attribution data hosts.

We would like to measure the DWA metrics, i.e. reporting origin level
metrics, for these metrics as well. We only record metrics for the
reporting origins that initiate the data host registration, and
reporting origins registered in the redirect chain are not considered
for simplification as they're unknown during data host registration.
Therefore, reporting origins need to be sent over mojo when registering
data hosts.

Fixed: b/383579282
Change-Id: I4482d3134fa3aff085bab4a391f2836dbb7964ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6331143
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Nan Lin <linnan@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432065}
2025-03-13 06:31:20 -07:00
00fa8a2c50 Local Network Access: ensure PNA block overrides work
If we turn on LNA warnings in M136, we need to keep the PNA
PrivateNetworkAccessRestrictionsEnabled enterprise policy working as per
agreement with enterprise team (can't break the enterprise policy until
M137).

This keeps the override in place for M136 even if we turn on the LNA
warnings in M136.

Bug: 395895368
Change-Id: Ia07912d551ed5f7ca9dfd2f20ef289563ec729dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6344890
Commit-Queue: Hubert Chao <hchao@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432048}
2025-03-13 05:53:41 -07:00
d6ae1d000c Ensure valid surface when renderer is about to be shown.
Specific combination of fullscreen, eviction and
visibility states can leads to crash.

Bug: 402791079
Change-Id: Iccab648282878030b2655ad199d37ff90343add6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330310
Commit-Queue: Vladislav Batalov <inverse12@yandex-team.ru>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432014}
2025-03-13 04:20:35 -07:00
8023883048 Count the page without renderer ACK as BFCached on memory pressure
In http://crrev.com/c/2838627, pages not receiving BFCache ACK are not
counted when enforcing the limit, and the limit enforcement will be
triggered when receiving the ACK. However, during pruning (due to memory
pressure), those pages in the entries should be counted and probably
evicted. This CL adds the reason check and a browser test for the case.

Bug: 402313221
Change-Id: Idffce799b843462a3f4eee459b4dfbd9cea3c8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347142
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432012}
2025-03-13 04:18:12 -07:00
219cd36c52 Differentiate normal BFCache limit and pruned cache limit
So that we have a better idea on how often the entry gets evicted
because of memory pressure.

Bug: 402313221
Change-Id: I631331a8f31c6a65caa72850980ad09a6f5180b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6342135
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432001}
2025-03-13 03:26:11 -07:00
a0dca5daa9 [Gardener] Disable FormControlsBrowserTest cases on Windows
First failing build:
https://ci.chromium.org/p/chromium/builders/ci/win11-arm64-rel-tests/b8720554391255909777

Bug: 403163171
Change-Id: I02ad1960da6d6a055bc6b6f1c05af1a2dce2a10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351213
Commit-Queue: Christoph Schwering <schwering@google.com>
Owners-Override: Christoph Schwering <schwering@google.com>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1431983}
2025-03-13 02:42:50 -07:00
174bae2d34 Record Clients.match() and Clients.matchAll() to look up SharedWorker
To understand the affected area by SharedWorker blob URL controller
change, let me add a metrics to be recorded on affected cases.

Bug: 324939068
Change-Id: Idf079358d671f0d13b95d77e468569cb07b7241b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347337
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Keita Suzuki <suzukikeita@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431936}
2025-03-12 23:14:30 -07:00
6d04d7320e Revert "[views-ax] Create BrowserViewsAXManager instance in the correct place"
This reverts commit db6d48dfdd.

Reason for revert: Caused Linux UBSan test failure, e.g. https://chromium-swarm.appspot.com/task?id=6fa5b90aa914e711&o=true&w=true

Original change's description:
> [views-ax] Create BrowserViewsAXManager instance in the correct place
>
> Previously, I introduced BrowserViewsAXManager (behind a flag) and
> instantiated it from the ViewsDelegate constructor. This was incorrect,
> as we rely on the AXPlatform::GetInstance that only gets created a few
> moments later in the BrowserMainLoop. The design was invalid.
>
> The challenge here is that we must initialize the BrowserViewsAXManager
> class, which lives in the ui/views layer, from the browser_main_loop.
> Because content/browser cannot depend directly on ui/views, we must
> instead leverage the ChromeBrowserMainExtraPartViews to initialize the
> shared instance and store it.
>
> Bug: 40672441
> Change-Id: I62432f9e547172bbe357040db29428e41db7d82c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6293824
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1431815}

Bug: 40672441
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I178c4f10b9e31c62cef3ec606ceca6f8d15a8dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349100
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Owners-Override: Kenichi Ishibashi <bashi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1431927}
2025-03-12 22:14:34 -07:00
53761418f9 Update bug reference in a TODO.
The old bug was about the SW static routing API itself.
It has been updated to the bug specific to this issue.
i.e. make fetches from SharedWorker and DedicatedWorker
to be handled by SW static routing API.

Bug: 402806160
Change-Id: Ib1addb5270ff91b022bc09739bcb9798b71fd7e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6350282
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Keita Suzuki <suzukikeita@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431926}
2025-03-12 22:11:32 -07:00
66163a7365 Add initial skeleton of [KeepAliveTrackerThrottle][1].
This is for observing the lifetime of a subset of fetch keepalive
requests that match all of the following conditions:

- A network request with keepalive set to true.
- A network request with URL param "category=<certain value>"[2].

[1]: https://docs.google.com/document/d/1byKFqqKTsVFnj6rSb7ZjHi4LuRi1LNb-vf4maQbmSSQ/edit?resourcekey=0-7GAe1ae8j_55DMcvp3U3IQ&tab=t.0
[2]: https://docs.google.com/document/d/1FY3AINZW_h2GU81U-XPQz8bKT6wgt0u7Z9GF4o7_Llk/edit?resourcekey=0-lQnRY9BK0iclRRV62LgVDQ&tab=t.0

Bug: 382527001
Change-Id: I5e488bf3f0c2c35aeb0222550c34f5b0f9c66a8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6325517
Reviewed-by: Nan Lin <linnan@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431911}
2025-03-12 21:12:37 -07:00
fa24efebcd Revert "[a11y] Fixes move by format for CSS spellcheck highlights"
This reverts commit c6bfb8a155.

Reason for revert: This change broke Narrator's move-by-headings
feature. Heading navigation is a critical feature of screen readers that
facilites navigating web pages, like the google/bing results page. It
impacts all headings throughout the web, whereas the original CL was
fixing a scoped problem: spelling errors unannounced when exposed using
CSS highlights. We will also revert this change from 134.

Original change's description:
> [a11y] Fixes move by format for CSS spellcheck highlights
>
> Uses Spelling/Grammar error CSS highlight markers in the
> Accessibility Tree to break format boundaries around those
> errors to help navigate better around these spelling/grammar
> errors.
>
> This CL achieves following:
> 1) Fixes Move by format to accommodate CSS spellcheck highlights.
> 2) Narrator calls out the spelling issues correctly.
>
> Bug: 364795299
> Change-Id: I4842a49449c666100e31f859447f951e9f9eb09e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6178990
> Auto-Submit: Vinay Singh <vinaysingh@microsoft.com>
> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1415710}

Bug: 402800783, 364795299
Change-Id: I1ee7bd394f18fba21e97e5cc8998de1a03501931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349562
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1431891}
2025-03-12 19:50:00 -07:00