If output buffers got full while running the tests, the
script would hang, polling the process forever and it would never
return a return_code from proc.poll().
This might have caused some random timouts but if so, it is
unclear what 64 KB output filled up the buffers, unless the buffers
were smaller than local testing would indicate.
This stores stdout and stderr in temporary files and reads those
files back into memory after the process has finished.
Bug: 882852
Change-Id: I4e6ace2bb783fadcde3f43643ccad03c58ef519a
Reviewed-on: https://chromium-review.googlesource.com/c/1425736
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625603}
This will help reproducing nocompile test failures with locally built
Clang, and also fixes a TODO from 2011 :-)
Bug: 913420
Change-Id: I613f0836d92c8f3f6513e0e03af83206447e4c76
Reviewed-on: https://chromium-review.googlesource.com/c/1409188
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622440}
The linux jumbo bot is flaking on content nocompile tests due to the
nocompilation tests timing out. This patch increases the timeout to
twice what it was before.
Bug: 882852
Change-Id: Ib2bc0023acd8d677ea77eb2769a5f83da39ed0da
Reviewed-on: https://chromium-review.googlesource.com/c/1248601
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596199}
To make no-compile test deterministic, we also need to make the test
name shown in the same order.
Since I thought order of test names are not important, let me sort it
before printed.
Note that this change may make swarming to ignore executing tests even if
somebody edit *.nc. However, I think the actual tests for non-compile
tests have already done in compile step and build would fail if test
failed, executing generated should not be needed for each *.nc update.
BUG=678903,105388
Review-Url: https://codereview.chromium.org/2655613002
Cr-Commit-Position: refs/heads/master@{#446018}
nocompile_tests wasn't aware header file dependencies that included by
a .nc file. That makes a test failure sticky.
This CL makes nocompile_driver.py to emit a depfile to let ninja know
the implicit dependencies.
Review URL: https://codereview.chromium.org/1698763002
Cr-Commit-Position: refs/heads/master@{#375504}
- Fixed a nocompile test wasn't ever no compiled (probably a side effect
of http://crrev.com/111889) and never worked.
- Updated the error messages to those used by gcc 4.6 in Precise
- Minor improvement to the nocompile driver that makes the compiler
output more friendly when the regex includes a single quote. Hopefully
no one needs to match a double quote for awhile...
TBR=darin
Review URL: https://codereview.chromium.org/12040055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178434 0039d316-1c4b-4281-b951-d872f2087c98
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
TBR=timurrrr@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8678023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111960 0039d316-1c4b-4281-b951-d872f2087c98
BUG=87341
TEST=enable some of the existing no-compile tests and run on try bots.
Review URL: http://codereview.chromium.org/7458012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100564 0039d316-1c4b-4281-b951-d872f2087c98
