Initial conversion performed using '2to3 -f print .'.
Imports added and duplicate parentheses removed manually.
Manually converted files, comments and inline code that 2to3 missed.
Afterwards ran "git cl format --python" and cherry-picked the formatting changes.
Fixed a syntax error in check_grd_for_unused_strings.py due to a missing comma (caught by pylint).
There are no intended behavioural changes.
Bug: 941669
Change-Id: Ie0c67e5e416f386830e95aa2469b18a98b5425a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818477
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#698787}
There is a need to express localizable strings in //services code.
This CL introduces all the bits necessary to define translated resources
in a new //services/services_strings.grd file and moves a single string
(pertaining only to a service defined in //services) from the Chrome GRD
to the services GRD.
This is a precursor to simplifying expression of out-of-process service
registration by allowing service manifests to include a resource ID
directly in their definition.
Bug: 895615, 915806
Change-Id: I76d420266fb5528f407b624838172c267666654b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615701
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#663919}
This adds localization for the reason string fragments used in macOS
Touch ID prompts.
The prompts display a message starting with '"Google Chrome" is trying
to ' (controlled by macOS) followed by the reason fragment (controlled
by us). The user can confirm the prompt by providing their fingerprint,
or click cancel.
Bug: 848317
Change-Id: Ibe67c197554cde0af431516d968479b0f416629e
Reviewed-on: https://chromium-review.googlesource.com/1166171
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582637}
This reverts commit f57e1c3507.
Reason for revert: There are ash and mash_ash failures, reverting because it's ash-related. See crbug.com/841889
Original change's description:
> cros - Update appearance of resolution change notification.
>
> This removes the last raster asset in ash_resources.grd, so remove that
> file and the associated build target.
>
> Bug: 840509,505953
> Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c
> Reviewed-on: https://chromium-review.googlesource.com/1050523
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557292}
TBR=jamescook@chromium.org,sky@chromium.org,estade@chromium.org
Change-Id: I4b0ce3e1d01b5b8e390216b379f4158380f542b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 840509, 505953, 841889
Reviewed-on: https://chromium-review.googlesource.com/1054118
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557598}
This removes the last raster asset in ash_resources.grd, so remove that
file and the associated build target.
Bug: 840509,505953
Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c
Reviewed-on: https://chromium-review.googlesource.com/1050523
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557292}
Includes a minor change to check_grd_for_unused_strings.py
Found running the following with the change to
check_grd_for_unused_strings.py:
./tools/check_grd_for_unused_strings.py chrome \
chrome/app/chromeos_strings.grdp
Some of these came from the switch to the new Settings UI and were
missed, some have just been lingering for a very long time.
Bug: 771795, 783396
Change-Id: If6d9ab01f909c69d6375459d314e97ce3633ceaf
Reviewed-on: https://chromium-review.googlesource.com/762383
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515629}
At some point extensions strings moved into extensions/strings.
BUG=none
TEST=runs
Review-Url: https://codereview.chromium.org/2802723005
Cr-Commit-Position: refs/heads/master@{#462586}
This CL:
- Removes athena dependencies from build files for the chrome target
- Removes athena-specific files in chrome/
BUG=440818
TEST=None
R=sky,scottmg
TBR=jamescook (for change to comment in extensions/shell/browser/desktop_controller.h)
Review URL: https://codereview.chromium.org/855753004
Cr-Commit-Position: refs/heads/master@{#312282}
