0
Commit Graph

5 Commits

Author SHA1 Message Date
Avi Drissman
3a215d1e60 Update copyright headers in ash/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c21.

No-Try: true
No-Presubmit: true
Bug: 1098010
Change-Id: I1d041830fce905cf3682306ab435f4356d528c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3879644
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044133}
2022-09-07 19:43:09 +00:00
Peter Boström
ec31a04c56 Replace DISALLOW_COPY_AND_ASSIGN in ash/
This replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes
where a local script is able to detect its insertion place (~Foo() is
public => insert before this line).

This is incomplete as not all classes have a public ~Foo() declared, so
not all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.

IWYU cleanup is left as a separate pass that is easier when these macros
go away.

Bug: 1010217
Change-Id: Iedd7c835cea6c26dd4655c11e875cbf1b06bd1ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163767
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922357}
2021-09-16 23:37:34 +00:00
Tetsui Ohkubo
f590c5d6b8 Unified: Remove SystemTrayUnified flag.
This CL removes SystemTrayUnified flag. This is the part 1 of removing
old System Tray code.

(1) Removing the flag
(2) Removing references to IsSystemTrayUnifiedEnabled()
(3) Removing classes that are only used in old System Tray

I'll try to keep the number of CLs as small as possible to make the
history clean, but there can be multiple CLs for both part 2 and part 3
because some of them requires nontrivial refactoring to remove the
dependency to the old code.

TEST=manual
BUG=898419

Change-Id: I7a24d57afe7d39d437a17c475e5f6be330f0351e
Reviewed-on: https://chromium-review.googlesource.com/c/1297778
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602561}
2018-10-25 01:30:28 +00:00
Tetsui Ohkubo
3679446510 Bind mojom::SystemTray in SystemTrayModel
This CL moves remaining mojom::SystemTray implementation in
SystemTrayController to SystemTrayModel, and changes SystemTrayModel to
bind mojom::SystemTray interface directly.

TEST=trybot pass
BUG=none

Change-Id: Ie73cd257e19a5230387058f45c57a771a32310cf
Reviewed-on: https://chromium-review.googlesource.com/1107582
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571419}
2018-06-29 07:26:02 +00:00
Tetsui Ohkubo
56307e3307 Add tracing enabled notification.
As TrayTracing will be removed in UnifiedSystemTray, "Performance
tracing enabled" message should be shown as a pinned notification.

As the strings and the icon are still not given from UX, they are
temporary.

TEST=TracingNotificationControllerTest
TEST=manual(chrome://slow)
BUG=824631

Change-Id: I49016886acc1a4fc2b109998d260210b1d9ac8dc
Reviewed-on: https://chromium-review.googlesource.com/1060893
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559828}
2018-05-18 07:36:26 +00:00