CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.
This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.
(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)
Bug: 1031540
Change-Id: I643818242b92e19a1048fac89dd8aae323e8b1ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164510
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763511}
All ContextFactoryPrivate implementations are also ContextFactory
implementations. Move the two remaining ContextFactoryPrivate functions
into ContextFactory and clean up usage.
Bug: 1042259
Change-Id: I48063717cd6e51ccfc94e0a160d50d95d7629388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047728
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744444}
Implementing an --enable-viz flag will require an ImageTransportFactory
that isn't GpuProcessTransportFactory. There is already a function to
set an arbitrary test factory.
Add ImageTransportFactory::SetFactory() and just use that everywhere
instead. Move the test only code into the test factory. Have
BrowserMainLoop pass in GpuProcessTransportFactory and tests pass in
NoTransportImageTransportFactory.
Also cleanup forward declerations and includes on ImageTransportFactory.
Bug: 770833
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I15c4d128fa8840c06d04f336dde2d0d075a00380
Reviewed-on: https://chromium-review.googlesource.com/716696
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508440}
ui::ContextFactory is an interface that contains both privileged and
unprivileged operations. This CL dices ContextFactory into two, clearly
delineating operations that can be performed by Mus clients, and operations that
are reserved for mus-ws and mus-gpu and should be refactored.
Mus clients other than Chrome do not need to inject a
ContextFactoryPrivate into ui::Compositor. Chrome still needs
ContextFactoryPrivate because it has its own display compositor for
now.
Once we complete the unified display compositor work across all Chrome
clients, ContextFactoryPrivate can go away entirely.
BUG=670710
TBR=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2563783002
Cr-Commit-Position: refs/heads/master@{#438447}
Chrome (and others) need this so they can supply the ContextFactory to
the Compositor and get rid of Compositor::GetInstance.
BUG=none
TEST=none
R=piman@chromium.org
Review URL: https://codereview.chromium.org/276973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269447 0039d316-1c4b-4281-b951-d872f2087c98
