Arthur Sonzogni
c686e8f4fd
Rename {absl => std}::optional in //content/
...
Automated patch, intended to be effectively a no-op.
Context:
https://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium=email&utm_source=footer
As of https://crrev.com/1204351 , absl::optional is now a type alias for
std::optional. We should migrate toward it.
Script:
```
function replace {
echo "Replacing $1 by $2"
git grep -l "$1" \
| cut -f1 -d: \
| grep \
-e "^content" \
| sort \
| uniq \
| grep \
-e "\.h" \
-e "\.cc" \
-e "\.mm" \
-e "\.py" \
| xargs sed -i "s/$1/$2/g"
}
replace "absl::make_optional" "std::make_optional"
replace "absl::optional" "std::optional"
replace "absl::nullopt" "std::nullopt"
replace "absl::in_place" "std::in_place"
replace "absl::in_place_t" "std::in_place_t"
replace "\"third_party\/abseil-cpp\/absl\/types\/optional.h\"" "<optional>"
git cl format
```
# Skipping unrelated "check_network_annotation" errors.
NOTRY=True
Bug: chromium:1500249
Change-Id: Icfd31a71d8faf63a2e8d5401127e7ee74cc1c413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185537
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org >
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org >
Owners-Override: Avi Drissman <avi@chromium.org >
Reviewed-by: Avi Drissman <avi@chromium.org >
Reviewed-by: danakj <danakj@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1245739}
2024-01-11 08:36:37 +00:00
Matthew Denton
ab0ccd578e
Linux: Fix exec'd process's use of base::FileDescriptorStore
...
See crbug.com/1407326. This fixes (1) and adds a test to
utility_process_host_browsertest.cc to ensure that this works in the
future when exec'ing a process (i.e. not launching from a zygote).
Bug: 692619, 1407326
Change-Id: I334400ebefac116611d3fc93d5ff5a7d83908eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4159897
Commit-Queue: Alex Moshchuk <alexmos@chromium.org >
Commit-Queue: Matthew Denton <mpdenton@chromium.org >
Auto-Submit: Matthew Denton <mpdenton@chromium.org >
Reviewed-by: Alex Moshchuk <alexmos@chromium.org >
Reviewed-by: Tom Sepez <tsepez@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1104132}
2023-02-11 00:11:59 +00:00
Matthew Denton
e669d60181
Reland "Linux: Fix zygote's use of base::FileDescriptorStore"
...
This is a reland of commit 2548a5c354https://chromium-review.googlesource.com/c/chromium/src/+/4166816
> Reviewed-by: Tom Sepez <tsepez@chromium.org >
> Commit-Queue: Matthew Denton <mpdenton@chromium.org >
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1095906}
Bug: 692619, 1407326
Change-Id: Iad498b2949f4cc29d683f20cd4711fe2d4403656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4191378
Commit-Queue: Matthew Denton <mpdenton@chromium.org >
Reviewed-by: Tom Sepez <tsepez@chromium.org >
Reviewed-by: Alex Moshchuk <alexmos@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1096462}
2023-01-24 22:56:15 +00:00
Olesia Marukhno
93ecd6f4c8
Revert "Linux: Fix zygote's use of base::FileDescriptorStore"
...
This reverts commit 2548a5c354https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests ) and Linux MSan Tests (https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests )
Original change's description:
> Linux: Fix zygote's use of base::FileDescriptorStore
>
> See crbug.com/1407326. This fixes (2) and adds a test to
> utility_process_host_browsertest.cc to ensure that this works in the
> future, with both the unsandboxed and the generic zygote.
>
> Unfortunately base::FileDescriptorStore still doesn't work on Android,
> so add a bug and a TODO to fix that.
>
> Bug: 692619, 1407326
>
> Change-Id: I83ecbb1ec84b36c55ed954acdbab890cb8f55862
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166816
> Reviewed-by: Tom Sepez <tsepez@chromium.org >
> Commit-Queue: Matthew Denton <mpdenton@chromium.org >
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1095906}
Bug: 692619, 1407326
Change-Id: Iee9c562cc556bfca09b1541e602d94d102d4da88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188677
Owners-Override: Olesia Marukhno <olesiamarukhno@google.com >
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1096074}
2023-01-24 09:31:24 +00:00
Matthew Denton
2548a5c354
Linux: Fix zygote's use of base::FileDescriptorStore
...
See crbug.com/1407326. This fixes (2) and adds a test to
utility_process_host_browsertest.cc to ensure that this works in the
future, with both the unsandboxed and the generic zygote.
Unfortunately base::FileDescriptorStore still doesn't work on Android,
so add a bug and a TODO to fix that.
Bug: 692619, 1407326
Change-Id: I83ecbb1ec84b36c55ed954acdbab890cb8f55862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166816
Reviewed-by: Tom Sepez <tsepez@chromium.org >
Commit-Queue: Matthew Denton <mpdenton@chromium.org >
Reviewed-by: Alex Moshchuk <alexmos@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1095906}
2023-01-23 23:49:13 +00:00
Avi Drissman
4e1b7bc33d
Update copyright headers in content/
...
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34 .
No-Try: true
No-Presubmit: true
Bug: 1098010
Change-Id: I8c0f009d16350271f07d8e5e561085822cc9dd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895935
Owners-Override: Avi Drissman <avi@chromium.org >
Reviewed-by: Mark Mentovai <mark@chromium.org >
Commit-Queue: Mark Mentovai <mark@chromium.org >
Auto-Submit: Avi Drissman <avi@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1047456}
2022-09-15 14:03:50 +00:00
Lei Zhang
ed9be3a428
Remove many unneeded CONTENT_EXPORT entries.
...
Many classes within content don't need CONTENT_EXPORT because they are
not in content/public and they are not directly used from tests.
Change-Id: I22696b3840ab7a89371184e866b05d0b4980e7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288753
Auto-Submit: Lei Zhang <thestig@chromium.org >
Commit-Queue: Avi Drissman <avi@chromium.org >
Reviewed-by: Avi Drissman <avi@chromium.org >
Owners-Override: Avi Drissman <avi@chromium.org >
Cr-Commit-Position: refs/heads/main@{#942828}
2021-11-17 22:01:18 +00:00
Anton Bikineev
f62d1bf48e
content: Replace base::Optional and friends with absl counterparts
...
This replaces:
- base::Optional -> absl::optional
- include "base/optional.h"
->
include "third_party/abseil-cpp/absl/types/optional.h"
- base::nullopt -> absl::nullopt
- base::make_optional -> absl::make_optional
Bug: 1202909
Change-Id: Ie9f37bcbf6115632a19f4d063387d07b3723926f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2897246
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Peter Kasting <pkasting@chromium.org >
Owners-Override: Peter Kasting <pkasting@chromium.org >
Cr-Commit-Position: refs/heads/master@{#883270}
2021-05-15 17:56:07 +00:00
Ken Rockot
30f6a4ab34
Remove //services/service_manager/embedder target
...
Sources for this target are moved back into //content/common. No
behavioral changes.
Bug: 977637
Change-Id: I1aed5fb1010b11224cf509e0f3cf3de549bb6193
Tbr: avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411468
Commit-Queue: Ken Rockot <rockot@google.com >
Reviewed-by: Matt Falkenhagen <falken@chromium.org >
Cr-Commit-Position: refs/heads/master@{#807802}
2020-09-17 08:34:01 +00:00
