0
Commit Graph

4 Commits

Author SHA1 Message Date
Liza Burakova
c63982ac77 Fix small task runner typos.
This CL replaces a few instances of SequencedThreadTaskRunner with
SequencedTaskRunner and SingleTaskRunner with SingleThreadTaskRunner.

It also removes a forward declaration of SequencedThreadTaskRunner
since the file already includes sequenced_task_runner.h

Change-Id: I41476e9c92991d85adae719779b0231e0a16b922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4887154
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201096}
2023-09-25 18:40:09 +00:00
Scott Haseley
241ca837df Task Posting v3: Migrate //content/renderer/PRESUBMIT.py
New usage of (Sequenced|Thread)TaskRunnerHandle::Get() is banned in
//content/renderer, but the presubmit was not updated to reflect the
new APIs. This fixes that.

Bug: 827065, 1026641
Change-Id: Id956180dd7c643251fa57901052316eb814ebf5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4525136
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1143539}
2023-05-12 22:35:20 +00:00
Avi Drissman
4e1b7bc33d Update copyright headers in content/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
No-Presubmit: true
Bug: 1098010
Change-Id: I8c0f009d16350271f07d8e5e561085822cc9dd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895935
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047456}
2022-09-15 14:03:50 +00:00
Hajime Hoshi
1230a8a45e Forbid newly introducing ThreadTaskRunnerHandle/SequencedTaskRunnerHandle::Get()
In most cases, using ThreadTaskRunnerHandle::Get() or
SequencedTaskRunnerHandle::Get() in renderers is semantically wrong.
Additionally, these task usage prevents flexible renderer scheduing,
e.g. throttling tasks for a hidden iframe.

This CL introduces presubmit checks to forbide newly introducing those
Get() usages.

Bug: 827065
Change-Id: I92cd9d4207d5664e42763939e5c1c8d293897799
Reviewed-on: https://chromium-review.googlesource.com/995241
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549759}
2018-04-11 04:42:30 +00:00