chromium/src
0
Fork 0
Code Activity
1,488,679 Commits 3 Branches 23,233 Tags
cd50ddaa7605e8c36d67fd57272899b615d5c65d
Commit Graph

24 Commits

Author SHA1 Message Date
Takuto Ikuta
1d89a46184 [//build] Remove six usage from Python scripts 
We don't use Python2 anymore and no need to depend on six now.
This is a clean up CL after python3 migration in chromium/src.

Bug: 1466397
Change-Id: I87885308e48f28e295ec7be13923dc44b896030a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4710347
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175480}
 2023-07-26 16:08:41 +00:00
Takuto Ikuta
df413c2e2b build: remove 'from __future__ import print_function' 
I think we don't need this line anymore.

Bug: 1406153
Change-Id: Id161854458d131645bb4b54e9ed69b1c171319ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4078643
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092171}
 2023-01-13 01:00:01 +00:00
Avi Drissman
73a09d1a67 Update copyright headers in build/, build_overrides/, and buildtools/ 
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

An earlier version of this CL, https://crrev.com/c/3879808,
was reverted due to an issue that was resolved with
https://crrev.com/c/3881211.

No-Try: true
Bug: 1098010
Change-Id: I91174ff0a9dd8b6dee79e6cba8209b614ce2b712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3884220
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044745}
 2022-09-08 20:33:38 +00:00
Rebekah Potter
184a820046 Revert "Update copyright headers in build/, build_overrides/, and buildtools/" 
This reverts commit 8996d5a5ca.

Reason for revert: Breaks android-binary-size bot, see
https://bugs.chromium.org/p/chromium/issues/detail?id=1361092

Original change's description:
> Update copyright headers in build/, build_overrides/, and buildtools/
>
> The methodology used to generate this CL is documented in
> https://crbug.com/1098010#c21.
>
> No-Try: true
> Bug: 1098010
> Change-Id: I0323d0734081fc1aaf3b9ec3b8184411fe1a368a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3879808
> Auto-Submit: Avi Drissman <avi@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Owners-Override: Avi Drissman <avi@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1044227}

Bug: 1098010
Change-Id: Ie1b5a07d859e98588c1497220aac54834ea5d7f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3880816
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044284}
 2022-09-08 01:08:54 +00:00
Avi Drissman
8996d5a5ca Update copyright headers in build/, build_overrides/, and buildtools/ 
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c21.

No-Try: true
Bug: 1098010
Change-Id: I0323d0734081fc1aaf3b9ec3b8184411fe1a368a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3879808
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044227}
 2022-09-07 22:46:30 +00:00
Yoshisato Yanagisawa
9f477792c9 Make build/android presubmit checked with pylint-2.6. 
Changes:
- omit unnecessary object class.
- python2 superclass call.
- omit unnecessary superclass calls.
- removed obsoleted pylint flags.
- reraised exceptions to use from.
- fixed python2 methods to python3.

Bug: 1262303
Change-Id: I079955a43aa4a0632493a25e8db4b01a2028417d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313767
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#949821}
 2021-12-09 00:00:25 +00:00
Peter Wen
0cea52bf86 Android: Switch build scripts to use python3 (reland2) 
Add wnwen@ to third_party/jinja2 to make future fixes/updates easier in
EST.

Fixed jinja2 bug that prevented _identifier.py from being detected by
build/print_python_deps.py (in patch 0002).

Original CL: https://crrev.com/c/3017583

All scripts previously using python under build/android should now use
python3 instead. Ran:

find build/android -name '*.py' -print0 |\
  xargs -0 grep 'env python' -H |\
  grep -v 'python3' -H

Bug: 1228231
Change-Id: Idc4028ebe643533afa3a13af1f55007ba1cdb7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3071786
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#913020}
 2021-08-18 16:11:06 +00:00
Ben Joyce
d7822952e6 Update files to be python3 compatible. 
Changes were made with python -m modernize. Then pylint errors were addressed.

Bug: 1195981
Change-Id: If4d6ab2291a1271245a3b1de32ed532decb61ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2964185
Commit-Queue: Ben joyce <bjoyce@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#912626}
 2021-08-17 17:19:03 +00:00
Peter Wen
36819d28b4 Revert "Android: Switch build scripts to use python3 (reland)" 
This reverts commit 208a9e993c.

Reason for revert: Perf bot failures https://ci.chromium.org/p/chrome/builders/ci/android-pixel2-perf?limit=200

Original change's description:
> Android: Switch build scripts to use python3 (reland)
>
> All scripts previously using python under build/android should now use
> python3 instead. Ran:
>
> find build/android -name '*.py' -print0 |\
>   xargs -0 grep 'env python' -H |\
>   grep -v 'python3' -H
>
> Bug: 1228231
> Change-Id: Ie414f0963d0895fcc8803cd8e07b5aae574af56d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069179
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#908007}

Bug: 1228231
Change-Id: I203369ca7d87536d0abbe610a147be8b64f63db6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3071698
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908460}
 2021-08-04 15:11:25 +00:00
Peter Wen
208a9e993c Android: Switch build scripts to use python3 (reland) 
All scripts previously using python under build/android should now use
python3 instead. Ran:

find build/android -name '*.py' -print0 |\
  xargs -0 grep 'env python' -H |\
  grep -v 'python3' -H

Bug: 1228231
Change-Id: Ie414f0963d0895fcc8803cd8e07b5aae574af56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069179
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908007}
 2021-08-03 16:26:20 +00:00
Peter Wen
a527a00ae1 Revert "Android: Switch build scripts to use python3" 
This reverts commit 3cfa4a63a1.

Reason for revert: gLinux upgraded to python3.9 and is now breaking catapult due to python3.9's rename of IsAlive -> is_alive

Original change's description:
> Android: Switch build scripts to use python3
>
> All scripts previously using python under build/android should now use
> python3 instead. Ran:
>
> find build/android -name '*.py' -print0 |\
>   xargs -0 grep 'env python' -H |\
>   grep -v 'python3' -H
>
> Bug: None
> Change-Id: Ife826b8269e65c80cc668eb56742578bf73ae866
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3017583
> Auto-Submit: Peter Wen <wnwen@chromium.org>
> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#900097}

Bug: 1228231
Fixed: 1228231
Change-Id: I0c2f001d32a6fa5f7d98f00afd77e1ee2ba5283d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3020366
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#900514}
 2021-07-12 16:30:57 +00:00
Peter Wen
3cfa4a63a1 Android: Switch build scripts to use python3 
All scripts previously using python under build/android should now use
python3 instead. Ran:

find build/android -name '*.py' -print0 |\
  xargs -0 grep 'env python' -H |\
  grep -v 'python3' -H

Bug: None
Change-Id: Ife826b8269e65c80cc668eb56742578bf73ae866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3017583
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900097}
 2021-07-09 19:17:04 +00:00
Raul Tambre
9e24293bf2 //build: Convert print statements to Python 3 style 
Ran "2to3 -w -n -f print ./base" and manually added imports.
There are no intended behaviour changes.

Bug: 941669
Change-Id: Ie2830e213eae3a5d7753ce503020e02811b726d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585890
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#658917}
 2019-05-12 06:11:07 +00:00
David 'Digit' Turner
66f9dbec18 build/android: Fixes to make pylint happy. 
This CL contains fixes required to ensure that the presubmit
upload script does not fail after the Pylint update to 1.5.

More specifically:

- The pylintrc is modified to add wrong-order-position to
  the list of disabled warnings, since many of the scripts
  under build/android require sophisticated import logic
  due to the use of third_party/catapult/devil/

- Otherwise, scripts are locally updated by either changing
  the source code, or adding local pylint comments to disable
  a specific warning.

Without this CL, no Android-specific CL can pass the presubmit
test on Gerrit :-/

BUG=NONE
R=jbudorick@chromium.org, agrieve@chromium.org, vapier@chromium.org

Change-Id: I4812c76bf1b86918d56c230574c741c3c1328c5d
Reviewed-on: https://chromium-review.googlesource.com/1148339
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577510}
 2018-07-24 13:42:59 +00:00
Peter Wen
637713e066 Android: Roll third_party/android_tools 
Update to build-tools 27.0.3 from 27.0.1. Unblock Android Studio canary
gradle plugin update.

BUG=808116

Change-Id: I023683c5b3de4b31677422589e4b1152627d5d1a
Reviewed-on: https://chromium-review.googlesource.com/907596
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535453}
 2018-02-08 18:38:54 +00:00
Julien Brianceau
96dfe4d804 build: Fix common misspellings 
Bug: 750830
Change-Id: Ie4cc9f02e3cc23f0ed3e44b5372745eee9944165
Reviewed-on: https://chromium-review.googlesource.com/594770
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Julien Brianceau <jbriance@cisco.com>
Cr-Commit-Position: refs/heads/master@{#490922}
 2017-08-01 09:03:13 +00:00
jbudorick
58b4d36774 [Android] Add a custom pylintrc for build/android/. 
The default depot_tools pylintrc disables some checks that we can
reasonably enable in build/android/. This CL does so.

BUG=

Review URL: https://codereview.chromium.org/1315743004

Cr-Commit-Position: refs/heads/master@{#347720}
 2015-09-08 16:45:52 +00:00
jbudorick@chromium.org
7c53a605b8 [Android] Linting the rest of build/android/ 
BUG=168518

Review URL: https://codereview.chromium.org/201853007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258948 0039d316-1c4b-4281-b951-d872f2087c98
 2014-03-24 16:21:44 +00:00
jbudorick@chromium.org
e9ee6ec378 Revert of Enable presubmit pylint in build/android. (https://codereview.chromium.org/132463007/) 
Reason for revert:
This patch is probably the cause of crbug.com/342539.

Original issue's description:
> Enable presubmit pylint in build/android.
> 
> BUG=168518
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249793

TBR=craigdh@chromium.org,frankf@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=168518

Review URL: https://codereview.chromium.org/153743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250269 0039d316-1c4b-4281-b951-d872f2087c98
 2014-02-11 01:47:41 +00:00
jbudorick@chromium.org
7c3d872bdb Enable presubmit pylint in build/android. 
BUG=168518

Review URL: https://codereview.chromium.org/132463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249793 0039d316-1c4b-4281-b951-d872f2087c98
 2014-02-07 21:34:23 +00:00
nduca@chromium.org
f05d582b7e Use third_party/pexpect in android pylib 
BUG=154343


Review URL: https://chromiumcodereview.appspot.com/11183025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162519 0039d316-1c4b-4281-b951-d872f2087c98
 2012-10-17 21:03:12 +00:00
bulach@chromium.org
f033c51450 [android] Upstream / sync most of build/android and build/android/pylib. 
These files have diverged overtime. We need to get them in sync in
preparation for the instrumentation tests.
The patches downstream have been entangled, so this is a bit big and
contains a series of otherwise unrelated patches.
However, it's probably safer to do this way (as it's guaranteed to be similar to
downstream), than trying to split it in multiple patches.

BUG=
TEST=try -b android_test


Review URL: https://chromiumcodereview.appspot.com/10689132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145872 0039d316-1c4b-4281-b951-d872f2087c98
 2012-07-10 13:21:43 +00:00
maruel@chromium.org
3f09d180c4 Fix python scripts in src/build/ 
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent

Also fix EOF LF to be only one.

TBR=michaelbai@chromium.org
BUG=105108
TEST=

Review URL: http://codereview.chromium.org/8667008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111385 0039d316-1c4b-4281-b951-d872f2087c98
 2011-11-23 19:13:44 +00:00
michaelbai@google.com
55ee7f4d79 Upstream: Test scripts for Android (phase 2) 
Currently only support run base_unittests

BUG=
TEST=

Review URL: http://codereview.chromium.org/8364020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106953 0039d316-1c4b-4281-b951-d872f2087c98
 2011-10-24 18:59:20 +00:00