I need an owner's approval please for changes under:
components/on_load_script_injector
This is a mechanical change. There are a few instances (but not all)
of empty user-defined constructors and destructors which can be
defaulted in the /components code.
This CL was uploaded by git cl split.
R=zijiehe@google.com
Bug: 371316188
Change-Id: I8185dc68b2b292f32837bd06005c907d784bc6cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5917416
Reviewed-by: Zijie He <zijiehe@google.com>
Commit-Queue: Zijie He <zijiehe@google.com>
Auto-Submit: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1365952}
This CL moves bindings management functionality from the `//chromecast`
tree to the new `cast_receiver` component, as well as refactoring the
existing `//chromecast/cast_core` code to use the new implementation.
Bug: 1357135, 1359559, 1359578
Change-Id: I0ca5891c098678612d9f7822c7d34d39905d876c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3871419
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Vigen Issahhanjan <vigeni@google.com>
Commit-Queue: Ryan Keane <rwkeane@google.com>
Reviewed-by: Fabrice de Gans <fdegans@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1063412}
Calls to url::Origin::Create are error-prone as described in more
details in the linked bug. This CL reduces the usage of
url::Origin::Create by:
1) providing and using an overload of url::Origin::IsSameOriginWith that
takes a GURL as the parameter (rather than requiring the caller to
convert the argument to url::Origin). Introducing this overload was
discussed in
https://groups.google.com/a/chromium.org/g/navigation-dev/c/anCWy4uJQGU/m/R9IzZ33_BQAJ
2) using the already existing url::IsSameOriginWith free function that
works with GURL parameters.
Bug: 1270878
Change-Id: Id4e7c27a64a857913aa9862ecd5aba96bb717e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309669
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charles Reis <creis@chromium.org>
Commit-Queue: Charles Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#958439}
This is a large and fairly widely included header. The size of itself
and all the files it includes is 13 MB, it is part of ca 2,000
translation units for the 'chrome' target. Its added size for that
target is ca 5 GB. The compile time of the header alone is ca 4 s.
This change reduces the compile time of the header to ca 1 s,
and saves 8 CPU minutes of build time for the chrome target.
Bug: 242216
Change-Id: Idcaa4f6326545a64324a9d7fa45d6d27b136f622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2794474
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868174}
This change converts the OnLoadScriptInjectorHost template to use
explicit instantiation for std::string and uint64_t. This will improve
compile times and also makes the types for ScriptId explicit. The
change also fixes the public deps of the build target.
Bug: None
Change-Id: I0b52f7486589071150a6f5747daef0a0c6fceaa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468182
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817587}
This is a reland of 13c126e31c
Addresses the size increase by removing the dep on //ui/base.
All uses of ui::ResourceBundle in CastRunner are replaced with disk
reads.
Original change's description:
> [bindings] Define cross-platform NamedMessagePortConnector impl.
>
> Refactors NamedMessagePortConnector into a platform-agnostic component,
> which can be reused across FIDL, in-process, and testing contexts.
> It uses Blink messages and message ports as a common basis for
> message and port transport.
>
> * Implements some missing portions of the Blink/FIDL MessagePort
> conversion layer.
> * Adds a Fuchsia implementation of NMPC.
>
> Bug: 1104369
> Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806684}
Bug: 1104369
Change-Id: I77dc7679030e0f0aa61ad4dba2050ce2cb6e22d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417492
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808393}
This reverts commit 13c126e31c.
Reason for revert: This CL pulls in ui/base and increasing the size of CastRunner. The size increase is breaking the Chromium (into Fuchsia) roller.
Original change's description:
> [bindings] Define cross-platform NamedMessagePortConnector impl.
>
> Refactors NamedMessagePortConnector into a platform-agnostic component,
> which can be reused across FIDL, in-process, and testing contexts.
> It uses Blink messages and message ports as a common basis for
> message and port transport.
>
> * Implements some missing portions of the Blink/FIDL MessagePort
> conversion layer.
> * Adds a Fuchsia implementation of NMPC.
>
> Bug: 1104369
> Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806684}
TBR=ddorwin@chromium.org,kmarshall@chromium.org,jochen@chromium.org,lijiawei@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1104369
Change-Id: Ie5505f33dc2b29ce82fe5d44f8919e985da35102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414651
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807575}
Refactors NamedMessagePortConnector into a platform-agnostic component,
which can be reused across FIDL, in-process, and testing contexts.
It uses Blink messages and message ports as a common basis for
message and port transport.
* Implements some missing portions of the Blink/FIDL MessagePort
conversion layer.
* Adds a Fuchsia implementation of NMPC.
Bug: 1104369
Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806684}
Promotes ScriptId to a template parameter, so that the script injector
can be used for multiple purposes on a given platform.
Specifically, it will allow the use of uint64 script IDs on
FrameImpl, and base::StringPiece in bindings tests.
Migrate OnLoadScriptInjectorHost implementation from .cc to .h.
Bug: 1104369
Change-Id: Idfacd460d8d12038cfc2c00896e538ee87c55a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341837
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795994}
Consolidates the forked OnLoadScriptInjectors into one single shared
implementation. The shared implementation is a necessary prerequisite
step for developing platform-agnostic bindings browsertests.
* Deletes Fuchsia and Cast specific OnLoadScriptInjectors.
* Moves most browser process logic into a new class
"OnLoadScriptInjectorHost", to further harmonize the platforms.
* Migrate Mojo interface from ScopedSharedBufferHandle to ReadOnlySharedMemoryRegion.
Merge-With: eureka-internal/432742
Bug: 1113289
Bug: 1060846
Bug: 1103058
Test: cast_shell_browsertests and web_engine_browsertests both pass.
Change-Id: If9fd2c54de08d9bc225771b01cdb32152a95fde8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286193
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795103}
