Expand each row of tables into a section to
- improve discoverability in the table of content,
- make more room for columns that may have loog texts. Otherwise, some
columns in a row might have more than 10 lines while other columns in
the same row have just one line, which causes excessive white spaces
and thus affect readability.
Also, add a code snippet for each function so that the object that
exposes the function is clear.
Only functions and events are modified in this CL. The refactor for
"Types" will be conducted in following CLs.
Bug: b:303769407, b:303771148
Change-Id: Icf5d098d2fe942074306fd2a5ba57c728babe6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5693744
Reviewed-by: Kerker Yang <kerker@chromium.org>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1327314}
The camera frame analysis routine checks the frames captured by the
camera to detect different issues. It can only be run when the camera is
opened by some frontend.
The feature is blocked by a feature flag.
Bug: 342286051
Test: unit_tests -ozone-platform=headless --gtest_filter="*Diagnostic*"
Test: browser_tests -ozone-platform=headless --gtest_filter="*Telemetry*"
Change-Id: If8c7666218fd8c6eef8024013bd6cd4e33fd40f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5652824
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Chad Duffin <chadduffin@chromium.org>
Reviewed-by: Kerker Yang <kerker@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1326538}
Add the LED lit up routine to the telemetry extension. The routine will
light up the specified LED with the specified color. Callers can then
check whether the LED is lit up or not.
Bug: b/302279338
Test: unit_tests -ozone-platform=headless --gtest_filter="*Diagnostics*"
Test: browser_tests -ozone-platform=headless --gtest_filter="*Telemetry*"
Change-Id: If1e5d438b42efc1db72aea000b9c3de15a6356a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5432095
Reviewed-by: Kerker Yang <kerker@chromium.org>
Reviewed-by: Byron Lee <byronlee@chromium.org>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1286678}
Add a field `interaction` to the waiting state so that a routine can
ask callers to react to an interaction request. For interactions that
need to be replied, callers should invoke the `replyToRoutineInquiry`
method.
The implementation of `ReplyInquiry` in cros_healthd was done in
CL:5171546.
Bug: b/309781398
Test: unit_tests -ozone-platform=headless --gtest_filter="*Diagnostics*"
Test: browser_tests -ozone-platform=headless --gtest_filter="*Telemetry*"
Change-Id: I226f46f8f070595d7ef59c72d456a3e457681f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5411712
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Chung-sheng Wu <chungsheng@google.com>
Reviewed-by: Justin Lulejian <jlulejian@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1286675}
Follow the TypeScript style to use lowerCamelCase for property names.
This CL affects only the interfaces launched in M125 to avoid breaking
existing extensions:
- `createRoutine` function
- `isRoutineArgumentSupported` function
- `onRoutineFinished` event
Bug: b/315081026
Test: unit_tests -ozone-platform=headless --gtest_filter="*Diagnostics*"
Test: browser_tests -ozone-platform=headless --gtest_filter="*Telemetry*"
Change-Id: I9a70e1a12a131447b777402f134b6778704e3af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439295
Reviewed-by: Byron Lee <byronlee@chromium.org>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Kerker Yang <kerker@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285600}
Similar to CL:5391170 but for creating routines and checking supported
status.
To handle the case new extension running on older browser, treat a
dictionary-based union object without any non-null field as an
unrecognized Mojo union.
Bug: b:320394027, b:331540565
Test: unit_tests -ozone-platform=headless --gtest_filter="*Diagnostics*"
Test: browser_tests -ozone-platform=headless --gtest_filter="*Telemetry*"
Change-Id: I4976e77acf09bb33d4c21ede420961c64ed963c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404529
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Denny Huang <dennyh@google.com>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1281699}
In the past, callers of the telemetry extension routine v2 APIs had to
listen to one event for each type of routine. For example, there were
`onMemoryRoutineFinished` and `onVolumeButtonRoutineFinished` events. It
was a pain for extension developers to integrate so many event APIs.
This change unifies all routine finished events into one
`onRoutineFinished` event. Clients can thus listen to only one event,
read the `uuid` to learn which particular routine the event corresponds
to and get the detail of a finished routine.
To achieve this, we translate Mojo unions into dictionaries containing
nullable fields, each field corresponds to a member type of the union.
Bug: b:320394027, b:331540565
Test: unit_tests -ozone-platform=headless --gtest_filter="*Diagnostics*"
Test: browser_tests -ozone-platform=headless --gtest_filter="*Telemetry*"
Change-Id: Ia518c469dd33b485fbec2d1d6725eb2e9ab86aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391170
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Ethan Cheng <yycheng@google.com>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Denny Huang <dennyh@google.com>
Reviewed-by: Tim <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280067}
Setting audio gain should only be available for input audio nodes.
Implement this in `SetAudioGain` in Management API, including changing
the interface to have a boolean response.
Bug: b/303391740, b/317014106
Test: unit_tests --gtest_filter="TelemetryManagementServiceAshTest*"
Test: browser_tests --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py build/lacros/test_runner.py test out_linux_lacros/Release/lacros_chrome_browsertests --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py ./build/lacros/test_runner.py test out_linux_lacros/Release/lacros_chrome_browsertests --ash-chrome-path-override=lacros_version_skew_tests_v$version/test_ash_chrome --gtest_filter="TelemetryExtension*"
Change-Id: Ia6fb2b9a80acd959438e4c287f186eca4ba76c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5196714
Reviewed-by: Kerker Yang <kerker@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Denny Huang <dennyh@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1247374}
Add the Chrome Extension interface definitions for setAudioVolume in the
Management API.
This is part of a bigger effort to add the Management API to the
Telemetry Extension. For more context visit
go/telemetry-extension-management-audio.
Bug: b/303391740
Test: browser_tests --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py build/lacros/test_runner.py test out_linux_lacros/Release/lacros_chrome_browsertests --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py ./build/lacros/test_runner.py test out_linux_lacros/Release/lacros_chrome_browsertests --ash-chrome-path-override=lacros_version_skew_tests_v$version/test_ash_chrome --gtest_filter="TelemetryExtension*"
Change-Id: I31272a7c11f08016a8bb193b0b158ea6feb5c118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185776
Reviewed-by: Kerker Yang <kerker@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Commit-Queue: Denny Huang <dennyh@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246828}
Add the Chrome Extension interface definitions for the Management API,
with the first use case “SetAudioGain”.
This is part of a bigger effort to add the Management API to the
Telemetry Extension. For more context visit
go/telemetry-extension-management-audio.
Bug: b/303391740
Test: browser_tests --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py ./build/lacros/test_runner.py test out_linux_lacros/Release/lacros_chrome_browsertests --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py ./build/lacros/test_runner.py test out_linux_lacros/Release/lacros_chrome_browsertests --ash-chrome-path-override=lacros_version_skew_tests_v$version/test_ash_chrome --gtest_filter="TelemetryExtension*"
Test: testing/xvfb.py out/lsan/browser_tests --gtest_filter="TelemetryExtension*" --no-sandbox
Change-Id: Ice06241352adbd1cbb97df0fb673ff98169c6e39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5100330
Reviewed-by: Kerker Yang <kerker@chromium.org>
Commit-Queue: Denny Huang <dennyh@google.com>
Cr-Commit-Position: refs/heads/main@{#1240554}
All diagnostics v2 createXYZRoutine functions return the same response
type. Rename CreateMemoryRoutineResponse to CreateRoutineResponse so
that it's easier to be reused by other routines.
--gtest_filter="*TelemetryExtensionDiagnosticsApiV2*"
Bug: b/305128472
Test: browser_tests -ozone-platform=headless \
Change-Id: Iccdab20a43752399c143c231ddc251aea4b4eb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4941634
Reviewed-by: Chung-sheng Wu <chungsheng@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1212565}
The API `chrome.runtime` is not disabled for ChromeOS system extensions.
The original wording "besides xxx" was ambiguous.
Bug: none
Test: none
Change-Id: Ib75aa97834a85c4af27dc16aa35aefe787dcad16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4918394
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Denny Huang <dennyh@google.com>
Cr-Commit-Position: refs/heads/main@{#1206277}
This change adds documentation for the new diagnostics
API.
This is part of a bigger effort to add a new diagnostics API, please
visit go/dd-telemetry-extension-diag-revisit for more context.
Bug: b/286031590, b/297859713
Change-Id: Id65c525bc07fb0448fa762a5366064c422faf5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853726
Reviewed-by: Denny Huang <dennyh@google.com>
Commit-Queue: Bastian Kersting <bkersting@google.com>
Reviewed-by: Ethan Cheng <yycheng@google.com>
Cr-Commit-Position: refs/heads/main@{#1196486}
This change adds the runBluetoothScanningRoutine and
runBluetoothPairingRoutine extension function to the os.diagnostics
namespace.
Temporarily put them behind `TelemetryExtensionPendingApprovalApi`
feature flag.
BUG=b:294804121
TEST=unit_tests --gtest_filter="*DiagnosticsServiceConvertersTest*"
TEST=unit_tests --gtest_filter="*DiagnosticsServiceAshTest*"
TEST=browser_tests --gtest_filter="*Telemetry*" \
-ozone-platform=headless
TEST=out_linux_lacros/Release/bin/run_unit_tests \
--gtest_filter="*TelemetryExtension*"
TEST=out_linux_lacros/Release/bin/run_lacros_chrome_browsertests \
--gtest_filter="*TelemetryExtension*"
Change-Id: I61f9b0db6acd7fc5844e16a77eb85e60ce05ec2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4776900
Reviewed-by: Tim <tjudkins@chromium.org>
Reviewed-by: Kerker Yang <kerker@chromium.org>
Commit-Queue: Byron Lee <byronlee@chromium.org>
Auto-Submit: Byron Lee <byronlee@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/main@{#1184523}
Add implementation for reporting the external display info when
receiving an `ExternalDisplay` event.
The struct is defined by cros_healthd_probe.mojom and
probe_service.mojom, and included by cros_healthd_events.mojom and
telemetry_event_service.mojom.
The converters at the mojom level will reuse those defined in the
probe namespace already.
Since chromium IDL does not support import, we will define two
separate definitions at the IDL level.
Bug: b/289312077
Test: unit_tests --gtest_filter="*Telemetry*Event*"
Test: extensions_unittests --gtest_filter="*TelemetryExtension*"
Test: browser_tests --gtest_filter="*TelemetryExtensionEventsApi*"
Change-Id: Ibe8bde270fe0e8281932b38dfdb160a85a12d674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4714188
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Bastian Kersting <bkersting@google.com>
Commit-Queue: Ethan Cheng <yycheng@google.com>
Cr-Commit-Position: refs/heads/main@{#1179447}
