Assert that the constructor message loop is non-NULL only when
the SequencedWorkerPool is about to be destroyed.
Revert now-unneccessary test changes that adds MessagePools for
SequenedWorkerPool.
BUG=117940
TEST=
Review URL: http://codereview.chromium.org/9699115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127335 0039d316-1c4b-4281-b951-d872f2087c98
This prevents strange races with other tests.
Add an OnDestroy() method to SequencedWorkerPool::TestingObserver().
Fix a bug where one test wasn't calling Shutdown() on its
WorkerPools.
Fix a deadlock if a Worker object releases the last ref to the WorkerPool.
BUG=115987
TEST=
Review URL: http://codereview.chromium.org/9558007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125152 0039d316-1c4b-4281-b951-d872f2087c98
This class was hitting a ThreadRestrictions assert because it called
OpenFile on the UI thread. To reduce unnecessary copying, I've changed
the OnTraceDataCollected argument from std::string to RefCountedString.
Second attempt (originally committed in 123140, reverted in 123146).
Added DISALLOW_COPY_AND_ASSIGN to fix Windows compilation error.
BUG=None
TEST=content_unittests
Review URL: http://codereview.chromium.org/9443020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123433 0039d316-1c4b-4281-b951-d872f2087c98
Reverted since it causes compile failure on Win/Aura.
(scoped_refptr of TraceSubscriberStdioImpl which is only forward-declared)
This class was hitting a ThreadRestrictions assert because it called
OpenFile on the UI thread. To reduce unnecessary copying, I've changed
the OnTraceDataCollected argument from std::string to RefCountedString.
BUG=None
TEST=content_unittests
Review URL: http://codereview.chromium.org/9333003TBR=husky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9447003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123146 0039d316-1c4b-4281-b951-d872f2087c98
This class was hitting a ThreadRestrictions assert because it called
OpenFile on the UI thread. To reduce unnecessary copying, I've changed
the OnTraceDataCollected argument from std::string to RefCountedString.
BUG=None
TEST=content_unittests
Review URL: http://codereview.chromium.org/9333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123140 0039d316-1c4b-4281-b951-d872f2087c98
