chromium/src
0
Fork 0
Code Activity
861,173 Commits 3 Branches 23,233 Tags
d94e95b70d7ff72333004adc1fb0e647f3258952
Commit Graph

3 Commits

Author SHA1 Message Date
Joey Arhar
71a7c70b50 Reland "Add pixel browsertests for form controls refresh" 
These tests will run on Android, which will give us test coverage of the
form controls refresh on android, and add coverage to the untested
NativeThemeAndroid and WebThemeEngineAndroid classes.

Original patch: http://crrev.com/c/1940880
Revert: http://crrev.com/c/1968769

TBR=avi@chromium.org

Bug: 1029102
Change-Id: I74ce99782bc0e2f813e2567d447960f495715c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969772
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728099}
 2020-01-03 01:18:29 +00:00
Nancy Wang
c591325f0a Revert "Add pixel browsertests for form controls refresh" 
This reverts commit 0615596636.

Reason for revert: <INSERT REASONING HERE>
Broke build:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/30167

Original change's description:
> Add pixel browsertests for form controls refresh
> 
> These tests will run on Android, which will give us test coverage of the
> form controls refresh on android, and add coverage to the untested
> NativeThemeAndroid and WebThemeEngineAndroid classes.
> 
> Bug: 1029102
> Change-Id: I4d31c62054fb9905e445d9deb11aa36337233fc0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940880
> Commit-Queue: Joey Arhar <jarhar@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#724879}

TBR=avi@chromium.org,danakj@chromium.org,masonfreed@chromium.org,jarhar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1029102
Change-Id: Iade55f7c35303ecda5d5d36a040c1959ecdec8a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968769
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724986}
 2019-12-16 00:15:01 +00:00
Joey Arhar
0615596636 Add pixel browsertests for form controls refresh 
These tests will run on Android, which will give us test coverage of the
form controls refresh on android, and add coverage to the untested
NativeThemeAndroid and WebThemeEngineAndroid classes.

Bug: 1029102
Change-Id: I4d31c62054fb9905e445d9deb11aa36337233fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940880
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724879}
 2019-12-14 02:03:06 +00:00