0
Commit Graph

4 Commits

Author SHA1 Message Date
Lowell Manners
1de5242e96 Convert integers to blink::mojom::ConsoleMessageLevel where feasible.
In cases where the code treats the logging level as an int, we
explicitly convert ConsoleMessageLevel-->logging::LogSeverity, to
preserve the current behavior without relying on ConsoleMessageLevel
and logging::LogSeverity enum values being kept in sync.

TBR=rdevlin.cronin@chromium.org,thakis@chromium.org,clamy@chromium.org,jinsukkim@chromium.org,seantopping@chromium.org

Bug: 786836
Change-Id: Ibfa46371d9e1e3b26aff223fc395ea47ce1cc911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571663
Commit-Queue: Lowell Manners <lowell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653968}
2019-04-25 10:18:46 +00:00
Hazem Ashmawy
f1cd7e45e9 Add feature flag to log JS console messages in system logs
Add flag enable-logging-js-console-messages to allow logging JS console
messages to system logs instead of always logging it.

It's disabled by default because logs may contain PII. It should be
enabled for debugging purposes only.

Bug: 905251
Change-Id: Iee9b3fe2d9256e8fcf1f6e97499d555525f71f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528534
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643918}
2019-03-25 18:17:32 +00:00
Devlin Cronin
5bb996fe53 [ServiceWorkers] Update EmbeddedWorker interface to use ConsoleMessageLevel
Update EmbeddedWorkerInstanceHost to use the
blink::mojom::ConsoleMessageLevel enum, rather than an int32. This also
percolates out to the ServiceWorkerVersion, ServiceWorkerContextCore,
and ServiceWorkerContext observer classes, and the
content::ConsoleMessage struct.

Bug: None
Change-Id: I1e392ae7ab5ca2ff679c30057d45817358d3bbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501498
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637992}
2019-03-06 03:40:50 +00:00
Devlin Cronin
d8a25ee795 [ServiceWorkers] (Sometimes) log messages from ServiceWorker contexts
Log the console output from ServiceWorker contexts in the same cases
that we do for console messages for render frames (e.g., in debug mode
and for built-in components).

Extract the logging method to a separate method, used for logging from
both render frames and service workers.

Bug: 933265
Change-Id: I817dbb491c70cd36d1f2f220a19646c13308fd56
Reviewed-on: https://chromium-review.googlesource.com/c/1495044
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637037}
2019-03-02 00:38:13 +00:00