This CL moves |dom_content_loaded_| to
RenderFrameHostImpl::DocumentAssociatedData to make it clearer
that is is per-document. This will also prevents us from resetting the
value manually for DidCommitNewDocument, and failed navigation cases
which happens automatically with DocumentAssociatedData.
BUG=1237422
Change-Id: Icfe97639b360aed3ad20b49914bd1077374e8d67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3076476
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909930}
In http://crrev.com/c/2951481, I made it so that
every accessibility event marks its target node as dirty.
The first draft broke an important test -
NonInteractiveChangesAreBatched - because a
LayoutComplete event was marking the root object
dirty and triggering immediate updates rather than
deferred updates. To fix that, I made it so that
LayoutComplete didn't mark the root as dirty.
It turns out this caused a regression
(see crbug.com/1230823), so this patch uses a different
fix: let LayoutComplete mark the root dirty, but just
don't let that trigger an immediate update.
Bug: 1230823
AX-Relnotes: N/A
Change-Id: I7ad6fdda6c7831f10a71c0cae69a0defdd5655fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3072223
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909913}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
navigation_browsertest.cc
Bug: 1236525, 1124775
Change-Id: I473aded9954d3f734d3ad80c67b44dd0dbfb9b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074560
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909863}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
device_sensor_borwsertest.cc
Bug: 1236525, 1124775
Change-Id: Ide918566312a60b50bf601479f4e0932666c707a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074780
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909862}
We should never receive a request to confirm a before unload handler
for a prerender because that is gated on having sticky User Activation.
It is possible to receive it in other scenarios so we respond false if
we receive it. This code use to exist in WebContentsImpl but this makes
it consistent with the other JavaScriptDialog method which checks
IsActive inside RFHI.
Remove unused WillRunBeforeUnloadConfirm callback. Add a test as well.
BUG=1237034
Change-Id: I34ea029b79252016f051016d68682dd16c304cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075200
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909842}
These calls should never occur for the Prerender pages since they
require actual user gestures but can occur for BackForwardCached
pages. Return early and do nothing.
BUG=1237081
Change-Id: I62aa7485666ff2e32b517abbf2b911ff3a0b4776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075660
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909838}
Align with back/forward cache[1] and site isolation[2] which are 2 GB.
This diverges from NoStatePrefetch but is expected to be a more
reasonable threshold for prerendering.
[1] content::DeviceHasEnoughMemoryForBackForwardCache() at
content/common/content_navigation_policy.cc.
[2] site_isolation::SiteIsolationPolicy::ShouldDisableSiteIsolationDueToMemoryThreshold()
at components/site_isolation/site_isolation_policy.cc.
Bug: 1179158
Change-Id: Ib6dd260ffe0058ff9298d722a15dda2f2bc2d611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3077697
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909787}
* No need to make a new BrowserContext as the base class has one.
* Have the param matching tests use CreateWebContents which installs a
WebContentsDelegate, for consistency with the other tests.
Bug: 1126305
Change-Id: I204b237c0fcc0cadf93f599477c5c193188d3020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3077698
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909775}
This CL adds the `ExcludeSamePartyCrossPartyContext` exclusion reason
to CDP and includes this reasons for SameSite issues.
This issue can occur for both, 'set' and 'read' cookie operations.
The issue is also reported regardless if it was set/read via network
requests or via JavaScript. The issue is reported when the main
origin A makes a request to origin B, where both origins are in different
first party sets, but origin B either has previously set, or wants to
set a SameParty cookie.
The CL also adapts two existing SameParty web tests, that block a cookie
for this reason, and check that the issue is reported correctly. Note
that these tests only work with enabled first party sets.
Bug: 1179186
Change-Id: Ia96a09069f5f5adee5d37bdfee19f47240c8f715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3065656
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909729}
Overriding will use this engine instead of the default TTS Engine if it
is different.
Change-Id: I357507d1e5587040a71b8959d6001d2d96e812a8
Bug: b/194762836
Test: content_unittests for TtsControllerTest. Also, modified for test speech_synthesis_impl.cc to accept lang and engineId, and used web speech synthesis API to verify engineId override on Android.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3063756
Commit-Queue: Jeyashankher Ramamirtham <jeyashankher@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909687}
First patch toward the goal of respecting `--active-tab` argument
when `--pid` is used. Adds PID to selectors object in order
to unify the two paths BuildTreeForWindow and BuildTreeForSelector.
Bug: 1215960
Change-Id: Iaed58c03f4d25ffedb4eae72e50229786767f8c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3056865
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909668}
This reverts commit c0758ccefd.
Reason for revert: Suspected of causing test flakiness.
(See https://crbug.com/1237224.)
Original change's description:
> Disallow prerendering in supervised user mode
>
> With this change, the supervised user throttles cancel in a
> prerendered main frame since this is not yet supported.
>
> This change also includes a few updates to the prerendering
> test helper. It now supports use from SetUp in addition to
> SetUpOnMainThread. See crbug.com/1230090 about migrating
> all code to SetUp; keeping both functions was to reduce
> churn in this patch.
>
> I've also added a call to WaitForLoadStop in navigate
> primary page. This should not be required -- see
> crbug.com/1230068 for details.
>
> In order to use TestNavigationObserver, I needed to add
> support for observing uncommitted, unstarted navigations.
> This had some impact on test APIs, but it turned out that
> this parameter wasn't widely used so the churn appears
> minor.
>
> Bug: 1229685
> Change-Id: I23aa027ab02d1ccd93eb84dc062c662ae275c5d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3031862
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Dan S <danan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#906523}
Bug: 1229685
Change-Id: I9049df9ce694f4383e691c86d80ead6a93f14b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3076440
Auto-Submit: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Owners-Override: John Abd-El-Malek <jam@google.com>
Cr-Commit-Position: refs/heads/master@{#909605}
This change removes StorageKeyInUse method. It is only used by
Cache Storage (and AppCache which will be deprecated). LRU eviction
should give enough protection against currently active pages,
and rely on the use of NotifyStorageKeyAccess already used by
CacheStorage and consistent to other storage APIs. The
CL(https://codereview.chromium.org/1833673003) and
bug (https://crbug.com/581709) which introduces this method
does not state why this needs this special casing, and the bug
description specifically mentions that they would not add this change.
Change-Id: Ifce08e675c5137b448e7a5808837fd14aeada288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3078403
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909516}
It looks like the googletest documentation moved to a different folder
and the files were renamed. This CL updates the links to point to the
new location.
This CL fixes the links in /content/browser/indexed_db.
This CL was uploaded by git cl split.
R=dmurph@chromium.org
Bug: 1237544
Test: Manually verified this link is valid
Change-Id: I1d42b93844996b2c4c5303ec7b1adb5d3491d333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3078489
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909508}
This is a refactor to simplify UrlInfo constructors through the use of
a UrlInfoInit class. As UrlInfo is an important plumbing conduit, and
since it is likely we will add to it over time, this will make
maintenance easier.
Bug: n/a
Change-Id: Ib0fa27431dc2abc0fe3740172f6e19636e7412f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074663
Commit-Queue: W. James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909506}
This CL further refactors CopyOutputResult API to enable returning
multiple textures. Currently, the only format that supports returning
results via textures is RGBA, so the results only had to support a
single texture result. With the change, we are getting one step
closer to supporting returning pixels in I420 and NV12 formats via
native textures.
Notable changes:
- |CopyOutputResult::IsEmpty()| now only depends on whether the
rectangle is empty. Non-empty texture-backed CopyOutputResults must
not be created with zeroed out mailboxes (i.e. all mailboxes found
in planes are zero iff CopyOutputResult is empty) - this is enforced
via a newly added DCHECK.
- TextureResult can now contain up to 3 textures in its |planes| field.
Since only RGBA is currently supported, this is not yet leveraged.
- |CopyOutputResult::TakeTextureOwnership()| now returns a collection of
|ReleaseCallback|s that correspond to mailboxes contained in |planes|.
Part 2/N of zero-copy capture (go/zero-copy-capture), previous CL:
https://crrev.com/c/3044550
Bug: 1216287
Change-Id: Ic0c7be16c16327e01ac01b6d0c2ad69d585fe4b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3063989
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Mitsuru Oshima (gardener:slow) <oshima@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909477}
This CL introduces code to transfer a dedicated memory region
as described in (go/userspace-swap) to be used as a destination
for the MREMAP_DONTUNMAP operations. This memory area is chosen at
random in each renderer and transferred with the userfaultfd.
This CL additionally introduces code to query PA on swap and then
determine which of those regions is resident. This final set of areas
will be the areas which can be swapped (landing in the next CL).
BUG=b:172223747
Change-Id: I182c5350312e7d4121ae4931653fb513c81ca2a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059361
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909430}
Hiding WebAuthn UI was for SPC APIV2. APIV3+ should not be hiding the
WebAuthn UI. It would be up to the RP to to pass the correct parameters
into navigator.credentials.create() to ensure that there is no WebAuthn
UI being displayed.
Bug: 1234391
Change-Id: I3e726ce4ce6364dabedd90442bcb45fbe08530cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3060739
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909408}
Don't go through WebContents to replicate the page focus. This can
be done directly from the RenderWidgetHostImpl accessing the FrameTree
directly.
BUG=1237111
Change-Id: I790f508971918b3ffcc8a590326253b28f34acfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075661
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909321}
Instead of sending the direct composition surface handle from the
MediaFoundationService (utility/LPAC) process to the render process,
then register it in the GPU process via the browser process, we send the
handle from the MediaFoundationService process to the browser process,
which will forward the handle to the GPU process to be registered.
This eliminates the security risk of sending an arbitrary handle from
the low-privileged render process to the GPU process.
Also updated mojom interfaces to return an optional UnguessableToken,
because it's illegal to pass empty tokens across processes.
Bug: 999747
Test: Manually tested playback.
Change-Id: Ia8811010208c9a6ef7c5423754c0672ef050a6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3070658
Auto-Submit: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Frank Li <frankli@microsoft.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909317}
We are accessing the //extension module from different parts of the
code, just to verify whether an url has an extension scheme. There was
a first try to refactor this logic in r889472 implementing an scheme
registration in blink::SchemeRegistry; this is implemented in the
renderer::platform module, so we can't access from the //content
module in order to keep browser / render isolation.
We need to determine whether an url uses chrome-extension scheme from
both, the Browser and Renderer process, hence it's sensible that this
logic would be moved to blink/common. This implies that we must use
std types instead of platform/wtf (eg. std::string).
BUG=1197375
Change-Id: I9143f14de5e5cd84f58e36b0d185822fd41f692c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3006218
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909313}
DPUB-ARIA 1.1 eliminates doc-biblioentry and doc-endnote, but authors
can still get the same functionality by using a listitem (native or
ARIA) inside a doc-bibliography/doc-endnotes section.
This CL keeps the internal roles, and remaps listitems inside either
of the special containers.
An example of special functionality is the fact that UIA annotations
recognize endnotes.
Bug: 1236092
Change-Id: If6da4029819247c0619be04c29dbe041cc8ca687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069120
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/master@{#909302}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
indexed_db_feature_observer_browsertest.cc
Bug: 1236525, 1124775
Change-Id: Id6c30b3c31a9d1b3f92e275ffcab67699df0801a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074468
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909292}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
cross_origin_opener_policy_browsertest.cc
Bug: 1236525, 1124775
Change-Id: Ib9326d4d1faa136331e47ee77b73f61bca248fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074466
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909287}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
generic_sensor_browsertest.cc
Bug: 1236525, 1124775
Change-Id: I2a159474808b523c1a6796383b20d9bc703e84f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074599
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909285}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
render_frame_host_manager_browsertest.cc
Bug: 1236525, 1124775
Change-Id: I1ee51cc6562cf2de9fd5d6f87c1861d66e7385c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074782
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909282}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
cross_site_document_blocking_browsertest.cc
Bug: 1236525, 1124775
Change-Id: Ie38a06d063664a9bfe9fec900adcd7345edbf9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075179
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909279}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
keyboard_lock_browsertest.cc
Bug: 1236525, 1124775
Change-Id: I3117219d44b7132a9c5c48628b88096399e4a47f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074882
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909274}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
webauth_browsertest.cc
Bug: 1236525, 1124775
Change-Id: Idb3d2b543dcf2df2afd5e6f7f3937a7ea059e1aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074470
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909267}
'--ignore-certificate-errors' is bad, because its behavior is not
plumbed correctly everywhere. As a result, its behavior is different
from using a real SSL certificate.
For tests that need to use multiple distinct sites (and not
just different origins), using either MockCertVerifier or
the net::EmbeddedTestServer::CERT_TEST_NAMES can allow multiple
distinct sites to talk to the test server.
Currently folks, are copy-pasting existing tests with
"ignore-certificate-errors". It would be lovely to update existing test
so that folks can start copy-pasting the "good" way instead.
This patch updates:
lock_manager_browsertest.cc
Bug: 1236525, 1124775
Change-Id: I7de1d86cbcba1ef58869c01c8f4c70008112906a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074784
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909264}
