0
Commit Graph

14 Commits

Author SHA1 Message Date
Avi Drissman
adac219925 Update header includes for /base/functional in /content
bind.h, callback.h, callback_forward.h, and callback_helpers.h
moved into /base/functional/. Update the include paths to
directly include them in their new location.

Bug: 1364441
Change-Id: I32ec425b9c0e52ec4b50047bf3290fecc5c905ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4148554
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091567}
2023-01-11 23:46:39 +00:00
Sean Maher
a539a158cb Task posting v3: refactor base::PostTaskAndReplyWithResult
Change all instances of base::PostTaskAndReplyWithResult(task_runner
to task_runner->PostTaskAndReplyWithResult(.

This also removes includes of base/task/task_runner_util.h, but only
in the files with 'base::PostTaskAndReplyWithResult' which don't refer
to PostTaskAndReplyWithResult in other places.

Code was refactored with the following scripts:
python script:
https://paste.googleplex.com/5117849478627328
shell script:
https://paste.googleplex.com/4961540519231488

Bug: 1026641
Change-Id: Ifb34b3b9078440dda5902b0d694cb8d3f315dfe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892903
Commit-Queue: Sean Maher <spvw@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076288}
2022-11-28 18:13:41 +00:00
Avi Drissman
4e1b7bc33d Update copyright headers in content/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
No-Presubmit: true
Bug: 1098010
Change-Id: I8c0f009d16350271f07d8e5e561085822cc9dd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895935
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047456}
2022-09-15 14:03:50 +00:00
Matt Menke
e29b177330 Migrate font list code from base::ListValue to base::Value::List.
base::ListValue is deprecated.

Bug: 1339708
Change-Id: Ib852b2aba9e2e23bd7dcdf68e1f326019542d602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3730136
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019622}
2022-06-30 14:39:58 +00:00
Patrick Monette
643cdf6190 Replace base/task/ temporary forward headers with their final locations
Note to QA: This merely changes includes and should not be blamed
for files it touched.

Bug: 1255932
Change-Id: I1ce4e31efd5792ebf2080812e665cae838a54972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226943
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932153}
2021-10-15 19:13:42 +00:00
Patrick Monette
3d7d70920a Replace task-related headers to their equivalent in base/task/
This CL was generated by using tools/git/move_source_file.py to change
the includes for those files:
base/bind_post_task.h
base/deferred_sequenced_task_runner.h
base/post_task_and_reply_with_result_internal.h
base/sequenced_task_runner.h
base/sequenced_task_runner_helpers.h
base/single_thread_task_runner.h
base/task_runner.h
base/task_runner_util.h
base/updateable_sequenced_task_runner.h

Then formatted using "git cl format". DEPS files were fixed with a
simple search and replace script.

Bug: 1255932
Change-Id: I0d9b5ddd9260fde5e4581e6c6e0080bdb0ed2c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209175
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929867}
2021-10-08 20:27:23 +00:00
fdoray
26f887dbd7 Remove content::kFontListSequenceToken.
SequencedWorkerPool and named sequence tokens are being
deprecated in favor of TaskScheduler.

BUG=667892

Review-Url: https://codereview.chromium.org/2886883003
Cr-Commit-Position: refs/heads/master@{#472794}
2017-05-18 14:11:22 +00:00
dcheng
5971627d34 Convert //content/browser from scoped_ptr to std::unique_ptr
BUG=554298
R=avi@chromium.org

Review URL: https://codereview.chromium.org/1874893002

Cr-Commit-Position: refs/heads/master@{#386285}
2016-04-09 05:20:41 +00:00
dcheng
36b6aec9a5 Convert Pass()→std::move() in //content/browser
BUG=557422

Review URL: https://codereview.chromium.org/1545243002

Cr-Commit-Position: refs/heads/master@{#366894}
2015-12-26 06:17:30 +00:00
falken@chromium.org
bc96dad502 Use sequenced workers for the getting the system's font list.
This is necessary because on Linux we use Pango, which is not threadsafe (only newer versions are).


BUG=223772

Review URL: https://chromiumcodereview.appspot.com/13458002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192307 0039d316-1c4b-4281-b951-d872f2087c98
2013-04-04 12:01:35 +00:00
yzshen@chromium.org
4ef18aaad5 Change GetFontListAsync() to use the blocking pool.
PPB_Font_Dev.GetFontFamilies() is a sync operation that waits for GetFontListAsync() to finish on the FILE thread in the browser process.
If the thread is busy, it could hang for quite a while.
Some Pepper Flash hangs are caused by this.

BUG=155931
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11143028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162383 0039d316-1c4b-4281-b951-d872f2087c98
2012-10-17 13:22:18 +00:00
jam@chromium.org
ec810db7e4 Move font_list_async.h to content/public. Switch to Pass() goodness to simplify code.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9500008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124224 0039d316-1c4b-4281-b951-d872f2087c98
2012-02-29 19:20:14 +00:00
joi@chromium.org
c38831a108 Split BrowserThread into public API and private implementation, step 1.
Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.

A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.

Also moved BrowserProcessSubThread into content/ namespace.  As part
of follow-up cleanup, chrome/ will stop using this class.

BUG=98716
TEST=existing

Review URL: http://codereview.chromium.org/8392042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
2011-10-28 12:44:49 +00:00
brettw@chromium.org
d259a8ecab Support getting the font list in Pepper. This currently only works out of
process.

This adds a function to the font interface to get the font list. Since we
don't have arrays or dictionaries in Pepper yet, I used a string with nulls
separating the names. A previous attempt to make a "font list resource" proved
excessively complicated and not actually much easier for clients to deal with.

This refactors the existing font list getting that used to be in the options
for the browser. I moved it to content and split it into two pieces, the
synchronous version, and then an asynchronous wrapper around that which both
the prefs code and the pepper code use. This cleaned up some of the preferences
code, and also fixes the leak of the entire font list in the code.

I used the new callback/bind system for the async font loading. I had to add
BrowserThread support for the new system.

This uses the PepperMessageFilter to listen for font load requests from the
plugin in the browser process. This is nice because we can add stuff here and
have messages serviced for both in-process and out-of-process plugins. This
proved to be complicated due to the HostResolver used in some of the existing
code, and thread restrictions for how to deal with it. This is why there are
two modes for the filter object.

I changed the delegates around for the Dispatcher. Now the PluginDispatcher
has the delegate interface since the HostDispatcher didn't actually need any
of them and we were accumulating a lot of empty functions in the
PepperPluginRegistry.

It's possible for the fonts to be loaded on Windows and Mac without IPC, since
enumerating fonts should be possible inside the sandbox. I didn't implement
this since it adds extra complexity and probably doesn't give that much
benefit.

TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/7044012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85827 0039d316-1c4b-4281-b951-d872f2087c98
2011-05-18 22:31:09 +00:00