This change adds #include <string> to files currently including
"base/strings/string16.h". This prepares these files for the planned
removal of the base::string16 alias.
In order to adhere to the style guide [1] the following logic was
performed:
* Insert into an existing block of C++ STL includes, if possible
* Else insert `#include <string>` followed by a newline before the first
#include "some_header.h" line that is not referring to a matching header
(only relevant for implementation and test files)
[1] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
Bug: 1184339
Change-Id: I96660fec3fff0192d53e9728bbbae86228a52c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2749296
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861966}
Update EmbeddedWorkerInstanceHost to use the
blink::mojom::ConsoleMessageLevel enum, rather than an int32. This also
percolates out to the ServiceWorkerVersion, ServiceWorkerContextCore,
and ServiceWorkerContext observer classes, and the
content::ConsoleMessage struct.
Bug: None
Change-Id: I1e392ae7ab5ca2ff679c30057d45817358d3bbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501498
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637992}
Log the console output from ServiceWorker contexts in the same cases
that we do for console messages for render frames (e.g., in debug mode
and for built-in components).
Extract the logging method to a separate method, used for logging from
both render frames and service workers.
Bug: 933265
Change-Id: I817dbb491c70cd36d1f2f220a19646c13308fd56
Reviewed-on: https://chromium-review.googlesource.com/c/1495044
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637037}
