chromium/src
0
Fork 0
Code Activity
1,556,261 Commits 3 Branches 23,233 Tags
ee7dd7cbd77ca70f49d36ce7f0711f1fe72b7ef1
Commit Graph

171 Commits

Author SHA1 Message Date
Jesse McKenna
9b315d56e2 Remove obsolete group from docs 
This removes mention of the "Chromium UI Discussion" group from the
docs, as it seems to no longer be used.

Change-Id: I703c44c5c51555b9315017ba46364ff7108f0c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6289265
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422840}
 2025-02-20 15:27:53 -08:00
Keigo Oka
997bb97bba Fix typo in MVC overview 
Change-Id: I53dbf2d9b61de5af972976e742056d578622b044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6045557
Auto-Submit: Keigo Oka <oka@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1387652}
 2024-11-25 16:31:21 +00:00
Ted Choc
a4550c6402 Remove BlankUiTestActivityTestCase. 
Use BaseActivityTestRule<BlankUiTestActivity> instead.

Bug: 369884095
Change-Id: I6da19249d20fd31a369e00bee98f2a0d52fbca02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6035967
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1385154}
 2024-11-19 19:59:30 +00:00
Sinan Sahin
f12b140816 Update dynamic color doc with guidance on illustrations 
Change-Id: Ib0d98fd1ae8bfbd0efec838a7cdc43753605158f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958680
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1373416}
 2024-10-24 17:37:41 +00:00
Dirk Pranke
6afba327a9 Fix typo in graphic for //ui/docs/views/overview.md. 
The Client/Non-Client Views graphic in //ui/docs/views/overview.md
was slightly confusing because it referenced a ClientFrameView
class, which doesn't actually exist. I've updated the graphic
to just say ClientView, which now matches the text.

Change-Id: If9cafc5dd205f5a983597578528eca27ea3b1ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913967
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1365223}
 2024-10-07 23:29:27 +00:00
Theresa
a3bd803809 Add documentation about using attrs in Chrome Android styles/widgets 
Fixed: 366521621
Change-Id: I238bdaa2227cdf6a2110be5e549b2ecf2a3854e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904953
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363273}
 2024-10-02 20:28:47 +00:00
Luis Flores
9f2ac33ff8 Fix typo in text rendering docs 
This change fixes the grammatical error in unicode_overview.md.

Bug: 363034680
Change-Id: I8941b3a123ef2d119c34a77ae393c207296f3676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878958
Reviewed-by: Sam Fortiner <samfort@microsoft.com>
Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com>
Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1358896}
 2024-09-23 18:43:54 +00:00
Dirk Pranke
abe3779188 Fix typo in //docs/ui/views/widget_destruction.md. 
In one place we had "NativeWidgetOwnsWidget" when it should've
been "WidgetOwnsNativeWidget".

Change-Id: I9734b906f65201966ad7130f9e502a6c5b49dd84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5867107
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1356154}
 2024-09-16 21:59:23 +00:00
Allen Bauer
b8a5cf2ada Add README.md to ui/actions for better documentation. 
Change-Id: I26461fe42eb6ee367b9a2d8e8c029c26f8fbb86c
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826988
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350745}
 2024-09-04 13:03:23 +00:00
Kurt Catti-Schmidt
ccdbd914e7 [Harfbuzz] Update readme with new font-based fallback behavior 
Updating the readme to reflect the new reality based on changes in
https://chromium-review.googlesource.com/c/chromium/src/+/5634309

Bug: 40270295, 40267908
Change-Id: I6d58193678d6a6c2bd024e26198edebf60ec040f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5693152
Reviewed-by: David Yeung <dayeung@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1347457}
 2024-08-27 17:18:49 +00:00
Keren Zhu
ebb9b36658 Remove View Bounds Highlighting from UI devtools doc 
This functionality was removed in https://crrev.com/c/5800473.

This was equivalent to --draw-view-bounds-rects. The command line can
still be used. Alternatively, hovering over an element in devtools still
draws its bounds rect in an overlay.

Change-Id: If7e529e6a82a53f9e29ef68cc1458586c638e853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5802377
Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345526}
 2024-08-22 17:38:51 +00:00
Keren Zhu
a805577b4c Fix bubble locking in UI DevTools and remove universal view rect drawing 
Ctrl+R to refresh the devtools no longer works when the devtools is in a
tab. Previously both the bubble locking and the universal view rect
drawing was implemented by intercepting refresh.

This patch replaces the old bubble locking with a "Bubble Locking"
checkbox on the chrome://inspect page. Also removes view rect drawing
which was not very useful because hovering over a UI element also draws
its rect in an overlay.

Bug: 360909061
Change-Id: I7a0bdb6a58eec3013b21f81dade3057f726468ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5800473
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344895}
 2024-08-21 17:22:31 +00:00
Md Hasibul Hasan
e914ad79c8 [UI] Use mojo enum for DialogButton 
This CL removes `DialogButton` enum from ui_base_types.h.
Replaces the uses of `DialogButton` with the mojo version.

The following script is used for replacing with different
folder name.
Script: https://issues.chromium.org/issues/355460976#comment2

AX-Relnotes: N/A
Bug: 355460976
Change-Id: I0e434801c89793103812966f1628f3fde1dfa1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5753903
Auto-Submit: Md Hasibul Hasan <hasibulhasan873@gmail.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Md Hasibul Hasan <hasibulhasan873@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1344085}
 2024-08-20 12:38:58 +00:00
Avi Drissman
ae99ae281f Update EventType names 
EventType will become an enum class, so all uses of its enum values
need a scope. Because we have to modify all usage anyway, modernize
the naming while doing that.

This is a mechanical change.

There will be a follow-up change to actually switch EventType to be
an enum class rather than an enum.

Bug: 285921876
Change-Id: I775af72e1803892e7a213f0ce1011ce828e012fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5725076
Owners-Override: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331307}
 2024-07-22 20:44:28 +00:00
Evelynn Kaplan
087e3eedf0 [a11y] Update doc View::SetAccessibleName to ViewAccessibility::SetName 
This CL updates a doc reference to `View::SetAccessibleName()`, which
was deprecated in favor of `ViewAccessibility::SetName()` in CL:5537333.

This CL is part of the ViewsAX project:
https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit.

Bug: 325137417
Change-Id: I29709f59d8e5dcfc29c00430e2ef443fd6ce6d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5723116
Commit-Queue: Evelynn Kaplan <evelynn.kaplan@microsoft.com>
Reviewed-by: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1329881}
 2024-07-18 23:08:28 +00:00
David Benjamin
1d737482da Fix (most of?) the remaining absl::optional references 
There were a lot of references in comments and documentation that
weren't previously picked up. Also a few references in code, which I
assume were a race condition with the bulk of the migration.

Bug: 40242125
Change-Id: Ia9f9332df8c389a55da7bc0b43732a2c1730d664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688859
Commit-Queue: David Benjamin <davidben@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325069}
 2024-07-09 19:54:35 +00:00
Brad Triebwasser
0df9a0ed4f Add docs/ui/display/multiscreen_testing.md 
Adds docs/ui/display/multiscreen_testing.md with a central (in-repo)
point for documenting multi-screen testing behavior and considerations. Adds comments to related tests to point to the document.

Also updates the flag in VirtualDisplayUtilWinInteractiveUitest to force
the test to run even without the driver detected.

Bug: 40111905
Change-Id: I468f3367643466325e9c17eb8c4fadc1e52fc0a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5581840
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318802}
 2024-06-24 21:40:32 +00:00
Elaine Chien
addfc74e5e [MVC] Update MVC docs 
Update stale links and additional notes.

Bug: 40208821
Change-Id: I6b9cd3a457b45e58eebac4a010bb58790b47fd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5589767
Auto-Submit: Elaine Chien <elainechien@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1308950}
 2024-05-31 22:55:42 +00:00
Erik Chen
a3bca21ae7 Modularize webui_util.h 
Several desktop-only methods are moved to webui_util_desktop. These
methods are marked as deprecated, as they use disallowed methods.

Bug: 339497734
Change-Id: I5f58ab882b8325581ec66290f69c98131fb3b6af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528814
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1299545}
 2024-05-10 21:52:01 +00:00
dljames
71303418b7 [ TabRestore ] Move restore types out of TabRestoreService 
Moves the tab restore structs Entry, Tab, Group, and Window out
of the TabRestoreService and into its own file.

The goal of this CL is to decouple LiveTabContext from
TabRestoreService, which includes LiveTabContext. Doing this will allow
us to pass the Tab, Group, and Window types as parameters to functions
such as LiveTabContext::AddRestoredTab instead of passing all the fields
of the objects individually.

Change-Id: I2f30bb25f934806112333d67ed3586dade09fe46
Bug: 334170377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5449978
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1288110}
 2024-04-16 16:48:36 +00:00
Allen Bauer
7a42dd910c Remove support for single-param METADATA_HEADER macro and 3-param BEGIN_METADATA macro. 
Bug: 1485768
Change-Id: I3f3054d5311a463985b71df5110abe84c1ce0547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5299618
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261950}
 2024-02-16 23:08:54 +00:00
Benjamin Beaudry
3c8e24ec3e Add documentation for dip to screen conversion on Windows 
Follow up on CL:5239465 and CL:5253303. The content here is strongly inspired/copied from
https://source.chromium.org/chromium/chromium/src/+/main:ui/display/win/screen_win.cc;l=314.

All credit goes to the person(s) who wrote comment.

Change-Id: Ib534bfcfdb259746ce9e51658b886197be8c006d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5302345
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261807}
 2024-02-16 19:10:32 +00:00
Lijin Shen
c02846b9ba Fix a broken link in browser_controls.md 
Bug: None
Change-Id: Id180e467fcc27f9a156a0ba23d5917a3f5ba89ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296687
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Auto-Submit: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/main@{#1260706}
 2024-02-14 21:33:52 +00:00
Jeff Yoon
f75905058e [buganizer] Migrate remaining DIR_METADATA in chromium/src 
Migrate all remaining DIR_METADATA in chromium/src.

Verify components with http://b/components/{id} or at
go/chrome-on-buganizer-prod-components.

Bug: chromium:1518875
Change-Id: I025c51f2bbe35f95fbb62f0d308f1ff1d0b438c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5288611
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Arthur Eubanks <aeubanks@google.com>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
Cr-Commit-Position: refs/heads/main@{#1259938}
 2024-02-13 18:38:14 +00:00
Allen Bauer
64d99144d5 Update Metadata docs and comments. 
Bug: 1485768
Change-Id: Id4a4488adf10de728d0278bb66dbd617e038e6c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278430
Reviewed-by: David Yeung <dayeung@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258052}
 2024-02-08 18:45:30 +00:00
Peter Kasting
f4b162eda9 Update docs for removal of SetChildViewIgnoredByLayout(). 
Bug: 1267319
Change-Id: I70d51e91d41844614afdcacaa69b51d81d9ab461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279008
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257952}
 2024-02-08 16:25:48 +00:00
David Yeung
73c594dd41 Add note to UI Dev tool doc about bubble lock. 
Clarify that devtools has to be the active window before attempting bubble lock.

Change-Id: I36798c2ee5a2e318d3f7beb8f76dba05e230ab3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5262384
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255683}
 2024-02-02 18:55:53 +00:00
Peter Kasting
1e3a1e996a Change View::Layout() to take a PassKey. 
This prevents direct access from outside View itself.

Must be landed as a single large CL, or LayoutSuperclass() will not
select the correct method to call.

Bug: 1521108
Change-Id: Id4e0439c048f26e55cc2189aa362e723662d0755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255142}
 2024-02-01 18:10:41 +00:00
Peter Kasting
df36f33ea6 Replace Layout() calls with DeprecatedLayoutImmediately(): docs/ 
Direct access to Layout() is being deprecated. This marks all callsites
for future fixing, and ensures they all go through the common layout
wrapper functions.

Bug: 1521108
Change-Id: I3adff3b9b005329096d2d1fbe960b1bf4b3da076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246255
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1254666}
 2024-01-31 19:21:34 +00:00
Peter Kasting
8e6535e64d Convert superclass Layout() calls to LayoutSuperclass<>(): docs/ 
Direct access to Layout() is being deprecated; this is the blessed way
to invoke it for this use case.

Bug: 1521108
Change-Id: Iae98dea60469f4a8279c5501bf6cb1f3defc594f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5244024
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253606}
 2024-01-29 23:05:39 +00:00
Peter Kasting
a4284caa64 Add LayoutImmediately(). 
This synchronously invokes Layout(). For now, it does nothing else, but
eventually it can do any pre-layout work necessary, e.g. collecting
metrics or setting state/access control variables.

Ultimately, this should become the only way for any code to reach
Layout().

Bug: 1521108
Change-Id: Idd40832c6e5f2d407e970a089d3c2801423922f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243921
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253558}
 2024-01-29 22:30:07 +00:00
Peter Kasting
94c0f2e056 Direct people to use RunScheduledLayout() as the preferred route. 
Calling LayoutRootViewIfNecessary() is fine, just less obvious.

Bug: none
Change-Id: I1ed1f951f616e49bf264da4e6d516c9e75359459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243697
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253372}
 2024-01-29 18:14:20 +00:00
Erik Chen
14380c4a7e update views documentation 
Change-Id: I7bcd3dd09c278628419b0ce7e866ff9dffc336e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5197896
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247739}
 2024-01-16 21:27:52 +00:00
Joseph Park
daba6597cb Update macro name and hyperlink. 
Change-Id: I93ac676d8c7f8f19adbde8cc17c13659ab93bfe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5080387
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Auto-Submit: Joseph Park <josephjoopark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232498}
 2023-12-03 19:19:07 +00:00
Takashi Toyoshima
33928e76dd ui/views/overview.md: update the stale BubbleDialogDelegateView link 
https://crrev.com/c/1171907 introduced bubble_dialog_delegate_view.h.
https://crrev.com/c/1171919 removed bubble_dialog_delegate.h and
recommended to include bubble_dialog_delegate_view.h instead.
So, this document change is a follow-up for these changes.

NOTRY=true

Bug: n/a
Change-Id: I502cb9a29e308f890f332851102277040f616964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5052470
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1229181}
 2023-11-27 06:41:05 +00:00
Elaine Chien
7894271095 [MVC] Edits to mvc developer guide 
Edits to model ownership based off of experiences with real features.

Bug: None
Change-Id: I1b7e6b5d2bd8042a9cc2e67a0a108f46392526e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4998599
Auto-Submit: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219546}
 2023-11-03 17:17:39 +00:00
Sam Maier
b1cb900579 Removing references to fragment_activity_replacer 
Bug: 1485106
Change-Id: I50b0dadefe42d16202938540aa9427881c2a8976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4927148
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207711}
 2023-10-10 16:42:55 +00:00
Sky Malice
430f74338e Linked dynamic colors doc to internal figma color mapping go link. 
Bug: 1224883
Change-Id: I58719fcc1cb99ad6e9dc6bcda62760c44a0e83b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4893402
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1203520}
 2023-09-29 23:07:24 +00:00
Aishwarya Rajesh
ea17bbdc76 [APS] Update tab container visibility and color on tab hover events 
TODO (crbug.com/1469949): Add fade-in animation on the TSR tab container on hover.

Demo: https://drive.google.com/file/d/1tuqrtr-LkzOdiYoVv7ORR8yvIbAuSYyo/view?usp=sharing

Screenshots:

GM2:
Light: https://screenshot.googleplex.com/APnXK87WCC56T8s
Dark: https://screenshot.googleplex.com/48pRov7iwiiRDg5
Incognito: https://screenshot.googleplex.com/3Xp67zZNxbpbzAB

Folio:
Light: https://screenshot.googleplex.com/4xpqG8fZ3gwEBoK
Dark: https://screenshot.googleplex.com/KbYjZph9AQv5E8c
Incognito: https://screenshot.googleplex.com/3Xd3LtjhwM6yjmY

Detached:
Light: https://screenshot.googleplex.com/39vA7ohVPWkMLGu
Dark: https://screenshot.googleplex.com/YAaoz2qf3xZeaw4
Incognito: https://screenshot.googleplex.com/9aE7dgb4tESg8hX

Low-Coverage-Reason: Tests for updates in this CL require execution on a tablet, that is not available in the CQ; adequate test coverage has been added for these changes.
Bug: 1451925
Change-Id: Ied4a403e46669a5b3bc9f95d33fe482919842411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717726
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com>
Reviewed-by: Neil Coronado <nemco@google.com>
Cr-Commit-Position: refs/heads/main@{#1180649}
 2023-08-08 02:11:15 +00:00
Elaine Chien
719e2d8c8b [MVC] Add developer guide to ui/views docs 
Bug: None
Change-Id: I3643337f306da49eb1d53a1f10199ffb7e8700d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721955
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1176167}
 2023-07-27 18:00:19 +00:00
Avi Drissman
a127340f6c Simplify lifetime reasoning of AppController: it's a singleton 
Make AppController be a singleton and to always be the
NSApp delegate. This simplifies reasoning about the code.

Bug: 1280317
Change-Id: Iebddee9077c9ec4f786a3e3307a10e812a187457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566530
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1149854}
 2023-05-26 19:17:43 +00:00
Joseph Park
528bc048a7 Update documentation involving deprecated GetSystemColor() 
Change-Id: I1c760b52d6029066d20262d7160eb41b294e601f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4518506
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Joseph Park <josephjoopark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1142287}
 2023-05-10 19:22:31 +00:00
Henrique Nakashima
485c8acf53 [Android] Replace LocalRobolectricTestRunner with RobolectricTestRunner 
LocalRobolectricTestRunner is just RobolectricTestRunner, so remove
that layer of inheritance. This prevents tests from using it instead of
BaseRobolectricTestRunner, which Clank tests should be using.

The Clank tests that were using LocalRobolectricTestRunner have been
migrated in past CLs.

The exceptions that shouldn't depend on base/ realistically won't need
common functionality, and even then we could use test rules.

Also update references to Local- in docs and DEPS exceptions that are not
needed anymore.

Bug: 1431327
Change-Id: I52b43058fe30c9004f2a3c90892683761805247c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4450326
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1134023}
 2023-04-21 20:38:25 +00:00
James Feister
b756267d24 Update doc for debug tools flag 
Bug: None
Change-Id: If39f2b9cffe0acfc2eccfd2b443733faa8f874d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420113
Reviewed-by: Zork <zork@chromium.org>
Commit-Queue: Zork <zork@chromium.org>
Auto-Submit: James Feister <jamesfeister@google.com>
Cr-Commit-Position: refs/heads/main@{#1129493}
 2023-04-12 21:19:05 +00:00
David Yeung
3bd204d0fa [views-examples] Improve views-example documentation 
Added links to each button example
Added gif to showcase the exe
Improved the general layout

Change-Id: I33978b25715b7aaf3784763739f18dc2fb43849a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288226
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109874}
 2023-02-24 23:17:37 +00:00
Peter Kasting
b4470df57c Improve contrast with pervasive system accent colors. 
This attempts to guarantee color visibility/readability in many more
scenarios. To do this, PickGoogleColorTwoBackgrounds() is moved to ui::.

Bug: 1413984
Change-Id: Idd8842449848cf3989996ead099e9cfad3d41f3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4283758
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1108711}
 2023-02-23 01:25:59 +00:00
Peter Kasting
198b59fc95 Add "starter guide" for those new to UI development. 
Bug: none
Change-Id: Ia5303c532cf90f4ffc4e45239ee0776dd7383bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4124329
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106385}
 2023-02-16 19:50:04 +00:00
David Yeung
f0d81e3b76 [Render text] Added variation selector to doc + fixed incorrect unicode 
Added a bit on variation selector codepoints and fixed an incorrect codepoint in the airplane example

Change-Id: I849ad13b4408c8e3f2a0ff60aebe697ae8e30d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220143
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1101802}
 2023-02-06 21:54:16 +00:00
Elaine Chien
e1bda98709 [RenderText] Add documentation for overview of RenderText implementation 
Bug: None
Change-Id: I471e114f822f6a367508998bf798a201bebcf94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113163
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096417}
 2023-01-24 22:13:06 +00:00
David Yeung
63470481ba [RenderText Doc]: Unicode overview 
Adding documentation on how Unicode works wrt text rendering

Change-Id: I197b8272b91b21fd753dc47295f006b8da28438f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098976
Commit-Queue: David Yeung <dayeung@chromium.org>
Reviewed-by: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096253}
 2023-01-24 17:49:32 +00:00