It was using DeprecatedListValue, which maps to the (also deprecated)
base::ListValue. Somewhat confusingly, mojom::ListValue maps to the
(non-deprecated) base::Value::List class.
Bug: 1301889
Change-Id: Ia00f736d9712b776c1e42a0056be5759bef9ff1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3685637
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010284}
In order to log activity events in extensions, we need to copy all the
arguments that were passed to the method or event. In some cases (such
as messaging), this can be an extreme amount of work. Additionally, this
can require passing objects from the IO to UI thread. In an extreme
case, we would also create copies of arguments sent via the activityLog
API itself - meaning that for any given API call, we created two extra
copies of all arguments (one for the activity log itself, and another
for the record of the activityLog event dispatch). In some cases, this
activity logging resulted in more work than the API call itself.
Instead, store state around which profiles have an actively-recording
ActivityLog and which extensions are whitelisted in a thread-safe manner
so that we can short-circuit the logging in most cases, and avoid
creating excessive copies for the 99% case.
BUG=620359
Review-Url: https://codereview.chromium.org/2077723002
Cr-Commit-Position: refs/heads/master@{#401162}
* Introduce ApiActivityMonitor interface and make ActivityLog implement it
* Use it to replace EventRouter's one-off EventDispatchObserver, which was
kind of ugly.
* Use it for function call notifications from ExtensionFunctionDispatcher
This allows app_shell to use ExtensionFunctionDispatcher without an
ActivityLog and gets us another step closer to moving EFD into src/extensions.
BUG=332986,339595
TEST=browser_tests Extension*
Review URL: https://codereview.chromium.org/155183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249324 0039d316-1c4b-4281-b951-d872f2087c98
