0
Commit Graph

107 Commits

Author SHA1 Message Date
Mitsuru Oshima
b406ceb440 Remove Lock screen apps [] : remove lock screen extension
* Remove from api features, permission code, idl
* Remove kLockscreenExtension mojo context type.
* Remove extensions/browser/api/lock_screen_data.
* Remove lock screen app related properties, and methods.
* Remove test data

Bug: 376354347

Change-Id: I109b861bd0f58e90ed84d3c12c28e95a496a2521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6005846
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1383324}
2024-11-14 23:57:21 +00:00
Peter Boström
38412897b2 Migrate to NOTREACHED() in extensions/
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
The former is [[noreturn]] so this CL also performs dead-code removal
after the NOTREACHED().

This CL does not attempt to do additional rewrites of any surrounding
code, like:

if (!foo) {
  NOTREACHED();
}

to CHECK(foo);

Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.

Bug: 40580068
Change-Id: I80696f361f79908132f9a0e3d8654592f2e37c13
Low-Coverage-Reason: OTHER Should-be-unreachable code
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5951563
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1371865}
2024-10-22 06:31:49 +00:00
Peter Kasting
1cb99aba7e Reland: Remove force_guest_profile param from context getters.
The only place that didn't hardcode "true" for this can express what it
wants more clearly with constexpr if anyway.

Bug: 364987728
Change-Id: I27cbdf0ac7ac358392af5ea8d6c9257666af6a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938992
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1369550}
2024-10-16 19:04:40 +00:00
David Bertoni
ef03e75fcd Revert "Remove force_guest_profile param from context getters."
This reverts commit 27fbab770c.

Reason for revert: Breaking Android desktop builds: https://ci.chromium.org/ui/p/chromium/builders/ci/android-desktop-x64-compile-rel/3588/overview

Original change's description:
> Remove `force_guest_profile` param from context getters.
>
> The only place that didn't hardcode "true" for this can express what it
> wants more clearly with constexpr if anyway.
>
> Bug: 364987728
> Change-Id: I13ab42c9cebacd16deb7022ca7c6cd54d514a320
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912179
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: David Bertoni <dbertoni@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Commit-Queue: David Bertoni <dbertoni@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1369085}

Bug: 364987728
Change-Id: I564b5e06209deb4a40f968e1856fcac2de946a34
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935817
Owners-Override: Alan Cutter <alancutter@google.com>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1369104}
2024-10-15 23:59:53 +00:00
Peter Kasting
27fbab770c Remove force_guest_profile param from context getters.
The only place that didn't hardcode "true" for this can express what it
wants more clearly with constexpr if anyway.

Bug: 364987728
Change-Id: I13ab42c9cebacd16deb7022ca7c6cd54d514a320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912179
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1369085}
2024-10-15 23:04:03 +00:00
David Bertoni
b102cfa2fb [Extensions] Do lacros cleanup in extensions/browser.
This CL cleans up Lacros-specific code in this directory and its
subdirectories by doing the following:

1. Lacros-specific sections are removed from BUILD.gn files.
2. References to is_chromeos_ash in BUILD.gn files are collapsed to
is_chrome. Some blocks are merged as a result.
3. Uses of BUILDFLAG(IS_CHROMEOS_ASH) are collapsed to
BUILDFLAG(IS_CHROMEOS) and some adjacent ifdef blocks are combined.
4. ifdef blocks defined by BUILDFLAG(IS_CHROMEOS_LACROS) are deleted.

Bug: b:354842935
Change-Id: I5e2462314e8ce544353681b78978465d635e4b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5894159
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Tim <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363188}
2024-10-02 18:23:13 +00:00
Solomon Kinard
f9fe077e00 Extensions: Add curly braces to reduce cognitive load & range-based loop
* Use range-based for loop instead. clang-tidymodernize-loop-convert
* Use emplace_back instead of push_back. clang-tidymodernize-use-emplace

This CL was uploaded by git cl split.

R=emiliapaz@chromium.org

Bug: chromium:346952289
Change-Id: I78b0eac747d27d1c67f5c8d7e58ab398a422b1ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5858197
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Auto-Submit: Solomon Kinard <solomonkinard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1355459}
2024-09-13 22:42:11 +00:00
Avi Drissman
e20f1d97f8 Use an opaque type for FrameTreeNode IDs, part 8
extensions

This landed earlier as https://crrev.com/c/5837697 but was reverted
because a new override was added in the window of time between the
green trybots and the CQ committing the CL.

Bug: 361344235
Change-Id: I5458fe5936510949ba79f41f06678bd1e7e938d3
Low-Coverage-Reason: LARGE_SCALE_REFACTOR
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837249
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351549}
2024-09-05 17:45:40 +00:00
Avi Drissman
0c9effa303 Revert "Use an opaque type for FrameTreeNode IDs, part 8"
This reverts commit dbbd595583.

Reason for revert: Raced new code and broke it.

Original change's description:
> Use an opaque type for FrameTreeNode IDs, part 8
>
> extensions
>
> Bug: 361344235
> Low-Coverage-Reason: LARGE_SCALE_REFACTOR
> Change-Id: I1be3d49361de6b3d06164a5bd56604411d321f2c
> Include-Ci-Only-Tests: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837697
> Reviewed-by: David Bertoni <dbertoni@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Auto-Submit: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1350982}

Bug: 361344235
Change-Id: Ie43e652d08d6f8afa1e5c43b1ca70bf58441f996
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836231
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351110}
2024-09-04 23:20:00 +00:00
Avi Drissman
dbbd595583 Use an opaque type for FrameTreeNode IDs, part 8
extensions

Bug: 361344235
Low-Coverage-Reason: LARGE_SCALE_REFACTOR
Change-Id: I1be3d49361de6b3d06164a5bd56604411d321f2c
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837697
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350982}
2024-09-04 19:17:46 +00:00
Devlin Cronin
f9ffc4e2bf [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
There are different variations of the ExtensionWebContentsObserver based
on the embedder (i.e., one for Shell and one for Chrome). Instead of
having individual callers know about this distinction, instantiate these
WebContentsObservers through the ExtensionsBrowserClient by introducing
ExtensionsBrowserClient::CreateExtensionWebContentsObserver(). The
ExtensionsBrowserClient already had knowledge of these for the
related GetExtensionWebContentsObserver() method, and this allows more
code to be shared across different build configurations.

This CL should have no behavior change.

Bug: 356905053
Change-Id: I75acd6cb2a0a151d193c596d97509c5b26700910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5825636
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350962}
2024-09-04 18:49:53 +00:00
Devlin Cronin
564fee74c7 [Desktop Android CRX] Compile sources in //extensions/test
We are experimenting with desktop-android configurations for Chrome.

This CL adds the //extensions:test_support target to the experimental
desktop-android build config. This includes lots of test utilities
in //extensions/test, as well as a few test utilities in other
directories. A few of these sources are still not compiled due to
dependencies they have on other pieces (platform apps, guest view, or
other APIs).

This is currently experimental and has no production behavior changes.

Cq-Include-Trybots: luci.chromium.try:android-desktop-arm64-compile-rel,android-desktop-x64-compile-rel

Bug: 356905053
Change-Id: Id3c3b73df13cbc14b55de56ca8e31126e9fcc619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789202
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342027}
2024-08-14 23:41:10 +00:00
Solomon Kinard
802b9ead3a Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
If `use_dynamic_url` is set to true in manifest.json, then the
associated web accessible resource(s) can only be loaded using the
dynamic url. Loading with the static url containing the extension id
won't work.

Doc:
https://docs.google.com/document/d/1nBSPaqbkr9O2X8F1EEZSh9_LT7IcYx-WnwkzmpxyN2I

Bug: chromium:40245983
Change-Id: I2a6782e327ceb4c02f76e081ef55f560b4f2771a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5636785
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325435}
2024-07-10 13:06:36 +00:00
Peter Boström
50f25ff0e7 Use NOTREACHED_IN_MIGRATION() in extensions/
This was generated by replacing "  NOTREACHED()" with
"  NOTREACHED_IN_MIGRATION()" and running git cl format.

This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.

Bug: 40580068
Change-Id: I56c9ab2c7720718136317c515d32d7f627272284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540271
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300936}
2024-05-14 22:28:42 +00:00
Robbie McElrath
0e6e4e0637 iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
This updates RegisterNonNetworkSubresourceURLLoaderFactories to only
create an IsolatedWebAppURLLoaderFactory if the requesting origin is
an Isolated App, and adds a parameter to IsolatedWebAppURLLoaderFactory
to let it optionally be locked to a specific app so an IWA can only
request resources from its own bundle.

IsolatedWebAppURLLoaderFactory created for navigations aren't
locked to a specific origin as navigation rules are enforced in
IsolatedWebAppThrottle.

Bug: b/335511141
Change-Id: Ibf0c31094dc96477849c47e34ece5d18f55d3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463431
Reviewed-by: Zelin Liu <zelin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298352}
2024-05-08 21:07:57 +00:00
Steven Bennetts
4fbfe07222 Add test for extensions::util::IsIncognitoEnabled for portal signin
BUG=b:261727502_
TEST=extensions_unittests --gtest_filter=RendererStartupHelperTestCaptivePortalPopupWindow.*

Change-Id: Ia3023c851ea7d65392f41996acad68b48a653232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246482
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1260542}
2024-02-14 17:33:54 +00:00
Anton Bershanskyi
c4788007ef [Extensions] Switch to ExtensionId (part 3)
Use a separate type ExtensionId for denoting Chromium Extension Id.

Bug: 1518483
Change-Id: I972d28c008661ffe8ac40a20ce22c6898a090564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245428
Commit-Queue: Tim <tjudkins@chromium.org>
Reviewed-by: Tim <tjudkins@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255675}
2024-02-02 18:46:43 +00:00
Chase Phillips
c4702491ab extensions: Add a loader for Controlled Frame embedder scripts
This CL modifies the extensions system so that when hosts of type
Controlled Frame embedder are used, content scripts that are specified
will be loaded using a fetcher that's provided via the Chrome embedder's
ExtensionsBrowserClient.

Bug: 1511295, b/316171914
Change-Id: Ie5c5aae9ef65c4e9abc690ad2a0d2fd5ae6f812f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202765
Reviewed-by: Ovidio Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249171}
2024-01-19 01:15:44 +00:00
Devlin Cronin
b9cd13b9e7 [Extensions] Avoid cast in ExtensionsBrowserClient::IsValidContext
ExtensionsBrowserClient::IsValidContext() has a static_cast from a
content::BrowserContext to a Profile object. However, if the object is
*not* a valid context (profile), this static cast is unsafe and can
cause clang to crash with an illegal operation exception.

Remove the static_cast'ing in these methods and also update them to take
in `void*`s rather than `content::BrowserContext*`s. This is inline with
the method they effectively map to (ProfileManager::IsValidProfile())
and also guarantees that the implementations don't use the values passed
on the chance they are invalid.

Note that there are more robust fixes for this issue that are being
investigated as part of a larger refactor, but this should fix the
immediate crash.

Bug: 1470579
Change-Id: I446a8e4ebd0289c96126abb5cd9775ef20b31c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4784198
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1184337}
2023-08-16 20:14:57 +00:00
Ryan Sultanem
64fc98306b Reland "[ProfileSelections] Transition extension keyed factories to use Profile Selections"
This is a reland of commit f93ee8bbfe

Original change's description:
> [ProfileSelections] Transition extension keyed factories to use Profile Selections
>
> Make sure that all extension factories (that do not use the
> BrowserContextKeyedAPI) use the Profile Selection logic through the
> ExtensionBrowserClient to have more control over different profile
> types.
> Mainly so that it stops being able to indirectly create services for the
> System Profile and be able to easily control the creation for the Guest
> Profile through the force variable.
>
> Changes:
> - `GetOriginalContext()` --> `GetContextRedirectedToOriginal()`
> - `context` --> `GetContextOwnInstance()`
> - no implementation --> `GetContextForOriginalOnly()`
>
> These changes will indirectly cause those services not to be able to be
> created for the System Profile, and the creation for the Guest Profile
> will be dependant on the `force_guest_profile` variable.
>
> Also added protections to some stacks in extensions to return early in
> case of System Profile (Extensions are disabled in the System Profile).
>
> Bug: 1284664
> Change-Id: I1ca9a345ca769ef42cb17ae38516a399283c4fd2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4665672
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: Ryan Sultanem <rsult@google.com>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1171652}

Bug: 1284664
Change-Id: Icc4150037510143bb7803301538af81856ca2037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4704704
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1173410}
2023-07-21 10:14:51 +00:00
David Roger
66b327d7f7 Revert "[ProfileSelections] Transition extension keyed factories to use Profile Selections"
This reverts commit f93ee8bbfe.

Reason for revert: causes crashes on Canary, see https://crbug.com/1466101

Original change's description:
> [ProfileSelections] Transition extension keyed factories to use Profile Selections
>
> Make sure that all extension factories (that do not use the
> BrowserContextKeyedAPI) use the Profile Selection logic through the
> ExtensionBrowserClient to have more control over different profile
> types.
> Mainly so that it stops being able to indirectly create services for the
> System Profile and be able to easily control the creation for the Guest
> Profile through the force variable.
>
> Changes:
> - `GetOriginalContext()` --> `GetContextRedirectedToOriginal()`
> - `context` --> `GetContextOwnInstance()`
> - no implementation --> `GetContextForOriginalOnly()`
>
> These changes will indirectly cause those services not to be able to be
> created for the System Profile, and the creation for the Guest Profile
> will be dependant on the `force_guest_profile` variable.
>
> Also added protections to some stacks in extensions to return early in
> case of System Profile (Extensions are disabled in the System Profile).
>
> Bug: 1284664
> Change-Id: I1ca9a345ca769ef42cb17ae38516a399283c4fd2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4665672
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: Ryan Sultanem <rsult@google.com>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1171652}

Bug: 1284664, 1466101
Change-Id: I4f8b486a0af56172bc2ff90839235bb53ce1c4e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4701020
Owners-Override: Prudhvikumar Bommana <pbommana@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1172835}
2023-07-20 08:59:56 +00:00
Ryan Sultanem
f93ee8bbfe [ProfileSelections] Transition extension keyed factories to use Profile Selections
Make sure that all extension factories (that do not use the
BrowserContextKeyedAPI) use the Profile Selection logic through the
ExtensionBrowserClient to have more control over different profile
types.
Mainly so that it stops being able to indirectly create services for the
System Profile and be able to easily control the creation for the Guest
Profile through the force variable.

Changes:
- `GetOriginalContext()` --> `GetContextRedirectedToOriginal()`
- `context` --> `GetContextOwnInstance()`
- no implementation --> `GetContextForOriginalOnly()`

These changes will indirectly cause those services not to be able to be
created for the System Profile, and the creation for the Guest Profile
will be dependant on the `force_guest_profile` variable.

Also added protections to some stacks in extensions to return early in
case of System Profile (Extensions are disabled in the System Profile).

Bug: 1284664
Change-Id: I1ca9a345ca769ef42cb17ae38516a399283c4fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4665672
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171652}
2023-07-18 09:15:42 +00:00
Ryan Sultanem
eddd89d6d7 [ProfileSelections] Rename and cleanup ExtensionsBrowserClient functions
Rename functions in the ExtensionsBrowserClient related to Profile
Selections so that they match the Profile Selections terminalogy.
Also removed the `force_system_profile` parameters to simplify the usages, as the System Profile is never used in the Extensions context (the variable was always false, triggering no effect for the System Profile).

Bug: 1284664
Change-Id: Ib272e5e83ce98222a216a2a298f272b6322fbfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4665670
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1167973}
2023-07-10 09:16:27 +00:00
Yeunjoo Choi
b0df2b5509 Migrate //chromeos/ash/components/login/login_state to namespace ash
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.

Change-Id: I4f4b9a8b3cf3bff373b2f143e0a5733517a4c9b1
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066032
Owners-Override: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yeunjoo Choi <ychoi@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078482}
2022-12-02 07:57:06 +00:00
Yeunjoo Choi
2dade3c74b Move //chromeos/{=>ash/components}/login/login_state
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.

Change-Id: Ic414b7031e254e5dbc96518429237f4eaf2f364a
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4061818
Owners-Override: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yeunjoo Choi <ychoi@igalia.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077856}
2022-12-01 04:00:53 +00:00
Avi Drissman
60039d4d4b Update copyright headers in extensions/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
Bug: 1098010
Change-Id: I92587d82572fb164300a4165a153102982a277dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894332
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046592}
2022-09-13 21:49:05 +00:00
Ryan Sultanem
9a1db07e62 Extension factories to be part of kSystemProfileSelectionDefaultNone
Since KeyedServiceFactory under extensions/ cannot inherit from
`ProfileKeyedServiceFactory` to benefit from the default values for
System and Guest profiles, this will be done through the
`ExtensionsBrowserClient` by adding the equivalent of ProfileSelections
experimental builders methods which will provide a check on the
experiment (follows the same logic as ProfileKeyedServiceFactory, using
ProfileSelections experimental builder).
Also these methods will take a parameter to allow to force the creation
even within the experiment, in case certain Services still need to be
created for the System Profile.

Adapted the main extensions/ base factory to use these new methods
`BrowserContextKeyedAPI`, other independent factories can still use the
new methods from the ExtensionsBrowserClient.

Bug: 1284664
Change-Id: I287253ed5176ffd17904ab37b6ec6fb38be11e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854601
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1043990}
2022-09-07 15:54:46 +00:00
Stefan Kuhne
0c786d6301 [Lacros] Networking.private and networking.onc conversion to Lacros
This is the second patch and it adds all the API calls from
Lacros to Ash.

It does this by introducing a new NetworkingPrivateDelegate for
Lacros which re-routes all commands to the Ash side where they
get executed on the ash delegate.

The functionality itself is limited to first profile use only.

BUG=1278560

Change-Id: I31d703855272bddf0f00099158b97aa9218ab055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674723
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1011173}
2022-06-06 22:38:13 +00:00
Istiaque Ahmed
bc47e97520 [Extensions] ListValue->Value::List changes in extensions event code.
This CL changes deprecated base::ListValue to base::Value::List
in //extensions code that are related to extension events.

Change-Id: Ib6371fe60203ca93379abe08dca2a966dd8e55db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3612725
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000487}
2022-05-06 18:55:12 +00:00
Karandeep Bhatia
0e5ae71a79 Extensions: Pass response headers directly.
This CL should have no behavior change. It changes how the response
headers are propagated for extension resources. This should make it
easier to specify more response headers in the future.

Bug:1199491

Change-Id: Ic940368abf6df94986a06b2afa444e85c325635f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886944}
2021-05-26 23:06:16 +00:00
Lei Zhang
912ec32dee Do not return std::unique_ptr<T>() in extensions/.
This is just a convoluted way of writing nullptr, so rewrite it in the
simpler form. PRESUBMIT.py already disallows new instances of
std::unique_ptr<T>(). This removes existing instances.

Change-Id: I8b27ae2a7bad66d41db92a8c55905be197cdc3fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824942
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#872776}
2021-04-15 09:04:35 +00:00
David Bokan
0624c5b2c9 Convert UpdateClientFactory to RepeatingCallback
TestExtensionsBrowserClient allows passing a factory callback that can
be used to create UpdateClients. By nature of being a factory, this
should be a repeating callback. We also pass it by value to indicate a
transfer of ownership.

No change to (the only) call site as it already uses BindRepeating.

Bug: 1152268
Change-Id: Ib07a63a48614fe3bb52b8fc060dd3946f64ec42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605874
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840910}
2021-01-07 04:05:26 +00:00
Julie Jeongeun Kim
ab3f20d13a Deprecate ResourceType in ExtensionsBrowserClient
This CL replaces blink::mojom::ResourceType with
network::mojom::RequestDestination from
ExtensionsBrowserClient::AllowCrossRendererResourceLoad()
since blink::mojom::ResourceType is deprecated[1].

[1] https://crbug.com/960143

Bug: 1059639
Change-Id: I848b468f064f4ea938aad9450483ee91fb0bd6ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562002
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#834568}
2020-12-08 05:01:15 +00:00
Solomon Kinard
b65fb0aef4 [Extensions][web_accessible_resources] Use |matches|.
Restrict web_accessible_resources based on site |matches| that
extension developers have supplied in manifest.json.

Manifest V3 includes changes to the web_accessible_resources key of
manifest.json. Use parsed |matches| field to determine which sites have
access to specific resources.

In the following example, a.com can access a.gif, but other sites can't:
"web_accessible_resources": [{
  "resources": ["a.gif"],
  "matches": ["https://a.com/*"]
}]

Bug: 1133624
Change-Id: Idd0f4a828e2d1a543aaf5e51ab7af6ec6f2f7220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485887
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831961}
2020-11-30 20:15:37 +00:00
Yuta Hijikata
1455a2a797 LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH)
The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: Ie1e86a9e513a14f15414ffeaf95d8b30b49e175a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490915
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826703}
2020-11-12 09:04:06 +00:00
David Bienvenu
895be5d132 remove DISALLOW_COPY_AND_ASSIGN from extensions/*
Also fix a few cpplint warnings. No functional changes.

Bug: 1010217
Change-Id: Iee89be21a9600d480b8c03312c1150d3e35946e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378896
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803720}
2020-09-02 01:26:45 +00:00
Robert Sesek
5a5fbb8cf4 Merge service_manager::BinderMapWithContext into mojo::BinderMap
Tbr: oksamyt@chromium.org
Bug: 1046578
Change-Id: Ic2c01ee09c4b6a9fb2a936acf28fc0f00dc053f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174654
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765090}
2020-05-04 16:18:28 +00:00
Minggang Wang
ee5af39bb4 [OnionSoup] Move resource_load_info.mojom into Blink
The current mojom struct ResourceLoadInfo defined in //content is used
to notify the status of a resource loading, which is unavailable
inside Blink.

Along with the implementation of OnionSoup of loaders, we are going to
notify the loading status from Blink directly. So we have to move this
mojom struct into Blink in order to leverage it there.

This CL makes the changes below:
- Remove the ResourceType in //content and its typemap and replace with
  the mojom one.
- Move the resource_load_info.mojom into Blink.

Change-Id: I11ab3b7107bd4e06ee3ec737f825202c533a466c
Bug: 860403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986640
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738417}
2020-02-05 02:55:28 +00:00
Miyoung Shin
34f63a8a3f Convert WiFiDisplay{Media,Session}Service client to use BrowserInterfaceBroker
This CL converts WiFiDisplayMediaService and
WiFiDisplaySessionService mojom interface clients in extension to
use BrowserInterfaceBroker, and remove interface_registration.cc/.h
since there is no longer a need API.

Bug: 936482
Change-Id: I33d30ad27df8b282d9883dd09a172d8f56914d00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952547
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#724145}
2019-12-12 05:40:08 +00:00
Miyoung Shin
70485f04bc Convert KeepAlive client to use BrowserInterfaceBroker
This CL converts KeepAlive mojom interface clients in extension to
use BrowserInterfaceBroker, and introduces
RegisterBrowserInterfaceBindersForFrame method in
ExtensionsBrowserClient class to register the extension interfaces
to a binder map for BrowserInterfaceBroker.

Bug: 936482
Change-Id: I6e793427ef32138454ae191c8623cabcee9a61f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946188
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721868}
2019-12-05 05:21:03 +00:00
Julie Jeongeun Kim
6dd4c7b45e Convert network::mojom::URLLoaderClientPtr to new Mojo types
This CL converts network::mojom::URLLoaderClientPtr to new Mojo
types using PendingRemote and Remote.
It also uses pending_remote for URLLoaderClient parameter from
mojom::URLLoaderFactory::CreateLoaderAndStart() and updates its
implementations with new Mojo types.

Bug: 955171
Change-Id: Ie93e96885628488df2d8a88929224cb43ad1ab53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901010
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716076}
2019-11-18 05:56:30 +00:00
Julie Jeongeun Kim
f65376f163 Convert URLLoaderRequest to new Mojo types
This CL converts URLLoaderRequest in //android_webview, //chrome,
//chromecast, //components, //extensions, //srvices, and //storage
to new Mojo types using PendingReceiver and Receiver.

Bug: 955171
Change-Id: I089a195aa52fd74111c8ac819ee96c6cdbb87b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886283
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712442}
2019-11-05 03:54:55 +00:00
Keith Lee
d9510017f2 Modify OnDisplayChanged to dispatch to off-the-record extensions
The Virtual Keyboard extension on the ChromeOS login screen was
not highlighting keys correctly. Hence, when projecting/mirroring
ChromeOS onto an external display, viewers can see the passwords
being entered into the device when logging in.

The root cause was that off-the-record profiles were not receiving
system info events. Since the extension was running off-the-record
on the login screen, it was not notified when the
chrome.system.display.onDisplayChanged API was triggered.

This change makes it so that all off-the-record extensions will
receive chrome.system.display.onDisplayChanged events

Bug: 824656
Change-Id: I787deb9c37b60032eaa1b743b7dd348973c334bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726802
Auto-Submit: Keith Lee <keithlee@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690644}
2019-08-27 06:22:00 +00:00
Clark DuVall
9aa324642d Delete more extensions code that still depends on URLRequest
Now that network service is launched, this is no longer needed. Modified
a few of the unittests to work with the other WebRequestInfo
constructor.

Bug: 934009
Change-Id: Ie291f23de31b0059902c541c4d2b97475403ee90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658655
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669038}
2019-06-13 23:34:17 +00:00
Matt Menke
3c7b89c425 Remove ExtensionsBrowserClient::GetNetLog().
It's not being used anywhere, since consumers are now using network
service APIs. This CL is needed to remove the legacy NetLog in the
browser process, which doesn't actually do anything when the network
service is enabled.

TBR=seantopping@chromium.org

Bug: 767450
Change-Id: I4121aee8b36597c1d781552284e2bf9514f4bdb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612093
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660229}
2019-05-16 00:21:03 +00:00
dpapad
669a8970a4 Component extensions loading: Leverage ResourceBundle::IsGzipped.
Previously a gzipped_resource_file_map_source/header Grit output was used
to determine which component extension resources are gzipped. This is no
longer necessary.

This is in preparation of deleting gzipped_resource_file_map_source Grit
output completely.

Specifically:
 - Modify chrome_url_request_util.cc to use ResourceBundle::IsGzipped.
 - Remove ComponentExtensionResourceInfo struct and update all signatures,
   basically reverting a lot of the changes made at r627283, since
   they are no longer necessary.
 - Remove last usages of type="gzipped_resource_file_map_source" in grd
   files.

Bug: 961063
Change-Id: Ifc9d1535c96e4a168b3d45f3c831976e52c9444a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601481
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658652}
2019-05-10 18:00:49 +00:00
Nigel Tao
650b731110 Add a EarlyExtensionPrefsObserver interface
This commit is part 1 of 2, being a refactor with no change in behavior.
There is an existing observer leak (an AddObserver call with no matching
RemoveObserver call), but this commit keeps that leak. A follow-up
commit will fix the leak.

TBR=seantopping@chromium.org

Change-Id: I73e9087540949c29bb76d6526362b5448452e182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585403
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654688}
2019-04-27 00:18:32 +00:00
Takuto Ikuta
aa3b796c07 Use mojom-forward.h for browser_process_impl.cc
I replaced mojom.h header in files used for compiling browser_process_impl.cc with mojom-forward.h as many as possible.
To fix build failure, I added mojo header files in some cc files too.

This CL improved compile time of browser_process_impl.cc from 14.5s to 13.1s on Linux.

TBR=rockot@google.com, thakis@chromium.org

Bug: 922875
Change-Id: I5311b82f66e97aa7baf5e7a41d2e6358dd670ea3
Reviewed-on: https://chromium-review.googlesource.com/c/1451603
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629441}
2019-02-06 02:54:56 +00:00
Sam McNally
20b9be0f2d Add support for gzipped component app/extension resources.
Applied to the ink wasm module, this saves 3.9MB.

If applied to all Files app, Gallery etc. html/css/js resources this
could save a further 3.2MB.

Bug: 923204
Change-Id: Ia51c767b20a5fb366a5f96fefc1656ed15470e23
Reviewed-on: https://chromium-review.googlesource.com/c/1420397
Reviewed-by: dstockwell <dstockwell@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627283}
2019-01-30 02:29:00 +00:00
Steven Bennetts
4bea303414 chromeos/login: Create separate components
For header file moves in src/chrome:
TBR=sky@chromium.org

Bug: 918682
Change-Id: I2cc795ada277560503aa4183075a94825d876c54
Reviewed-on: https://chromium-review.googlesource.com/c/1394003
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619718}
2019-01-03 19:33:18 +00:00