This CL converts a pattern in extensions tests where a RunLoop quit
closure is bound to a callback argument. In most of these cases we can
simply convert to a OnceClosure.
printer_provider_apitest has one exception that's a RepeatingClosure
because the API actually may call the callback multiple times. In this
case, the quit closure must be copied so it must be a RepeatingClosure.
Bug: 1152268
Change-Id: I4a201cbd78d818f1793b94a8c106d62bb59ba8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605647
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840314}
This change applies the BindOnceRewriter in //extensions.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.
Steps:
1. run_tool.py --tool base_bind_rewriters \
--tool-arg='--rewriter=bind_to_bind_once'
2. git cl format
This CL was uploaded by git cl split.
R=lazyboy@chromium.org
Bug: 714018
Change-Id: I5091b018198c9981a4b21c824602007580ea618e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132329
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760421}
This CL is the content/ and extensions/-specific sections
of the change.
Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.
We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.
R=fmalita@chromium.org,piman@chromium.org,rockot@chromium.org,mkwst@chromium.org
BUG=skia:5077,604716
Review-Url: https://codereview.chromium.org/1951013003
Cr-Commit-Position: refs/heads/master@{#396458}
We need to get the correct favicon of the app or extension so that it's
easier to identify in the table.
Before and after screenshots are available on the BUG thread.
BUG=525293
TEST=browser_tests --gtest_filter=ExtensionTagsTest.*
Review URL: https://codereview.chromium.org/1302423005
Cr-Commit-Position: refs/heads/master@{#346155}
