Removes `#include "base/macros.h"` from remaining .cc, .h and .mm files
that do not contain `ignore_result(` and do not trigger pre-commit or
pre-upload errors.
Bug: 1010217
No-Try: true
Change-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941054}
This replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes
where a local script is able to detect its insertion place (~Foo() is
public => insert before this line).
This is incomplete as not all classes have a public ~Foo() declared, so
not all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.
IWYU cleanup is left as a separate pass that is easier when these macros
go away.
Bug: 1010217
Change-Id: Ib10ea058613b53a3aee4c1d0da78a9c574ba2119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173894
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923649}
This method takes a callback as an argument which is invoked to indicate
completion. The only override that uses this callback is
ChromeRuntimeAPIDelegate; it can invoke the callback immediately, or
store it in a vector of callbacks for later invocation. In the latter
case, the callbacks are all destroyed after being invoked so they can
only be invoked once.
Bug: 1152268
Change-Id: If54898fcffafe232e0ee47365dbccb9f117d9a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602887
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840378}
We currently go to chrome/ to get the extension version, but we don't
need to. ExtensionRegistry in extensions/ has the info already, move
the function to ExtensionRegistry.
Also, the name GetPreviousVersion is misleading. It only gives us the
current version, so rename it to be simply GetVersion.
BUG=723754
Test=None, internal only change.
Review-Url: https://codereview.chromium.org/2892843002
Cr-Commit-Position: refs/heads/master@{#473332}
At the moment the 3 modules that use extension API schemas, those in
extensions/common/api, chrome/common/extensions/api, and extensions/shell/api,
are generated with different C++ namespaces: "core_api", "api", and
"shell::api" respectively.
This is a pointless distinction to make since as far as JS is concerned they
must all go on the window.chrome object, therefore namespace conflicts are
impossible. It just ends up adding code noise.
The only problem it solves is that all bundle compiles are generated to the
same name, "GeneratedSchemas" and "GeneratedFunctionRegistry". This patch
solves that a different way, by adding a JSON schema compiler option to give
those generated classes a prefix such that they are "GeneratedSchemas",
"ChromeGeneratedSchemas", and "ShellGeneratedSchemas" respectively.
This lets us to a global substitution from "core_api" to just "api".
R=rockot@chromium.org, dpranke@chromium.orgTBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1226353004
Cr-Commit-Position: refs/heads/master@{#340119}
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/664933004
Cr-Commit-Position: refs/heads/master@{#300475}
This moves the runtime API schema and implementation to //extensions,
offloading some of its responsibilities out to a new RuntimeAPIDelegate
provided by the active ExtensionsBrowserClient.
BUG=369391
TBR=derat for mechanical chromeos changes
TBR=tzik for +webkit/browser/fileapi to extensions/browser/DEPS
TBR=sky for new chrome/test dependency
Review URL: https://codereview.chromium.org/264743014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268749 0039d316-1c4b-4281-b951-d872f2087c98
