0
Commit Graph

10 Commits

Author SHA1 Message Date
Avi Drissman
60039d4d4b Update copyright headers in extensions/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
Bug: 1098010
Change-Id: I92587d82572fb164300a4165a153102982a277dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894332
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046592}
2022-09-13 21:49:05 +00:00
Jan Wilken Dörrie
09a4396a44 [LSC] Remove base/strings/string16.h #includes
This change removes #includes of base/strings/string16.h from the
codebase.

Bug: 1184339
Change-Id: I3b29dd94c6955d01029d24f88177b755863c865d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2756167
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862683}
2021-03-14 19:20:08 +00:00
Jan Wilken Dörrie
85285b04a0 [LSC] Replace base::string16 with std::u16string in //[a-e]*
This change replaces base::string16 with std::u16string in //[a-e]*.

Reproduction steps:
$ git grep -lw 'base::string16' [a-e]* | \
      xargs sed -i 's/\bbase::string16\b/std::u16string/g'
$ git cl format

Bug: 1184339
Change-Id: I7930c2c3ae510b6d2232cc1b3a927ad90515ffe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2752407
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862191}
2021-03-11 23:38:47 +00:00
Jan Wilken Dörrie
ad587c3edb [LSC] Add #include <string> to prepare for removal of base::string16
This change adds #include <string> to files currently including
"base/strings/string16.h". This prepares these files for the planned
removal of the base::string16 alias.

In order to adhere to the style guide [1] the following logic was
performed:

* Insert into an existing block of C++ STL includes, if possible
* Else insert `#include <string>` followed by a newline before the first
  #include "some_header.h" line that is not referring to a matching header
  (only relevant for implementation and test files)

[1] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 1184339
Change-Id: I96660fec3fff0192d53e9728bbbae86228a52c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2749296
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861966}
2021-03-11 14:09:27 +00:00
Hans Wennborg
0997959068 Remove/replace unnecessary logging.h includes in .cc files (extensions)
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: Id6e45887e66060a275b14489290e5aedd0379868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164511
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762814}
2020-04-27 12:34:30 +00:00
dcheng
7c2ca35e78 Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr
BUG=554298
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1908953003

Cr-Commit-Position: refs/heads/master@{#389238}
2016-04-22 21:17:03 +00:00
avi
2d124c0ce7 Switch to standard integer types in extensions/.
BUG=138542
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1543053002

Cr-Commit-Position: refs/heads/master@{#366716}
2015-12-23 06:37:37 +00:00
sammc
987f416b97 Add extensions/common/stack_frame_unittest.cc to extensions.gyp.
Review URL: https://codereview.chromium.org/600363002

Cr-Commit-Position: refs/heads/master@{#296829}
2014-09-25 23:34:24 +00:00
avi@chromium.org
ad65a3ee54 Update uses of UTF conversions in courgette/, device/, extensions/, google_apis/, gpu/, ipc/, media/, net/ to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/112963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242496 0039d316-1c4b-4281-b951-d872f2087c98
2013-12-25 18:18:01 +00:00
rdevlin.cronin@chromium.org
88b50b690f Report Javascript Runtime Errors to the Error Console
TBR=brettw@chromium.org
(moving DEPS file from extensions/common/matcher to extensions/common).

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/23007021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220753 0039d316-1c4b-4281-b951-d872f2087c98
2013-09-01 23:05:06 +00:00