This change adds #include <string> to files currently including
"base/strings/string16.h". This prepares these files for the planned
removal of the base::string16 alias.
In order to adhere to the style guide [1] the following logic was
performed:
* Insert into an existing block of C++ STL includes, if possible
* Else insert `#include <string>` followed by a newline before the first
#include "some_header.h" line that is not referring to a matching header
(only relevant for implementation and test files)
[1] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
Bug: 1184339
Change-Id: I96660fec3fff0192d53e9728bbbae86228a52c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2749296
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861966}
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.
This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.
(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)
Bug: 1031540
Change-Id: Id6e45887e66060a275b14489290e5aedd0379868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164511
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762814}