This CL migrates the root-level PRESUBMIT checks, their associated
tests, and and one other file that got pulled along for the ride)
to run under Python3 instead of Python2.
Bug: 816629
Change-Id: I75f3edb34ca72458432ba54f3afa022e027f8eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2877897
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#883002}
https://crrev.com/2b456f2d8f2e6c0bfd3b12dff34f2df974816825 added a
check for any JS files that used a series of app and extension APIs
and signaled a warning if these APIs were used. However, many (or
even the majority) of these APIs are exposed to contexts beyond
Chrome Apps, including extensions, web contexts, and WebUI. This
results in developers in these areas receiving noisy presubmit
errors (and encourages ignoring them altogether).
Remove all of these and add a TODO to add back in the list of APIs
that is exposed exclusively to Chrome Apps.
This does not affect the checks added for nacl, pnacl, or others.
Bug: b:160753993
Change-Id: I651117f4bfccb5f2e02eee8d497f0b865d9d5f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2877683
Auto-Submit: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#880080}
This change adds a presubmit warning for invoking base::ASCIIToUTF16 and
base::UTF8ToUTF16 with string literals. Instead, the UTF16 string
literal (u"...") should be used directly.
Furthermore, it uses a static_assert to force compilation errors for
usages of WideToUTF16 with a wide string literal.
Bug: 1189439
Change-Id: Ie2026b4632754fbfe0b0837bc0edfbe1366ae409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2810414
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870657}
The //PRESUBMIT.py checks may sometimes be run on a bot that is actually
testing changes to a repo other than chromium src (e.g., v8 or ANGLE
or something). Sometimes it makes sense to run the presubmit changes
anyway, but the inclusive language check should only be run on actual
changes to chromium/src, since that's what the allowlist checks against.
This CL tweaks the check to exit early on changes for other repos, and
removes the temporary workaround we added earlier today in
f0b0b46c/#{868614).
Bug: 1194996
Change-Id: I0332768a655528e0de0fd52c63ee17ebc15b50e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2801150
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#869219}
User actions logged by test files don't need to be added to
actions.xml. I hit this in a separate CL I'm working on.
Also fixes a line-too-long warning via wrapping.
Bug: 1171830
Change-Id: I2bb383dd070fad766b21ed4b467b2c5451d52a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2753489
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862151}
There are a variety of foo_unitttests.cc files in the source tree.
The filenames are reasonable, because they contain tests for feature
"foo" rather than a specific class or function.
Many of these files contain unnecessary // IN-TEST comments next to
calls to ForTesting() functions. I suspect engineers added them
because PRESUBMIT.py complained. For an example, see:
https://chromium-review.googlesource.com/c/chromium/src/+/2712426
Update the regex that detects test suite files and add a unit test
to exercise it.
Fixed: 1185381
Change-Id: Id24c97d23b4962eaccc0b2a9e7f3a20c3003c359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2740299
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861325}
Projects will have to add entries for gn to their toplevel DEPS instead.
Add this to your `vars` section:
'gn_version': 'git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3',
And this to your `deps` section:
'src/buildtools/linux64': {
'packages': [
{
'package': 'gn/gn/linux-amd64',
'version': Var('gn_version'),
}
],
'dep_type': 'cipd',
'condition': 'host_os == "linux"',
},
'src/buildtools/mac': {
'packages': [
{
'package': 'gn/gn/mac-${{arch}}',
'version': Var('gn_version'),
}
],
'dep_type': 'cipd',
'condition': 'host_os == "mac"',
},
'src/buildtools/win': {
'packages': [
{
'package': 'gn/gn/windows-amd64',
'version': Var('gn_version'),
}
],
'dep_type': 'cipd',
'condition': 'host_os == "win"',
},
Adopt to your project's style as you like.
(Maybe your toplevel directory is not called "src".)
angle and v8 for example do this already for example.
It looks like there's no way to have autoroller update this via transitive_dep,
and it looks like there's no way to have an autoroller for this at the chromium
level yet, see https://bugs.chromium.org/p/skia/issues/detail?id=11712
But it's the last thing keeping buildtools/DEPS around, and several projects
already don't use this hook, so let's remove it.
Bug: 1177288
Change-Id: I3d89361fcc95eebe91fd38ce854ce629f4117e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743918
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#861001}
This reverts commit aad31b6d3d.
Reason for revert: We don't want this running on CI and blocking CLs just yet.
Original change's description:
> [chromium/src presubmit] Add an inclusive language check function.
>
> This change add a new check to prevent non-inlcusive language (e.g.
> 'blacklist', 'whitelist', 'master', 'slave') from being added to the
> repo.
>
> It includes a legacy allowlist file, which lists paths in the repo that
> should be temporarily exempted from this check while we clean up
> existing instances that have accumulated over the years.
>
> Bug: 1177609
> Change-Id: I0d51189134bc506fbe68eacddecdc88360bc86aa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718892
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#860006}
Bug: 1177609
Change-Id: I27355d772526ebf603292e259ba239b7f4eb26be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2737142
Auto-Submit: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#860034}
This change add a new check to prevent non-inlcusive language (e.g.
'blacklist', 'whitelist', 'master', 'slave') from being added to the
repo.
It includes a legacy allowlist file, which lists paths in the repo that
should be temporarily exempted from this check while we clean up
existing instances that have accumulated over the years.
Bug: 1177609
Change-Id: I0d51189134bc506fbe68eacddecdc88360bc86aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718892
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Cr-Commit-Position: refs/heads/master@{#860006}
This is very similar to
https://chromium-review.googlesource.com/c/chromium/src/+/2729355 ,
just with libcxx instead of libcxxabi. See that CL description for
details, except here you want to add
'libcxx_revision': '8fa87946779682841e21e2da977eccfb6cb3bded',
and a project-appropriate version of
'src/buildtools/third_party/libc++/trunk':
Var('chromium_git') +
'/external/github.com/llvm/llvm-project/libcxx.git' + '@' +
Var('libcxx_revision'),
(...and then add this as a transitive dep of your chromium roller,
as described in that other CL, like a bunch of projects have already
done.)
Bug: 1182719,1177288
Change-Id: I1362eb591f49111143733c036548670ee4004673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733154
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#859627}
Unlike LSC which is meant for work that spans dozens of CLs, this new change is meant for one-off CLs. It's similar to google3's global approvals mechanism.
base, build, blink, content and url were chosen as an initial set because they are used in many top level directories and are frequently changing.
Also add "set noparent" to top level directories to avoid inadvertent +1s from src/OWNERS bypass owners reviews sometimes.
Change-Id: Iaa397a5e09174139af21fee34dca390de132e216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688805
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857391}
If your project DEPS's in buildtools and needs libunwind, edit your
toplevel DEPS file to have something like
'libunwind_revision': 'a2cc4f8c554dedcb0c64cac5511b19c43f1f3d32',
in its `vars =` section, and an entry similar to
'src/buildtools/third_party/libunwind/trunk':
Var('chromium_git') +
'/external/github.com/llvm/llvm-project/libunwind.git' + '@' +
Var('libunwind_revision'),
in its `deps =` section. Add libunwind_revision to your autoroller
that rolls //build and //tools/clang etc.
Since libunwind is only used in Fuchsia builds and for chrome/android's
sampling profiler, it's possible that no projects other than chromium
actually need this.
This makes it possible to set up an autoroller for libunwind for chromium.
Bug: 1177288
Change-Id: I7a59f11b015acc98b65f4b87a9277a5a3028328d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713283
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#856453}
Replace input_api.owners_db with input_api.owners_client will
simplify migration from Depot Tools owners to Gerrit native
code-owners.
Owners client is an abstraction that provides a common
interface to both Depot Tools and Gerrit owners backends.
Added `set noparent` to SECURITY_OWNERS.
This makes it easy to list security reviewers, as it is the
same as listing OWNERS of that file.
Change-Id: I6196177e61b1ce19f23cc2645a482b29b92c081d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679444
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851861}
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2572896
Ensure that SkImageRep is always constructed with a valid bitmap.
Instead of constructing an invalid SkImageRep then throwing it away when
initializing an SkImage, we add an SkImage::CreateFromBitmap() that will
just return a null SkImage directly if the bitmap is null/uninitialized.
ImageSkia was creating a null ImageSkiaRep when searching for a
representation in order to force use of the nearest one, but it also
uses a boolean value to do the same, so stop making a null ImageSkiaRep.
Then disallow null/empty ImageSkiaRep and also disallow their transport
over mojo.
Remove a few tests that were creating invalid ImageSkiaReps to test that
they work - as they are no longer valid.
Have ImageSkia constructed from ImageSkiaOperations check for the
ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as
that can still return a null ImageSkiaRep. In that case, the resulting
ImageSkiaRep must also be null. And we can do that without trying to
perform operations on the (invalid, null) bitmap inside the null
ImageSkiaRep.
This fixes the tests included in the CL. We no longer try to serialize
null or empty ImageSkiaRep since the class itself will not allow it. We
do test that we will not deserialize such invalid ImageSkiaReps. And a
test is also added to verify we do not allow non-n32 bitmaps to be
deserialized in ImageSkiaRep.
R=dcheng@chromium.org, sky@chromium.org
Bug: 1155258
Change-Id: Ia18360dcd2a59be8c49b7104f01dbdd20bbe6bbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596131
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838132}
Commit(1e7c250) has added a presubmit warning to prevent further uses
of old downcast helpers. All the occurrences of old downcast helpers
are removed from the codebase and these changes are not needed now.
Bug: 891908
Change-Id: I0090438d1f8c835b153ae2d6d177389891948991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592539
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#837436}
This reverts commit df3e91a120.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 837373 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RmM2U5MWExMjBkMjY4NDU4ZWYzNWNmNTdkNzhlNDAxODE1ZGZmOGQM
Sample Failed Build: https://ci.chromium.org/b/8860797505511259488
Sample Failed Step: gfx_unittests
Original change's description:
> Prevent making invalid SkImageReps
>
> Ensure that SkImageRep is always constructed with a valid bitmap.
> Instead of constructing an invalid SkImageRep then throwing it away when
> initializing an SkImage, we add an SkImage::CreateFromBitmap() that will
> just return a null SkImage directly if the bitmap is null/uninitialized.
>
> ImageSkia was creating a null ImageSkiaRep when searching for a
> representation in order to force use of the nearest one, but it also
> uses a boolean value to do the same, so stop making a null ImageSkiaRep.
>
> Then disallow null/empty ImageSkiaRep and also disallow their transport
> over mojo.
>
> Remove a few tests that were creating invalid ImageSkiaReps to test that
> they work - as they are no longer valid.
>
> Have ImageSkia constructed from ImageSkiaOperations check for the
> ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as
> that can still return a null ImageSkiaRep. In that case, the resulting
> ImageSkiaRep must also be null. And we can do that without trying to
> perform operations on the (invalid, null) bitmap inside the null
> ImageSkiaRep.
>
> R=sky@chromium.org
>
> Bug: 1155258
> Change-Id: Id7953743ca31804fa3d987677bb8c4962919fd35
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572896
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#837373}
Change-Id: If565d70cf106083108462ac7372ddaab252a18c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1155258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594552
Cr-Commit-Position: refs/heads/master@{#837400}
Ensure that SkImageRep is always constructed with a valid bitmap.
Instead of constructing an invalid SkImageRep then throwing it away when
initializing an SkImage, we add an SkImage::CreateFromBitmap() that will
just return a null SkImage directly if the bitmap is null/uninitialized.
ImageSkia was creating a null ImageSkiaRep when searching for a
representation in order to force use of the nearest one, but it also
uses a boolean value to do the same, so stop making a null ImageSkiaRep.
Then disallow null/empty ImageSkiaRep and also disallow their transport
over mojo.
Remove a few tests that were creating invalid ImageSkiaReps to test that
they work - as they are no longer valid.
Have ImageSkia constructed from ImageSkiaOperations check for the
ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as
that can still return a null ImageSkiaRep. In that case, the resulting
ImageSkiaRep must also be null. And we can do that without trying to
perform operations on the (invalid, null) bitmap inside the null
ImageSkiaRep.
R=sky@chromium.org
Bug: 1155258
Change-Id: Id7953743ca31804fa3d987677bb8c4962919fd35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572896
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837373}
It's a common mistake that developers just remove Register...Pref()
calls for preferences they don't need anymore. If they do this, the
preference stays in the prefs files on disk for ever. A proper approach
is to first ClearPref() the preference for some releases and then to
remove the code.
This CL introduces a presubmit warning if we detect that a
Register...Pref() call is removed from a non-unittest.
Bug: 1153014
Change-Id: If8f19933de039553ef47e0ddce12eb194df45ce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560205
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833730}
Many spots using forward_variables_from(invoker, "*") were not
allowing these two variables to be set in outer scopes.
* Introduce a helper variable "EXPLICIT_FORWARDS" for use with the
recommended pattern of:
forward_variables_from(invoker, "*", [ "testonly", "visibility" ])
forward_variables_from(invoker, [ "testonly", "visibility" ])
* Ensures this pattern is used in android templates, test.gni,
and BUILDCONFIG.gn
* Documents this pattern in writing_gn_templates.md
* Adds a PRESUBMIT.py for it
* Fixes visibility of a few blink targets now that test()
respects it.
Bug: 862232
Change-Id: Ib71dbf34be76131fc749c721aea856e1146bc69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454427
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#830678}
Update special handing in ForTest PRESUBMIT checking to make sure common
Android annotation @VisibleForTesting is not flagged. This annotation
typically means something in production code has a more permissive
visibility setting (such as protected or public) so that a test can
access it. The ForTest PRESUBMIT check is not applicable to this
annotation. For more information about @VisibleForTesting annotation see
https://developer.android.com/reference/androidx/annotation/VisibleForTesting
Bug: 1138976
Change-Id: Ic345bfe8e5c283a8826e17c3209f6768a281151d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476515
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: who/bttk <bttk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817717}
* This is a follow-up to crrev.com/c/2328669 with further fine tuning
from findings in https://crbug.com/1103844#c22.
* The current translation screenshot presubmit check flags modified
messages:
1) if the message does not yet have a screenshot, or
2) if the message content itself changed.
* This CL changes the behavior to for modified messages check in this
order:
1) if the message content itself changed -> flag the message.
2) if the message meaning changed and there is neither an existing
screenshot nor is a new one added with the CL -> flag the message.
* Important cases to consider: messages that don't yet have a
screenshot and for which only the message meaning attribute changed
will require a screenshot, but messages for which only the message
meaning changed and which already have a screenshot do not require a
new screenshot. And messages of which only the description attribute
changed simply never require new screenshots at all.
Bug: 1103844
Change-Id: I0318e685b2182a455dccfb0630ce768f5c990a65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412727
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808789}
* The current translation screenshot presubmit check flags messages
which got modified but for which no new translation screenshot
got uploaded. It thereby also flags messages that got modified, but of
which the message content itself did not change. This is the case, for
example, if only the message description for translators got changed.
* This CL restricts the translation screenshot presubmit flagging
modified messages. It will trigger 1) if the message did not have a
screenshot at all so far, or 2) if the message content itself changed.
Only changing the non-visible part of a message that already has a
translation screenshot does not trigger it anymore.
Bug: 1103844
Change-Id: I254ce2a7267a7d2308b606b16d080c74188d582b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328669
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797648}
Re-design of the CL (crrev.com/c/2341362) to enable presubmit_support
to time/ResultDB wrap each individual lower-level check in PRESUBMIT.py.
The approach taken here is to have the PRESUBMIT_VERSION = 2.0.0 in here
so that presubmit_support is aware of the new version of PRESUBMIT.py,
then check input_api.version in CheckChangeOnCommit/Upload to ensure
that presubmit_support itself is the new version.
The associated changes to depot_tools (crrev.com/c/2349979) must be
landed in order for this to work.
Change-Id: I91d09337dd77a74540ac4a01017275bcaaa67cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350234
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#797291}
This reverts commit 065782712e.
Reason for revert: Getting reports of the version check not working from various users; see crbug.com/1115140
Original change's description:
> Rewrote PRESUBMIT.py
>
> Rewrote PRESUBMIT.py (and associated tests) to new format. Runs
> REQUIRE_PRESUBMIT_VERSION at the top so that depot_tools can be
> made aware of the change and can time/rdb wrap each of the Check...
> functions separately, while also ensuring that they have the new
> version of depot_tools.
>
> Requires the newer version of presubmit_support.py in depot_tools,
> which is described in crrev.com/c/2341828
>
> Change-Id: I102e8c75834aff1eccdf4a27ffe6f0953b76ee57
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341362
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
> Cr-Commit-Position: refs/heads/master@{#796595}
TBR=dpranke@google.com,estaab@chromium.org,saagarsanghavi@google.com
Change-Id: Ib3295d141e997fc6792c381fea10e8892204bcdb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349428
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#796867}
Rewrote PRESUBMIT.py (and associated tests) to new format. Runs
REQUIRE_PRESUBMIT_VERSION at the top so that depot_tools can be
made aware of the change and can time/rdb wrap each of the Check...
functions separately, while also ensuring that they have the new
version of depot_tools.
Requires the newer version of presubmit_support.py in depot_tools,
which is described in crrev.com/c/2341828
Change-Id: I102e8c75834aff1eccdf4a27ffe6f0953b76ee57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341362
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Cr-Commit-Position: refs/heads/master@{#796595}
In the spirit of macOS Big Sur, which is labeled as macOS 11.0,
introduce OS_MAC and OS_APPLE. OS_MACOSX implicitly included OS_IOS,
which was confusing, so OS_APPLE is the new replacement for "macOS +
iOS" and OS_MAC is the new replacement for "just macOS, not iOS".
Bug: 1105907
Change-Id: I0f24ff5a74f07eaf2fe7b7fa17bdef7e82a514fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299189
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791353}
This is a follow up to https://crrev.com/c/2274667
This attribute was recently introduced so that developers wouldn't
get presubmit errors for accessibility labels that are not shown in the
UI. However, screen readers do actually display most accessibility
labels, so having screenshots for these strings are still useful. Still,
there is a small subset of accessibility labels that are never
displayed. This CL renames the existing attribute to make the intention
of the carveout clear.
Bug: 1094077
Change-Id: I4c171d29fea0aac611cb07759422bd5c25688017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285076
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786025}
This CL converts remaining StrongBinding's uses to
MakeSelfOwnedReceiver. Besides that this CL removes
all unnecessary strong_binding.h includes.
Additionally, PRESUMIT scripts start warning the use of
StrongBinding.
Bug: 955171
Change-Id: I3336fc31b7c7f390c00d4dfdd87dca404cce5e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281790
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#785614}
