The current combination of WindowTargeter with MaskedWindowDelegate
isn't working well with Mash. Instead of doing this, it needs to
use window targeter's new API for setting window masks.
The GetEventHandlerForPoint should be fixed in a way to follow
this new way.
BUG=901546
TEST=the new test case also covers
Change-Id: I0b095777450fab3fa28ff9ebd8473667f644ab9e
Reviewed-on: https://chromium-review.googlesource.com/c/1320689
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605853}
This CL fixes DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay
of tab-dragging for Mash;
- SetBounds are not great for testing with Mash since it may not
reflect the correct location in Ash, or it may cause moving the
browser window to the secondary display. Instead, dragging events
to move the browser window which still resides in the primary
display but covers on the secondary display.
- Creates a mouse move event on the warped pointer; as far as
I debugged, this is not happening in the classic environment
too, but the test was passing somehow (the newly added expectation
of browser bounds at the end fails even without Mash).
BUG=901543
TEST=trybot
Change-Id: Id4826673975535e0dc12460cda4a62b060a328db
Reviewed-on: https://chromium-review.googlesource.com/c/1318794
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605734}
Fix link to reproduce tool.
Include note about using powershell.
Remove "> " from command.
Mention that document is for libFuzzer explicitly.
Be more consistent about capitalization of "libFuzzer".
TBR=mmoroz@chromium.org
Bug: 901836
Change-Id: I9a91be5d01c2707366b1d8100cb0823c221aa82e
Reviewed-on: https://chromium-review.googlesource.com/c/1318918
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605684}
Due to disk shortage, `all` cannot be built for Mac Goma Canary
(clobber). Let's build chrome instead.
The disk of "Chromium Mac Goma GCE Staging" is also getting short,
so I changed this builder, too.
Bug: 899425
Change-Id: I58a960ad8455c78bc7ae871298edf78aed650f7b
Reviewed-on: https://chromium-review.googlesource.com/c/1316952
Commit-Queue: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605575}
Some tab-dragging test cases never finishes on SingleProcessMash,
and it turns out that WindowEventDispatcher thinks some
TOUCH_RELEASED events can be invalid; it won't generate any
gestures and does not do anything. In that case, OnEvent()
won't be called and any other methods are not called, therefore
InjectedEventHandler couldn't notify it's done.
This CL adds a new method to WindowEventDispatcherObserver to
catch such cases and allow handling it's done.
BUG=890071
TEST=see the filter update
Change-Id: I6dcda9af52e5cbd4013b8d228bda2e9b1f14bdd6
Reviewed-on: https://chromium-review.googlesource.com/c/1316767
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605531}
Add docs on reproducing libFuzzer crashes on Windows.
Make it clearer that reproduce tool is not for Windows.
Fix a command to work on cmd.exe
Bug: 901836
Change-Id: Iabc5f8a2973053659addbb27d326ccb07c7910e2
Reviewed-on: https://chromium-review.googlesource.com/c/1318629
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605526}
- Add a ScopedAllow helper class that SystemEventRewriter allows
event to pass through when there are instances of it;
- Use ScopedAllow helper to allow fake gesture events to pass
through under mash;
Bug: 884360
Change-Id: I940398b0920505743ad7adbe08e12e1394fb55c0
Reviewed-on: https://chromium-review.googlesource.com/c/1292400
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605496}
For lock screen app windows the window manager needs to specify the
initial show state of the window. Ensure the client (chrome) does not
overwrite the aura window show-state property in ash if the client
window has ui::SHOW_STATE_DEFAULT.
Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash
The reland changes FirstAppRunToastManager to use a WidgetObserver
to watch for app window bounds changes. Mash tears down aura::Windows
similarly to aura on MS Windows and Linux. The aura::Window for
the app window can be destroyed before AppWindowRegistry notifies
StateController and FirstAppRunToastManager that the app has been
closed, so it's not safe for FirstAppRunToastManager::Reset() to
manipulate the aura::Window to remove the ScopedObserver. See bug.
TBR=sky@chromium.orgTBR=tsepez@chromium.org
Bug: 899055
Test: added to views_mus_unittests
Change-Id: I886dbe45fe53708beb4441c1d9da2587a2352997
Reviewed-on: https://chromium-review.googlesource.com/c/1312972
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605110}
Flip the RuntimeHostPermissions feature to be enabled by default on
ToT. Remove the entry in the testing config.
Bug: 869996
Change-Id: Ic76c4a018c6bc0140069bd2730ff5591cd293bda
Reviewed-on: https://chromium-review.googlesource.com/c/1294010
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605097}
This reverts commit b2457b268d.
Reason for revert: suspected of causing assertion failure running merge_web_test_results.py in not_site_per_process_webkit_layout_tests
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53956
2018-11-02 10:44:57,220 - root: [INFO] Running with isolated arguments
Traceback (most recent call last):
File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/merge_web_test_results.py", line 12, in <module>
main(sys.argv[1:])
File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/blinkpy/web_tests/merge_results.py", line 775, in main
assert args.positional
AssertionError
Original change's description:
> Make layout tests use default isolation (e.g. site-per-process on desktop).
>
> Summary
> =======
>
> This CL makes layout tests use the default site isolation from the
> platform they are run on (instead of opting out of strict site isolation
> via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
> Additionally, on platforms where strict site isolation is enabled,
> layout tests opt into slightly stricter isolation by enabling isolation
> of same-site origins used by Web Platform Tests - this ensures that
> features covered by WPT also get sufficient coverage of out-of-process
> iframes (OOPIFs).
>
> After this CL, expectations for tests that differ in behavior with and
> without OOPIFs are being moved from
> LayoutTests/FlagExpectations/site-per-process to:
> - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
> - LayoutTests/virtual/not-site-per-process/README.md
> - LayoutTests/TestExpectations and LayoutTests/NeverFixTests
> ("Site Isolation failures" section)
>
>
> Desirability
> ============
>
> The CL helps with the following:
>
> - Focusing on testing the mode that is actually shipped to end users
> - Helping ensure that newly developed features get site-per-process
> coverage without having to set up a separate step (i.e. it is
> sufficient to set-up a bot that runs layout tests with
> --enable-features=NewFeature without also having to have a separate
> test step for runing layout tests with *both*
> --enable-features=NewFeature *and* --site-per-process
>
> This CL does *not* help with reducing requirements for CQ capacity,
> because we need to maintain a separate
> not_site_per_process_webkit_layout_tests step to make sure that tests
> pass without isolation (which is the mode Chrome ships on Android).
> Also note that layout test coverage on Android is very sparse - see
> https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion
>
>
> Preserving test coverage
> ========================
>
> Most tests
> ----------
>
> The CL preserves covering most layout tests with and without OOPIFs, by
> relying on the fact that CQ/waterfall run layout tests on both kinds of
> platforms - ones that default to strict site isolation (desktop
> platforms) and ones that default to no site isolation (Android).
>
>
> Tests that used to be excluded FlagExpectations/site-per-process
> ----------------------------------------------------------------
>
> Around 40 tests fail when run in presence of OOPIFs. Such tests are
> disabled by this CL by moving test expectations from
> FlagExpectations/site-per-process into the main TestExpectations file.
> The CL preserves non-OOPIF test coverage provided by the disabled tests
> by introducing virtual/not-site-per-process directory which runs all
> such tests with site isolation disabled. Using a virtual test suites
> for preserving the test coverage relies on the ability to have separate
> test expectations for these tests (i.e. relying on the fact that
> disabling these tests in TestExpectations doesn't disable their
> virtual/not-site-per-process equivalents).
>
> Note that the CL keeps isolating "oopif.test" site even in
> virtual/not-site-per-process suite. This site should only be used by
> tests that require an OOPIF.
>
>
> Preserving site-per-process-specific test expectations
> ------------------------------------------------------
>
> Some tests have site-per-process-specific expectations:
> - http/tests/inspector-protocol/network/security-info-on-response.js
> - http/tests/inspector-protocol/network/raw-headers-for-protected-document.js
>
> The tests above highlight that cross-origin cookies are not displayed in
> site-per-process mode (a known regression tracked by
> https://crbug.com/849483). This CL preserves expectations and coverage
> by shuffling things around:
> - old, main expectation -> android expectation
> - old, site-per-process expectation -> main expectation
>
>
> There is one additional test with site-per-process-specific
> expectations:
> - external/wpt/dom/events/EventListener-addEventListener.sub.window.js
>
> Unlike the other 2 tests, it seems less important to preserve exact test
> expectations for the case when the test fails with Site Isolation.
> Therefore this test is covered by virtual/not-site-per-process test
> suite and an expectation for this test is added to the main
> TestExpectations.
>
>
> Lost test coverage
> ------------------
>
> Even with extra caution described above, some test coverage may be lost:
>
> - Features covered by tests only on one kind of platform (e.g. disabled
> on Android) are at risk of losing OOPIF or non-OOPIF coverage.
>
> - Before this CL, site-per-process was also applied to all other
> `virtual/...` test suites. After this CL,
> `virtual/not-site-per-process` will not provide such coverage.
>
>
> Cleaned up test expectations
> ----------------------------
>
> Some additional test expectations clean-up is done, while preserving
> test coverage:
>
> - The http/tests/perf/large-inlined-script.html test has been already
> present in `SlowTests` and therefore I didn't include this test in the
> new `virtual/not-site-per-process` suite.
>
> - The http/tests/devtools/network/network-datareceived.js test was
> already marked as expecting a `[Failure]` in TestExpectations and
> therefore I didn't include this test in the new
> `virtual/not-site-per-process` suite.
>
> - The http/tests/devtools/console-cross-origin-iframe-logging.js test
> was already marked as `[Timeout]` in the old TestExpectations but for
> Win only. Since I can repro a timeout on Linux (with and without site
> isolation), I just extended the old expectation to all platforms and I
> didn't include this test in the new `virtual/not-site-per-process`
> suite. I also removed the test from SlowTests (since timeouts in the
> test are not expected everywhere).
>
>
> Bug: 870761
> Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64
> Reviewed-on: https://chromium-review.googlesource.com/c/1302662
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604955}
TBR=dpranke@chromium.org,alexmos@chromium.org,lukasza@chromium.org
Change-Id: I54b6a36922bebfbc8a3f1467bc3d4807c2322604
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870761
Reviewed-on: https://chromium-review.googlesource.com/c/1315960
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605039}
Also,
- Enable a couple locally passing tests that don't have bugs attached.
- Disable EncryptedMediaTest suite on Chrome OS asan/lsan, to match
Linux asan/lsan, due to flake (not unique to Mash).
Bug: 793426
Change-Id: Ia01b402234e33e5fda0f587fc8d47fad7897cbb7
Reviewed-on: https://chromium-review.googlesource.com/c/1315809
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605015}
Summary
=======
This CL makes layout tests use the default site isolation from the
platform they are run on (instead of opting out of strict site isolation
via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
Additionally, on platforms where strict site isolation is enabled,
layout tests opt into slightly stricter isolation by enabling isolation
of same-site origins used by Web Platform Tests - this ensures that
features covered by WPT also get sufficient coverage of out-of-process
iframes (OOPIFs).
After this CL, expectations for tests that differ in behavior with and
without OOPIFs are being moved from
LayoutTests/FlagExpectations/site-per-process to:
- LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
- LayoutTests/virtual/not-site-per-process/README.md
- LayoutTests/TestExpectations and LayoutTests/NeverFixTests
("Site Isolation failures" section)
Desirability
============
The CL helps with the following:
- Focusing on testing the mode that is actually shipped to end users
- Helping ensure that newly developed features get site-per-process
coverage without having to set up a separate step (i.e. it is
sufficient to set-up a bot that runs layout tests with
--enable-features=NewFeature without also having to have a separate
test step for runing layout tests with *both*
--enable-features=NewFeature *and* --site-per-process
This CL does *not* help with reducing requirements for CQ capacity,
because we need to maintain a separate
not_site_per_process_webkit_layout_tests step to make sure that tests
pass without isolation (which is the mode Chrome ships on Android).
Also note that layout test coverage on Android is very sparse - see
https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion
Preserving test coverage
========================
Most tests
----------
The CL preserves covering most layout tests with and without OOPIFs, by
relying on the fact that CQ/waterfall run layout tests on both kinds of
platforms - ones that default to strict site isolation (desktop
platforms) and ones that default to no site isolation (Android).
Tests that used to be excluded FlagExpectations/site-per-process
----------------------------------------------------------------
Around 40 tests fail when run in presence of OOPIFs. Such tests are
disabled by this CL by moving test expectations from
FlagExpectations/site-per-process into the main TestExpectations file.
The CL preserves non-OOPIF test coverage provided by the disabled tests
by introducing virtual/not-site-per-process directory which runs all
such tests with site isolation disabled. Using a virtual test suites
for preserving the test coverage relies on the ability to have separate
test expectations for these tests (i.e. relying on the fact that
disabling these tests in TestExpectations doesn't disable their
virtual/not-site-per-process equivalents).
Note that the CL keeps isolating "oopif.test" site even in
virtual/not-site-per-process suite. This site should only be used by
tests that require an OOPIF.
Preserving site-per-process-specific test expectations
------------------------------------------------------
Some tests have site-per-process-specific expectations:
- http/tests/inspector-protocol/network/security-info-on-response.js
- http/tests/inspector-protocol/network/raw-headers-for-protected-document.js
The tests above highlight that cross-origin cookies are not displayed in
site-per-process mode (a known regression tracked by
https://crbug.com/849483). This CL preserves expectations and coverage
by shuffling things around:
- old, main expectation -> android expectation
- old, site-per-process expectation -> main expectation
There is one additional test with site-per-process-specific
expectations:
- external/wpt/dom/events/EventListener-addEventListener.sub.window.js
Unlike the other 2 tests, it seems less important to preserve exact test
expectations for the case when the test fails with Site Isolation.
Therefore this test is covered by virtual/not-site-per-process test
suite and an expectation for this test is added to the main
TestExpectations.
Lost test coverage
------------------
Even with extra caution described above, some test coverage may be lost:
- Features covered by tests only on one kind of platform (e.g. disabled
on Android) are at risk of losing OOPIF or non-OOPIF coverage.
- Before this CL, site-per-process was also applied to all other
`virtual/...` test suites. After this CL,
`virtual/not-site-per-process` will not provide such coverage.
Cleaned up test expectations
----------------------------
Some additional test expectations clean-up is done, while preserving
test coverage:
- The http/tests/perf/large-inlined-script.html test has been already
present in `SlowTests` and therefore I didn't include this test in the
new `virtual/not-site-per-process` suite.
- The http/tests/devtools/network/network-datareceived.js test was
already marked as expecting a `[Failure]` in TestExpectations and
therefore I didn't include this test in the new
`virtual/not-site-per-process` suite.
- The http/tests/devtools/console-cross-origin-iframe-logging.js test
was already marked as `[Timeout]` in the old TestExpectations but for
Win only. Since I can repro a timeout on Linux (with and without site
isolation), I just extended the old expectation to all platforms and I
didn't include this test in the new `virtual/not-site-per-process`
suite. I also removed the test from SlowTests (since timeouts in the
test are not expected everywhere).
Bug: 870761
Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64
Reviewed-on: https://chromium-review.googlesource.com/c/1302662
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604955}
Before this patch, a website could query PaymentRequest.canMakePayment()
with a single set of methods identifiers and parameters per user per 30
minutes. This prevented placing wallet-specific buttons on the page that
would be backed by one instance of PaymentRequest each, because only the
first of several PaymentRequest.canMakePayment() calls would succeed
before the quota limit was hit.
This patch adds per-method quota, which allows queries for different
payment method identifiers, as long as the method-specific parameters
remain unchanged for 30 minutes. The quota code on Android has been
refactored to use the common C++ code that is already used on desktop
and iOS. The new behavior is behind the
chrome://flags/#per-method-can-make-payment-quota flag, which is
disabled by default.
After this patch, if chrome://flags/#per-method-can-make-payment-quota
is enabled, a website can query PaymentRequest.canMakePayment() for
each payment method individually, as long as method-specific parameters
are unchanged. This allows placing wallet-specific buttons on the page
with each button backed by a separate instance of PaymentRequest.
Although the website can find out which wallets the user has, the quota
still hides the individual instruments within a wallet.
Change-Id: I5056984ef3ada913679d3e0d07b10394592b557f
Bug: 871791
Reviewed-on: https://chromium-review.googlesource.com/c/1293569
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604903}
Add support for the --isolated-script-test-repeat,
--isolated-script-test-launcher-retry-limit and
--isolated-script-test-also-run-disabled-tests flags, and unit
tests for these flags' behavior.
Bug: 894258
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I82cf1638779719b55b8b016c323100de572aae46
Reviewed-on: https://chromium-review.googlesource.com/c/1306662
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604763}
This requires 2 things: more robustly setting the Network Quality and
turning on Data Reduction Network Service feature. The latter is
required because IsDataReductionProxyEnabled is used by previews to
determine whether the user is a data saver user.
Bug: 778793
Change-Id: Ib0721ecb6bc25f2f324a966a997d3a6c2f5e60a5
Reviewed-on: https://chromium-review.googlesource.com/c/1313070
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604691}
The overall design is to decide on the proxies to mark as bad, and when to restart a request as part of the DRP's URLLoaderThrottle.
This CL is complete enough to pass fallback browser_tests, however it hacks around one piece of unimplemented functionality: the DRP configuration is not yet synchronized to throttle, so it guesses it. This needs to be addressed in a follow-up.
Bug: 721403
Change-Id: If95e52aad825d6e2c3b73fd12fdfeb9e53ae6cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1297238
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604687}
Fixes the way the VR instrumentation tests are configured on
non-Daydream-ready devices (the chrome_public_test_vr_apk test suite)
so that all users have the necessary args instead of adding the args
in test_suite_exceptions.
This should be both cleaner and help catch future cases of the tests
being enabled on bots they shouldn't be, as the tests should immediately
fail due to trying to install VrCore without the APK being downloaded
instead of having a chance of passing due to VrCore happening to be
installed on the test device already.
Bug: 900972
Change-Id: I742621ab3696803b5f434a9b841f56cccda28879
Reviewed-on: https://chromium-review.googlesource.com/c/1313072
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604671}
These tests pass locally. Some blacklist entries were left over
after the bugs were fixed (e.g. https://crbug.com/866991 ) and
some were copied from the filter file for OopAsh but work fine
in single process Mash.
Change-Id: I0eb2087691b2f98e7f50361f6247c92f2afa0603
Reviewed-on: https://chromium-review.googlesource.com/c/1309320
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604664}
This reverts commit 76f7d242a2.
Reason for revert: Failing LockScreenNoteTakingTest.Launch on
MSan bot, see crbug.com/899055
Original change's description:
> Let ash provide window show state if client has SHOW_STATE_DEFAULT
>
> For lock screen app windows the window manager needs to specify the
> initial show state of the window. Ensure the client (chrome) does not
> overwrite the aura window show-state property in ash if the client
> window has ui::SHOW_STATE_DEFAULT.
>
> Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash
>
> Bug: 899055
> Test: added to views_mus_unittests
>
> Change-Id: Ib7b6f9a060835ebf3e017737e4b98387a31831c8
> Reviewed-on: https://chromium-review.googlesource.com/c/1303273
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604517}
TBR=jamescook@chromium.org,tbarzic@chromium.org,sky@chromium.org,tsepez@chromium.org
Change-Id: I809656b611b297daf7c1bacb5ec620a94ee3f235
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899055
Reviewed-on: https://chromium-review.googlesource.com/c/1312931
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604591}
For lock screen app windows the window manager needs to specify the
initial show state of the window. Ensure the client (chrome) does not
overwrite the aura window show-state property in ash if the client
window has ui::SHOW_STATE_DEFAULT.
Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash
Bug: 899055
Test: added to views_mus_unittests
Change-Id: Ib7b6f9a060835ebf3e017737e4b98387a31831c8
Reviewed-on: https://chromium-review.googlesource.com/c/1303273
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604517}
