If the proper flag (kFencedFramesLocalUnpartitionedDataAccess) is
enabled, sharedStorage.get() can now be called in fenced frames.
The call will only succeed if the entire tree rooted at the fenced
frame has disabled untrusted network access, including nested
fenced frames trees.
Bug: 324440086
Change-Id: Ie6788ba6d299a334800ecf11ba90151eaf40f43d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279221
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Andrew Verge <averge@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272982}
The UX is: as long as the browser sends out the BeforeUnload IPC to the
renderer, we play the cancel animation to bring back the active page,
even if the renderer decides to not show the prompt at all (e.g., if
the page doesn't have a sticky user activation).
In real world testing, the IPC exchange is so fast (in the case where
the renderer doesn't show the prompt and acks to proceed) that the
cancel animation never gets to play a single frame (even on a debug
build). This is close the the ideal UX mentioned below.
Ideally we want to only play the cancel animation if the renderer
decides to show the prompt. While this is a better UX, it makes the
impl complicated as we need to decide what to show after the user lifts
the finger and before the renderer asks the browser to draw the prompt.
(presumably the invoke animation, then plays the cancel animation when
the renderer acks to show the prompt).
Alternatively, we could let the browser not send out the BeforeUnload
message if we know that the renderer for sure will always ack with
proceed. RFHI::HasStickyUserActivation already has the information,
though the source of truth is passed from the renderer. However we
don't really know the complication of changing the BeforeUnload flow
so this current impl is the best option for now.
Bug: 1421009
Low-Coverage-Reason: TRIVIAL_CHANGE
Change-Id: I993faba663075f5519321d69c26afa2b26404974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5325441
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: William Liu <liuwilliam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272861}
AwContentsIoThreadClient manages the correspondence of RFHs and Java IO
threads. Before this CL, AwContentsIoThreadClient assumed that the
FrameTreeNode associated with an RFH never change in its lifetime,
which doesn't hold in prerender activation.
This CL makes AwContentsIoThreadClient prerender-ready by adding
RenderFrameHost/FrameTree swap handling.
Note that the change is behind a feature flag kWebViewPrerender2 and
does nothing if it is disabled.
This CL is necessary for the first test of Prerender for WebView. We'll
add a test for back navigation after [2] landed.
[1] https://docs.google.com/document/d/1Pnf6c7jF04RpA6m_lStTKofLAb-xBoc65H_BKhy-KRE
[2] https://crrev.com/c/5269709
Credit: This CL was written by kenoss@ (not nhiroki@)
Fixed: b/41492762
Change-Id: I02b9e293f69a8ed0f9322e3087a4aa05041228ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5316140
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272806}
Start adding No-Vary-Search support for prerender2.
In this CL, add a feature flag and cache No-Vary-Search header
on PrerenderHost when the head is received.
Bug: 41494389
Change-Id: Ieec3faaf991245499ff78f19efc0d49e45dc0a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318878
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272738}
This reverts commit 0b48266711.
Reason for revert: Causes widespread flakiness in http/tests/devtools
web tests. see crbug.com/329487276 for one example bug with links to
test histories.
Original change's description:
> Update test runner to account for same-site RFH change
>
> With RenderDocument, we can change RenderFrames within the same
> process. This is not currently handled correctly by some parts of the
> WebTestControlHost. This is fixed by this CL by:
> - Making WebTestWindowObserver observe pre-existing speculative RFHs
> (it would miss them otherwise since those already called
> RenderFrameCreated before the construction of WebTestWindowObserver)
> - Making WebTestControlHost call ReplicateWebTestRuntimeFlagsChanges
> on all WebTestRenderFrameRemotes instead of only one per renderer
> process (as there can be multiple)
>
> Bug: 936696
> Change-Id: I4184a29de9c21bce3029fbe7bd7d15ffa98b10db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368628
> Reviewed-by: Fergal Daly <fergal@chromium.org>
> Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
> Commit-Queue: Fergal Daly <fergal@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1271970}
Bug: 936696, 329518758, 329487276
Change-Id: I1ea2466a6672ba21d0dfdd702bb0899b481171f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366211
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272667}
Since the ServiceWorker static routing API gets included in the
specification (https://w3c.github.io/ServiceWorker/), let me update code
comments to point out it. If it is not feasible to point out the
specification, let me point out the WICG page instead of my personal
github repository.
Also, this CL removed "Experimental" because the API became the
specification, and it is not experimental any more.
Bug: 40241479
Change-Id: I0c71d85d4025aeb5bc86e7ae072676c6657f7e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366431
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272604}
A WebContentsImpl must notify all RenderFrameHostImpls for which it is
the RenderFrameHostDelegate when there is a change in the accessibility
mode flags; including frame hosts that are in the back-forward cache.
Previously, frame hosts in the BF cache were not notified, which could
lead to them receiving accessibility updates and events from a renderer
after accessibility had been turned off for the owning WebContents.
Bug: 326751711
Change-Id: I164b4ff8285a2c0d94db9a3caac53db73cd51456
Fixed: 326262509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368451
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272548}
Child processes on Windows cannot always open their log file
(for instance if they cannot determine the user-data-dir) making
configuration of logging complicated. Child processes also need
a sandbox exception to open their log files.
This CL replaces logging related flags to pass a handle to children
in cases where a file would have been passed, allowing a later CL
to remove the sandbox rule allowing direct access to the log file.
If the browser is run with `--enable-logging --log-file=file`,
children will now be run with `--enable-logging=handle --log-file=N`.
It is not possible to mix stderr logging with file logging (it will
still work for the browser process), but this already does not work
in official builds as std handles are not passed into children.
This also allows the CHROME_LOG_FILE to be useful again for renderer
processes if Chrome is run using:
$env:CHROME_LOG_FILE="d:\temp\env-log.log"
chrome.exe --enable-logging
the browser will inspect the env var and provide a handle to that
file when starting renderer processes.
Running the browser with --enable-logging=handle directly is not
supported, these flags should only be provided by the browser when
starting child processes.
Tests: Manually tested results https://docs.google.com/document/d/1Hq37YReGM91fmcCcqkRbjtjwP62FVH_zpZtfpSPlLeY/edit?usp=sharing
Bug: 328285906, 40270808
Change-Id: Id79731b2d35ab3ee58f6c1612990bdec1485da68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5337202
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272538}
The code to enable the XNNPACK delegate when the right build flags are
set was accidentally removed in the final version of r1266242.
This change restores that code and refactors the buildflag header target
so that the state of the build_tflite_with_xnnpack flag defined in
//third_party/tflite/features.gni is available in a buildflag header
without depending on //components/optimization_guide.
Bug: 326356909
Change-Id: I609488f260b6844452416a592edcb7cd455cb40e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5363635
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272511}
This is the final change to enable contrast and gamma values from the
registry to get plumbed into Skia. This is not currently enabled
for web_tests - instead command line values are used to verify
that the text contrast has changed. A follow-up will enable registry
values for web_tests.
Values for contrast and gamma are stored on FontRenderParams, and
plumbed into Skia via LegacyDisplayGlobals. Tests were added for
rendering via a new VirtualTestSuite, and since this goes through
a different path than the browser, additional tests were added for
plumbing FontRenderParams values.
Two new command line flags are added here, for setting contrast
and gamma respectively. These are used in the virtual test suite
but also apply to the browser.
Bug: 1160653
Change-Id: I892a17dae636f2779c13dc3bba1bb81dc97dbff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5283107
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272465}
This CL aligns the class name 'GeolocationSystemPermissionManager' with
its focused functionality as part of the ongoing `GeolocationManager`
refactoring. Previously, `GeolocationManager` handled both location
updates and system permission management. This refactoring streamlines
responsibilities and improves code readability.
Bug: 41496017
Change-Id: I7cd2e76b9e37f32df5c7e739cbc405f4e9c376c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5354161
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Alvin Ji <alvinji@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272449}
Deprecating `IntAttribute` for the `ariaNotify` interrupt and priority
properties in favor of a `IntListAttribute` for both, which will allow
multiple notifications to be serialized into `AXNodeData`.
After this change, `SerializeAriaNotificationAttributes` still overrides
a single notification within `AXNodeData`. A later patch will correctly
plumb the notifications through these attribute lists.
Bug: 326277796
Change-Id: Ica6fc1077b35f2f61baac5e62f0a67832229035a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5347447
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1272432}
This differentiates a failed query from successful one that has empty
result, and forces callers to deal with the failure.
This CL also adds metric to count the failed queries.
Change-Id: Ia6a11370405156787446aa0e8e9fa75220699767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370391
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272419}
The browser process always uses RasterInterface/RasterDecoder now which
is provided from RasterContextProvider. Update GPU browser tests to
match the real implementation. Also remove GrContextKeepsGpuChannelAlive
test since the browser never uses GrContext anymore.
Bug: 40598922
Change-Id: I30131dcb91bb5fb05d99ce407980585bf54bb84e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5361314
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272403}
I believe the reason for the crashes is that when
shrinking the ring buffer size (AdjustForBackground), I
wasn't adjusting global_empty_slot_span_ring_index. This
meant that if global_empty_slot_span_ring_index was >
kMinFreeableSpans, a slot-span could end up being assigned
an index beyond the ring buffer size. This is because
SlotSpanMetadata::RegisterEmpty increments
global_empty_slot_span_ring_index based on the current index and
global_empty_slot_span_ring_size:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/third_party/angle/third_party/dawn/third_party/angle/third_party/dawn/third_party/partition_alloc/src/partition_alloc/partition_page.cc;l=115-116;drc=4b0447a323de1a925d2b08127e256ef735d73fc3
Also, in this version the features are all disabled. I'll enable
via field trial.
Original description:
Calling to madvise/mprotect is expensive on macs. This patch aims
to reduce the number of such calls. It adds the following:
. Increases empty cache index bits by 8.
. If RegisterEmpty() is called and the slot span was already
registered, don't do anything. This is in hopes of avoiding
churn if a slot-span is reused a bunch.
. Increases max_empty_slot_spans_dirty_bytes_shift by a factor of 2.
. Adds feature for that makes blink's partition for buffers use the
large empty slot span ring.
Bug: 329199197
Change-Id: I819ba2ba82bbed83cba40d7561f21f4aa19ff088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5362719
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272345}
Currently, RenderAccessibilityImpl is an observer of RenderFrameImpl
and reacts to AccessibilitymodeChanged to set up or tear down Blink
accessibility.
This is a problem because, depending on when the observers are added,
RenderAccessibilityImpl may be the *last* observer called. In those
cases, previous observers e.g. PdfAccessibilityTree, may inaccurately
conclude that accessibility isn't on when it *is*, or not have access to
state that should be there e.g. WebAXObjects.
Fix this by making the direct mode changed call from
RenderAccessibilityManager -> RenderAccessibilityImpl (which it owns
anyway).
We also re-enable some PDF a11y tests. These tests were flakey and more
recently, consistently failing after the work in
go/chrome-pdf-a11y-stabilization. It is likely for both cases, this
change found and fixed the root cause of the once flakes now
fails.
R=aleventhal@chromium.org
Bug: 327458821
Test: cq
Change-Id: I28a63ee6e4149b31f0b0ea097b129eea3a293e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369374
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/main@{#1272326}
This is a refactor-only change to make a subsequent change to the
accessibility internals page more straightforward.
In doing so, this change also reduces duplication in the platform-specific logic of ax_inspect_factory.
Bug: 325316128
Change-Id: Ic219bee931243e9730cf04e3459075901dffc881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319138
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1272320}
There's currently an issue where IDS_ACTIONBAR_SHARE and
IDS_ACTIONBAR_WEB_SEARCH aren't being translated properly. It's unclear
whether this is a build issue or a context issue. The bug is only
reproducible on release builds so we can submit this CL, check the
output of the logs on canary and revert the CL at the end of the week.
Bug: 41486995
Change-Id: I6c5fdfebd92751fd22daf795ecea5200f9e2cd98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5361597
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Alex Mitra <alexmitra@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272299}
This CL continues the work on unifying the paths of the AssistData
structure builds. With this CL we add some of the populate methods
to the AssistDataBuilder and add implementation details on the
native side of the JNI bridge.
AX-Relnotes: N/A
Bug: 325665399
Change-Id: I62e593437771fb924832938042187b8007ce4d7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5350542
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1272292}
For example, a test that was previously called
AttributionInteropTestInputs/AttributionInteropTest.HasExpectedOutput/event_source
is now called
AttributionInteropTest.HasExpectedOutput/event_source
reducing log output and making it easier to parse visually.
Change-Id: I4d66a41e6808d6f5845880691f98134817688d29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370510
Commit-Queue: Nan Lin <linnan@chromium.org>
Auto-Submit: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272277}
This is a reland of commit 49599d8641
Original change's description:
> Move code from base::ByteSwap to base::numerics and fix UB casts
>
> While moving ByteSwap() callers, I found the DTS code doing byte swaps
> by casting byte spans to uint16_t spans, which causes UB if they are
> not aligned. The function explicitly handles non-16-bit aligned inputs
> earlier, so clearly it's expected and we should not CHECK on the
> alignment. So instead, change the code to work with bytes and do the
> swaps in a for loop.
>
> While here, make use of the new split_at() to split the output span
> up into disjoint subspans that are each written to.
>
> R=dalecurtis@chromium.org
>
> Bug: 40284755
> Change-Id: I11c557fd3e0f6fd64555b299f3492ca7722aeae2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366084
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Owners-Override: danakj <danakj@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1271821}
Bug: 40284755
Change-Id: I6a067c0bee14898006163a5706bff5e9947843f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366281
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272244}
ByteSwap + memcpy (or similar via iterators) can be spelt more clearly
with the new base::numerics byte conversions to convert to and from
byte arrays of big/little endian.
Some code uses BigEndianReader + ByteSwap to read little endian
buffers! Introduce SpanReader to provide a simple api around reading
off the front of the span dynamically in place of using many nested
split_at() calls.
SpanReader overlaps with BufferIterator in some ways, but it provides
a more ergonomic API for reading off spans (including fixed size
spans) and dealing with running out of room explicitly, like
BigEndianReader did. And it does not introduce the complexity of
worrying about seeking or truncating to users of the API.
Bug: 40284755
Change-Id: I1a3c44f0016e74f17c6282a51e5eca9dae7fad01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5353355
Reviewed-by: Tomas Gunnarsson <tommi@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272236}
This reverts commit 872620ee34.
Reason for revert: Unregistering before the broadcast receiver is registered, due to delayed registration running in BG thread, causes an exception. We should revert, and in the re-land, add a sequenced task runner to make sure the registration occurred before unregistering the broadcast receiver.
Original change's description:
> Posting registerLocaleChangeReceiver to BG thread
>
> This is in an effort to move as many calls to
> ContextUtils#registerProtectedBroadcastReceiver off of the UIThread.
> This is part of an effort to improve runtime performance by reducing
> the number of IActivityManager binder transactions in the UIThread.
>
> Bug: b:325352920
> Change-Id: I61ea80fbaa26929d96aaf5673ae7d467c0412b56
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366686
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Adam Walls <avvall@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1271847}
Bug: b:325352920
Change-Id: I5ed7284fb3b6dd858a78e22acfa1780791096049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367547
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Auto-Submit: Adam Walls <avvall@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1272201}
The browser process seems to be getting invalid report URLs from bidder
worklet processes for unknown reasons. This CL adds some
DumpWithoutCrashing() calls to the bidder worklet logic to try to locate
the call path that's causing this.
Bug: 41496188
Change-Id: I63a21f56ecbf83f61c37ed60b6069ebb8e7500ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366521
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272196}
This patch adds a new IPC to inform the renderer that the paint holding
timeout has been reached and the graphics has been cleared.
We use this signal to skip the view transition which would have looked
bad:
page A -> blank screen -> animation from page A to page B.
Now, we see the following:
page A -> blank screen -> page B.
R=rakina@chromium.org, khushalsagar@chromium.org
Bug: 41489647
Change-Id: I839892083fc3bde32a246833b51782289d51c878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5361318
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272160}
This adds the assumption that filename is non-empty. This
was always true for Wayland and the non-backed provider but
not for Windows or X11.
Bug: 328710562
Include-Ci-Only-Tests: true
Change-Id: I17940549535b310fd518cceff2f50cb5796c2eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5362337
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272151}
Currently the CookiePartitionKey (de)serialization methods consume or return a string that contains the top_level_site. The future incorporation of the ancestor chain bit means that the bit would have to be serialized into that string. Which has the potential to cause errors and might be unclear to developers when the serialized string is utilized in other parts of the system. Using a defined class will prevent these issues and allow for future extension if required.
Bug: 326610082
Change-Id: I7a72b3640f86aaa57827ca4f474a8a1ea573af86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321100
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Aaron Selya <selya@google.com>
Commit-Queue: Aaron Selya <selya@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272146}
... by making the expectation conceptually a vector.
Practically, it's a variant of a mojom::BidderWorkletBidPtr and a
vector thereof, which means tests that expected one or zero bids don't
have to change, even if tests that expect more are a bit clumsy.
Change-Id: Ia261b56e1c0763ce685cbb2c2983684b1d8e7b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367562
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272130}
