4b552a72fe
This idiom is very easy to get wrong, and should be avoided. It can be replaced with std::erase[_if] or base::Erase[If]. A followup CL will add a presubmit to prevent backsliding. Bug: 41408868 Change-Id: I6d7c9c793424e8e40503b2e5afaed77da94d1e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427068 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Owners-Override: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1442311}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.ccso it lives alongside existing features - Add your new feature to the list of
kFeaturesincast_features.cc
BASE_FEATURE(kMyFeature, "my_feature", base::FEATURE_DISABLED_BY_DEFAULT);
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}